Fixed: <rdar://problem/3961809> plug-in code attempts to load empty URL

        Reviewed by john.

        * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView didStart]): don't start load if URL is empty

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index b45836513d98b0509bd18f9b73579bf1022cc5da..2d26bc2186d00b3ef7e670a27ccb81dfe7170062 100644 (file)
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,12 @@
+2005-01-19  Chris Blumenberg  <cblu@apple.com>
+
+       Fixed: <rdar://problem/3961809> plug-in code attempts to load empty URL
+
+        Reviewed by john.
+
+        * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
+        (-[WebNetscapePluginEmbeddedView didStart]): don't start load if URL is empty
+
 2005-01-17  Darin Adler  <darin@apple.com>
 
         * DOM.subproj/DOMPrivate.h: Check in generated file.

diff --git a/WebKit/Plugins.subproj/WebNetscapePluginEmbeddedView.m b/WebKit/Plugins.subproj/WebNetscapePluginEmbeddedView.m
index 8bf1f17326dd4579b6364bc3b48d0ff7b797326b..1f67e08439f2b275825cdf2abf1c6a1b617196ea 100644 (file)
--- a/WebKit/Plugins.subproj/WebNetscapePluginEmbeddedView.m
+++ b/WebKit/Plugins.subproj/WebNetscapePluginEmbeddedView.m
@@ -53,7 +53,9 @@
 
 - (void)didStart
 {
-    if (URL != nil) {
+    // If the OBJECT/EMBED tag has no SRC, the URL is passed to us as "".
+    // Check for this and don't start a load in this case.
+    if (URL != nil && ![URL _web_isEmpty]) {
         NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:URL];
         [request setHTTPReferrer:[[[[self dataSource] request] URL] _web_originalDataAsString]];
         [self loadRequest:request inTarget:nil withNotifyData:nil sendNotification:NO];