remove two notImplemented() warnings, as I believe we don't
authorhausmann <hausmann@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 7 Nov 2007 12:47:39 +0000 (12:47 +0000)
committerhausmann <hausmann@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 7 Nov 2007 12:47:39 +0000 (12:47 +0000)
have to implement these methods. Add some (commented out)
debug code in one place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/qt/ChangeLog
WebKit/qt/WebCoreSupport/EditorClientQt.cpp

index 12d0313f0ec25167d582a4624578d2d329eaed15..55c8c903b0f2208d2b5bce740cf54b596bb7d819 100644 (file)
@@ -1,3 +1,15 @@
+2007-11-07  Lars Knoll  <lars@trolltech.com>
+
+        Reviewed by Simon.
+
+        remove two notImplemented() warnings, as I believe we don't
+        have to implement these methods. Add some (commented out)
+        debug code in one place.
+
+        * WebCoreSupport/EditorClientQt.cpp:
+        (WebCore::EditorClientQt::respondToChangedSelection):
+        (WebCore::EditorClientQt::didWriteSelectionToPasteboard):
+
 2007-11-05  Tristan O'Tierney  <tristan@apple.com>
 
         Reviewed by Darin Adler.
index 8f769c1fc818dda17c36de7f4cfd475efb4f5582..40d1307f30724edcbea3bd544f872361b878e746 100644 (file)
@@ -35,6 +35,7 @@
 
 #include "Document.h"
 #include "EditCommandQt.h"
+#include "Page.h"
 #include "Editor.h"
 #include "FocusController.h"
 #include "Frame.h"
@@ -210,6 +211,10 @@ void EditorClientQt::respondToChangedSelection()
 {
     if (dumpEditingCallbacks)
         printf("EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification\n");
+//     const Selection &selection = m_page->d->page->selection();
+//     char buffer[1024];
+//     selection.formatForDebugger(buffer, sizeof(buffer));
+//     printf("%s\n", buffer);
 
     emit m_page->selectionChanged();
 }
@@ -223,12 +228,10 @@ void EditorClientQt::didEndEditing()
 
 void EditorClientQt::didWriteSelectionToPasteboard()
 {
-    notImplemented();
 }
 
 void EditorClientQt::didSetSelectionTypesForPasteboard()
 {
-    notImplemented();
 }
 
 bool EditorClientQt::selectWordBeforeMenuEvent()