Reviewed by John.

	<rdar://problem/3632570>: (REGRESSION: SocialText.net wiki keeps asking for auth, even though pages load)

        * Misc.subproj/WebIconLoader.m:
        (-[WebIconLoader didReceiveAuthenticationChallenge:]): Ignore the challenge - we don't
	want an auth panel for favicons.
        (-[WebIconLoader didCancelAuthenticationChallenge:]): Ignore cancel, since we are ignoring
	the challenge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index bedbed867db0029e340a0b541c3c666dc8d61202..78f0c804d359058928c254e17014846d7214bf9d 100644 (file)
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2004-07-12  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by John.
+
+       <rdar://problem/3632570>: (REGRESSION: SocialText.net wiki keeps asking for auth, even though pages load)
+
+        * Misc.subproj/WebIconLoader.m:
+        (-[WebIconLoader didReceiveAuthenticationChallenge:]): Ignore the challenge - we don't
+       want an auth panel for favicons.
+        (-[WebIconLoader didCancelAuthenticationChallenge:]): Ignore cancel, since we are ignoring
+       the challenge.
+
 2004-07-09  Chris Blumenberg  <cblu@apple.com>
        
        Allowed my change for 3715785 to compile on Jaguar.

diff --git a/WebKit/Misc.subproj/WebIconLoader.m b/WebKit/Misc.subproj/WebIconLoader.m
index 28d4e9eb20478099c75e4e045fcd088d18093804..6d3955bbbd50de81796fd3eeae7529fe2734c033 100644 (file)
--- a/WebKit/Misc.subproj/WebIconLoader.m
+++ b/WebKit/Misc.subproj/WebIconLoader.m
@@ -94,4 +94,15 @@
     [super didFinishLoading];
 }
 
+// We don't ever want to prompt for authentication just for a site icon, so
+// override this WebBaseResourceDelegate method to refuse the challenge
+- (void)didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge
+{
+    [[challenge sender] cancelAuthenticationChallenge:challenge];
+}
+
+- (void)didCancelAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge
+{
+}
+
 @end