Remove LegacyDefaultOptionalArguments flag from Document.idl
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 5 Aug 2011 00:39:28 +0000 (00:39 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 5 Aug 2011 00:39:28 +0000 (00:39 +0000)
https://bugs.webkit.org/show_bug.cgi?id=65717

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* dom/Document.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/dom/Document.idl

index 3ac3dc0fa40979dcce0e241a529ba64a79bcf463..e217ef361670e696f2e1412f02e03196b0a0914e 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-04  Mark Pilgrim  <pilgrim@chromium.org>
+
+        Remove LegacyDefaultOptionalArguments flag from Document.idl
+        https://bugs.webkit.org/show_bug.cgi?id=65717
+
+        Reviewed by Adam Barth.
+
+        No new tests, all existing tests pass.
+
+        * dom/Document.idl:
+
 2011-08-04  Simon Fraser  <simon.fraser@apple.com>
 
         Fix release build failure with last commit.
index 3d704ac536aa09b93eeff5f160a53ae97e1d7311..652767fb851a1a1673edf166de0b8a8ec90f509e 100644 (file)
@@ -21,7 +21,6 @@
 module core {
 
     interface [
-        LegacyDefaultOptionalArguments,
         CustomToJS,
         GenerateNativeConverter,
         InlineGetOwnPropertySlot
@@ -32,36 +31,36 @@ module core {
         readonly attribute DOMImplementation implementation;
         readonly attribute Element documentElement;
 
-        [ReturnsNew] Element createElement(in [ConvertNullToNullString] DOMString tagName)
+        [ReturnsNew] Element createElement(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString tagName)
             raises (DOMException);
         DocumentFragment   createDocumentFragment();
-        [ReturnsNew] Text createTextNode(in DOMString data);
-        [ReturnsNew] Comment createComment(in DOMString data);
-        [ReturnsNew] CDATASection createCDATASection(in DOMString data)
+        [ReturnsNew] Text createTextNode(in [Optional=CallWithDefaultValue] DOMString data);
+        [ReturnsNew] Comment createComment(in [Optional=CallWithDefaultValue] DOMString data);
+        [ReturnsNew] CDATASection createCDATASection(in [Optional=CallWithDefaultValue] DOMString data)
             raises(DOMException);
-        [OldStyleObjC, ReturnsNew] ProcessingInstruction createProcessingInstruction(in DOMString target,
-                                                                                     in DOMString data)
+        [OldStyleObjC, ReturnsNew] ProcessingInstruction createProcessingInstruction(in [Optional=CallWithDefaultValue] DOMString target,
+                                                                                     in [Optional=CallWithDefaultValue] DOMString data)
             raises (DOMException);
-        [ReturnsNew] Attr createAttribute(in DOMString name)
+        [ReturnsNew] Attr createAttribute(in [Optional=CallWithDefaultValue] DOMString name)
             raises (DOMException);
-        [ReturnsNew] EntityReference createEntityReference(in DOMString name)
+        [ReturnsNew] EntityReference createEntityReference(in [Optional=CallWithDefaultValue] DOMString name)
             raises(DOMException);
-        NodeList           getElementsByTagName(in DOMString tagname);
+        NodeList           getElementsByTagName(in [Optional=CallWithDefaultValue] DOMString tagname);
 
         // Introduced in DOM Level 2:
 
-        [OldStyleObjC, ReturnsNew] Node importNode(in Node importedNode,
-                                                   in boolean deep)
+        [OldStyleObjC, ReturnsNew] Node importNode(in [Optional=CallWithDefaultValue] Node importedNode,
+                                                   in [Optional=CallWithDefaultValue] boolean deep)
             raises (DOMException);
-        [OldStyleObjC, ReturnsNew] Element createElementNS(in [ConvertNullToNullString] DOMString namespaceURI,
-                                                           in [ConvertNullToNullString] DOMString qualifiedName)
+        [OldStyleObjC, ReturnsNew] Element createElementNS(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString namespaceURI,
+                                                           in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString qualifiedName)
             raises (DOMException);
-        [OldStyleObjC, ReturnsNew] Attr createAttributeNS(in [ConvertNullToNullString] DOMString namespaceURI,
-                                                          in [ConvertNullToNullString] DOMString qualifiedName)
+        [OldStyleObjC, ReturnsNew] Attr createAttributeNS(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString namespaceURI,
+                                                          in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString qualifiedName)
             raises (DOMException);
-        [OldStyleObjC] NodeList getElementsByTagNameNS(in [ConvertNullToNullString] DOMString namespaceURI,
-                                                       in DOMString localName);
-        Element            getElementById(in DOMString elementId);
+        [OldStyleObjC] NodeList getElementsByTagNameNS(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString namespaceURI,
+                                                       in [Optional=CallWithDefaultValue] DOMString localName);
+        Element            getElementById(in [Optional=CallWithDefaultValue] DOMString elementId);
 
         // DOM Level 3 Core
 
@@ -73,14 +72,14 @@ module core {
                  attribute boolean xmlStandalone
                     setter raises (DOMException);
 
-        Node               adoptNode(in Node source)
+        Node               adoptNode(in [Optional=CallWithDefaultValue] Node source)
             raises (DOMException);
 
                  attribute [ConvertNullStringTo=Null, ConvertNullToNullString] DOMString documentURI;
 
         // DOM Level 2 Events (DocumentEvents interface)
 
-        Event              createEvent(in DOMString eventType)
+        Event              createEvent(in [Optional=CallWithDefaultValue] DOMString eventType)
             raises(DOMException);
 
         // DOM Level 2 Tranversal and Range (DocumentRange interface)
@@ -89,15 +88,15 @@ module core {
 
         // DOM Level 2 Tranversal and Range (DocumentTraversal interface)
 
-        [OldStyleObjC] NodeIterator createNodeIterator(in Node root,
-                                                       in unsigned long whatToShow,
-                                                       in NodeFilter filter,
-                                                       in boolean expandEntityReferences)
+        [OldStyleObjC] NodeIterator createNodeIterator(in [Optional=CallWithDefaultValue] Node root,
+                                                       in [Optional=CallWithDefaultValue] unsigned long whatToShow,
+                                                       in [Optional=CallWithDefaultValue] NodeFilter filter,
+                                                       in [Optional=CallWithDefaultValue] boolean expandEntityReferences)
             raises(DOMException);
-        [OldStyleObjC] TreeWalker createTreeWalker(in Node root,
-                                                   in unsigned long whatToShow,
-                                                   in NodeFilter filter,
-                                                   in boolean expandEntityReferences)
+        [OldStyleObjC] TreeWalker createTreeWalker(in [Optional=CallWithDefaultValue] Node root,
+                                                   in [Optional=CallWithDefaultValue] unsigned long whatToShow,
+                                                   in [Optional=CallWithDefaultValue] NodeFilter filter,
+                                                   in [Optional=CallWithDefaultValue] boolean expandEntityReferences)
             raises(DOMException);
 
         // DOM Level 2 Abstract Views (DocumentView interface)
@@ -110,27 +109,27 @@ module core {
 
         // DOM Level 2 Style (DocumentCSS interface)
 
-        [OldStyleObjC] CSSStyleDeclaration getOverrideStyle(in Element element,
-                                                            in DOMString pseudoElement);
+        [OldStyleObjC] CSSStyleDeclaration getOverrideStyle(in [Optional=CallWithDefaultValue] Element element,
+                                                            in [Optional=CallWithDefaultValue] DOMString pseudoElement);
 #if defined(ENABLE_XPATH) && ENABLE_XPATH
         // DOM Level 3 XPath (XPathEvaluator interface)
-        [OldStyleObjC] XPathExpression createExpression(in DOMString expression,
-                                                        in XPathNSResolver resolver)
+        [OldStyleObjC] XPathExpression createExpression(in [Optional=CallWithDefaultValue] DOMString expression,
+                                                        in [Optional=CallWithDefaultValue] XPathNSResolver resolver)
             raises(DOMException);
         XPathNSResolver    createNSResolver(in Node nodeResolver);
-        [OldStyleObjC, V8Custom] XPathResult evaluate(in DOMString expression,
-                                                      in Node contextNode,
-                                                      in XPathNSResolver resolver,
-                                                      in unsigned short type,
-                                                      in XPathResult inResult)
+        [OldStyleObjC, V8Custom] XPathResult evaluate(in [Optional=CallWithDefaultValue] DOMString expression,
+                                                      in [Optional=CallWithDefaultValue] Node contextNode,
+                                                      in [Optional=CallWithDefaultValue] XPathNSResolver resolver,
+                                                      in [Optional=CallWithDefaultValue] unsigned short type,
+                                                      in [Optional=CallWithDefaultValue] XPathResult inResult)
             raises(DOMException);
 #endif // ENABLE_XPATH
 
         // Common extensions
 
-        boolean            execCommand(in DOMString command,
-                                       in boolean userInterface,
-                                       in [ConvertUndefinedOrNullToNullString] DOMString value);
+        boolean            execCommand(in [Optional=CallWithDefaultValue] DOMString command,
+                                       in [Optional=CallWithDefaultValue] boolean userInterface,
+                                       in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString value);
 
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
         // FIXME: remove the these two versions once [Optional] is implemented for Objective-C.
@@ -139,11 +138,11 @@ module core {
         boolean            execCommand(in DOMString command);
 #endif
 
-        boolean            queryCommandEnabled(in DOMString command);
-        boolean            queryCommandIndeterm(in DOMString command);
-        boolean            queryCommandState(in DOMString command);
-        boolean            queryCommandSupported(in DOMString command);
-        [ConvertNullStringTo=False] DOMString queryCommandValue(in DOMString command);
+        boolean            queryCommandEnabled(in [Optional=CallWithDefaultValue] DOMString command);
+        boolean            queryCommandIndeterm(in [Optional=CallWithDefaultValue] DOMString command);
+        boolean            queryCommandState(in [Optional=CallWithDefaultValue] DOMString command);
+        boolean            queryCommandSupported(in [Optional=CallWithDefaultValue] DOMString command);
+        [ConvertNullStringTo=False] DOMString queryCommandValue(in [Optional=CallWithDefaultValue] DOMString command);
 
         // Moved down from HTMLDocument
 
@@ -174,7 +173,7 @@ module core {
         readonly attribute HTMLCollection anchors;
         readonly attribute DOMString lastModified;
 
-        NodeList getElementsByName(in DOMString elementName);
+        NodeList getElementsByName(in [Optional=CallWithDefaultValue] DOMString elementName);
 
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
                  attribute [Custom] Location location;
@@ -186,8 +185,10 @@ module core {
         readonly attribute [ConvertNullStringTo=Undefined] DOMString defaultCharset;
         readonly attribute [ConvertNullStringTo=Undefined] DOMString readyState;
 
-        Element            elementFromPoint(in long x, in long y);
-        Range              caretRangeFromPoint(in long x, in long y);
+        Element            elementFromPoint(in [Optional=CallWithDefaultValue] long x, 
+                                            in [Optional=CallWithDefaultValue] long y);
+        Range              caretRangeFromPoint(in [Optional=CallWithDefaultValue] long x, 
+                                               in [Optional=CallWithDefaultValue] long y);
 
         // Mozilla extensions
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
@@ -226,14 +227,14 @@ module core {
 #endif
 
         // HTML 5
-        NodeList getElementsByClassName(in DOMString tagname);
+        NodeList getElementsByClassName(in [Optional=CallWithDefaultValue] DOMString tagname);
 
         readonly attribute DOMString compatMode;
 
         // NodeSelector - Selector API
-        [RequiresAllArguments=Raise] Element querySelector(in DOMString selectors)
+        Element querySelector(in DOMString selectors)
             raises(DOMException);
-        [RequiresAllArguments=Raise] NodeList querySelectorAll(in DOMString selectors)
+        NodeList querySelectorAll(in DOMString selectors)
             raises(DOMException);
 
 #if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
@@ -318,17 +319,17 @@ module core {
 #endif
 
 #if defined(ENABLE_TOUCH_EVENTS) && ENABLE_TOUCH_EVENTS
-        [ReturnsNew, EnabledAtRuntime] Touch createTouch(in DOMWindow window,
-                                                         in EventTarget target,
-                                                         in long identifier,
-                                                         in long pageX,
-                                                         in long pageY,
-                                                         in long screenX,
-                                                         in long screenY,
-                                                         in long webkitRadiusX,
-                                                         in long webkitRadiusY,
-                                                         in float webkitRotationAngle,
-                                                         in float webkitForce)
+        [ReturnsNew, EnabledAtRuntime] Touch createTouch(in [Optional=CallWithDefaultValue] DOMWindow window,
+                                                         in [Optional=CallWithDefaultValue] EventTarget target,
+                                                         in [Optional=CallWithDefaultValue] long identifier,
+                                                         in [Optional=CallWithDefaultValue] long pageX,
+                                                         in [Optional=CallWithDefaultValue] long pageY,
+                                                         in [Optional=CallWithDefaultValue] long screenX,
+                                                         in [Optional=CallWithDefaultValue] long screenY,
+                                                         in [Optional=CallWithDefaultValue] long webkitRadiusX,
+                                                         in [Optional=CallWithDefaultValue] long webkitRadiusY,
+                                                         in [Optional=CallWithDefaultValue] float webkitRotationAngle,
+                                                         in [Optional=CallWithDefaultValue] float webkitForce)
             raises (DOMException);
         [ReturnsNew, EnabledAtRuntime, Custom] TouchList createTouchList()
             raises (DOMException);