The delta value in the chart pane sometimes doens't show '+' for a positive delta

https://bugs.webkit.org/show_bug.cgi?id=141340

Reviewed by Andreas Kling.

The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.

* public/v2/app.js:
(App.Pane.computeStatus):
(App.createChartData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 236f5a989ec4d0d310718082ec5068851e4eb54d..d18c34767098aa4c1a8f566e53e5c556737d39ba 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,17 @@
+2015-02-06  Ryosuke Niwa  <rniwa@webkit.org>
+
+        The delta value in the chart pane sometimes doens't show '+' for a positive delta
+        https://bugs.webkit.org/show_bug.cgi?id=141340
+
+        Reviewed by Andreas Kling.
+
+        The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
+        it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
+
+        * public/v2/app.js:
+        (App.Pane.computeStatus):
+        (App.createChartData):
+
 2015-02-06  Ryosuke Niwa  <rniwa@webkit.org>
 
         Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.

diff --git a/Websites/perf.webkit.org/public/v2/app.js b/Websites/perf.webkit.org/public/v2/app.js
index 3dc452f00d9ba3c2df872906d37d8c02b6f31d3f..9f0ea8c821ba99afa389a2c07474bd0c7e0de4a3 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/app.js
+++ b/Websites/perf.webkit.org/public/v2/app.js
@@ -406,9 +406,6 @@ App.Pane = Ember.Object.extend({
             label = formatter(Math.abs(diffFromTarget)) + ' until target';
 
         var valueDelta = previousPoint ? chartData.deltaFormatter(currentPoint.value - previousPoint.value) : null;
-        if (valueDelta && valueDelta > 0)
-            valueDelta = '+' + valueDelta;
-
         return {className: className, label: label, currentValue: chartData.formatter(currentPoint.value), valueDelta: valueDelta};
     },
     _relativeDifferentToLaterPointInTimeSeries: function (currentPoint, timeSeries)
@@ -445,7 +442,7 @@ App.createChartData = function (data)
         target: runs.target ? runs.target.timeSeriesByCommitTime() : null,
         unit: data.unit,
         formatter: data.useSI ? d3.format('.4s') : d3.format('.4g'),
-        deltaFormatter: data.useSI ? d3.format('.2s') : d3.format('.2g'),
+        deltaFormatter: data.useSI ? d3.format('+.2s') : d3.format('+.2g'),
         smallerIsBetter: data.smallerIsBetter,
     };
 }