+2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
+
+ The delta value in the chart pane sometimes doens't show '+' for a positive delta
+ https://bugs.webkit.org/show_bug.cgi?id=141340
+
+ Reviewed by Andreas Kling.
+
+ The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
+ it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
+
+ * public/v2/app.js:
+ (App.Pane.computeStatus):
+ (App.createChartData):
+
2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
label = formatter(Math.abs(diffFromTarget)) + ' until target';
var valueDelta = previousPoint ? chartData.deltaFormatter(currentPoint.value - previousPoint.value) : null;
- if (valueDelta && valueDelta > 0)
- valueDelta = '+' + valueDelta;
-
return {className: className, label: label, currentValue: chartData.formatter(currentPoint.value), valueDelta: valueDelta};
},
_relativeDifferentToLaterPointInTimeSeries: function (currentPoint, timeSeries)
target: runs.target ? runs.target.timeSeriesByCommitTime() : null,
unit: data.unit,
formatter: data.useSI ? d3.format('.4s') : d3.format('.4g'),
- deltaFormatter: data.useSI ? d3.format('.2s') : d3.format('.2g'),
+ deltaFormatter: data.useSI ? d3.format('+.2s') : d3.format('+.2g'),
smallerIsBetter: data.smallerIsBetter,
};
}