A few MallocBench record/replay fixes
authorggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 14 Apr 2014 19:11:50 +0000 (19:11 +0000)
committerggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 14 Apr 2014 19:11:50 +0000 (19:11 +0000)
https://bugs.webkit.org/show_bug.cgi?id=131627

Reviewed by Andreas Kling.

* MallocBench/MallocBench/Interpreter.cpp:
(Interpreter::run): Accept 0-sized allocations without asserting because
WebKit does that sometimes.

* MallocBench/MallocBench/flickr.ops:
* MallocBench/MallocBench/flickr_memory_warning.ops:
* MallocBench/MallocBench/reddit.ops:
* MallocBench/MallocBench/reddit_memory_warning.ops:
* MallocBench/MallocBench/theverge.ops:
* MallocBench/MallocBench/theverge_memory_warning.ops: Updated these
recordings because a bug in the recording mechanism caused one out of
every few thousand slot values to be bogus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/ChangeLog
PerformanceTests/MallocBench/MallocBench/Interpreter.cpp
PerformanceTests/MallocBench/MallocBench/flickr.ops
PerformanceTests/MallocBench/MallocBench/flickr_memory_warning.ops
PerformanceTests/MallocBench/MallocBench/reddit.ops
PerformanceTests/MallocBench/MallocBench/reddit_memory_warning.ops
PerformanceTests/MallocBench/MallocBench/theverge.ops
PerformanceTests/MallocBench/MallocBench/theverge_memory_warning.ops

index ce64fd5ecfab6d6a4d4017eec440b60b3bd7aab4..1effdf865bd45d96e67505d7f493e7fdbf2fc937 100644 (file)
@@ -1,3 +1,23 @@
+2014-04-14  Geoffrey Garen  <ggaren@apple.com>
+
+        A few MallocBench record/replay fixes
+        https://bugs.webkit.org/show_bug.cgi?id=131627
+
+        Reviewed by Andreas Kling.
+
+        * MallocBench/MallocBench/Interpreter.cpp:
+        (Interpreter::run): Accept 0-sized allocations without asserting because
+        WebKit does that sometimes.
+
+        * MallocBench/MallocBench/flickr.ops:
+        * MallocBench/MallocBench/flickr_memory_warning.ops:
+        * MallocBench/MallocBench/reddit.ops:
+        * MallocBench/MallocBench/reddit_memory_warning.ops:
+        * MallocBench/MallocBench/theverge.ops:
+        * MallocBench/MallocBench/theverge_memory_warning.ops: Updated these
+        recordings because a bug in the recording mechanism caused one out of
+        every few thousand slot values to be bogus.
+
 2014-04-13  Geoffrey Garen  <ggaren@apple.com>
 
         Added some website recordings to MallocBench -- taken from Membuster
index 9178b479f1b6345a1f436bc75d8c17151cf38a03..92636caff651fec26a125fdca7fb5dcd728880a9 100644 (file)
@@ -101,14 +101,12 @@ void Interpreter::run()
             }
             case op_free: {
                 assert(m_objects[op.slot].object);
-                assert(m_objects[op.slot].size);
                 mbfree(m_objects[op.slot].object, m_objects[op.slot].size);
                 m_objects[op.slot] = { 0, 0 };
                 break;
             }
             case op_realloc: {
                 assert(m_objects[op.slot].object);
-                assert(m_objects[op.slot].size);
                 m_objects[op.slot] = { mbrealloc(m_objects[op.slot].object, m_objects[op.slot].size, op.size), op.size };
                 break;
             }
index 9ea149900fcd593d0d2ce14dd1c105f452f88fd2..f78b4304ff0e8ad7cabdde0f1311b16027be4bca 100644 (file)
Binary files a/PerformanceTests/MallocBench/MallocBench/flickr.ops and b/PerformanceTests/MallocBench/MallocBench/flickr.ops differ
index 58438c9688dac10983f18e9473cbd3d80aec667d..2e59f91835246d434e28d46b130affc2d3a778f6 100644 (file)
Binary files a/PerformanceTests/MallocBench/MallocBench/flickr_memory_warning.ops and b/PerformanceTests/MallocBench/MallocBench/flickr_memory_warning.ops differ
index ccf25f72862cf1f7b7025d52e32cb8287dad275d..b8d9a7142964dd916522af1cf324579572c26108 100644 (file)
Binary files a/PerformanceTests/MallocBench/MallocBench/reddit.ops and b/PerformanceTests/MallocBench/MallocBench/reddit.ops differ
index 72883754d2aa8154eb0b5f94c0aaf16a03c7f6af..7048efb5fbdce022ff761fc41d4848cdd315729d 100644 (file)
Binary files a/PerformanceTests/MallocBench/MallocBench/reddit_memory_warning.ops and b/PerformanceTests/MallocBench/MallocBench/reddit_memory_warning.ops differ
index fcd364cdda83bfdc9ea0e1efa03f49b70d378d69..d73fbb4047bcc6177ed41a87856023239e2c81fb 100644 (file)
Binary files a/PerformanceTests/MallocBench/MallocBench/theverge.ops and b/PerformanceTests/MallocBench/MallocBench/theverge.ops differ
index 88ac20e76131884ae530e85d341cc2af8a91ab83..9a8d12da03fa659fd0096ae66ba9dc96a901fca5 100644 (file)
Binary files a/PerformanceTests/MallocBench/MallocBench/theverge_memory_warning.ops and b/PerformanceTests/MallocBench/MallocBench/theverge_memory_warning.ops differ