Reviewed by Mark Rowe.
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Nov 2007 17:36:54 +0000 (17:36 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Nov 2007 17:36:54 +0000 (17:36 +0000)
        - fix crash when running pixel tests

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dumpRenderTree): Parse the command line options before setting up the
        environment so that we know if we need to set up the pixel dump
        machinery.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm

index b83e7e3fdd7da6742edc0e65bb4548ab28e92eaa..209aa40ae34b1b92fd84c4627ef41f5d0f6f5faf 100644 (file)
@@ -1,3 +1,14 @@
+2007-11-22  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        - fix crash when running pixel tests
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (dumpRenderTree): Parse the command line options before setting up the
+        environment so that we know if we need to set up the pixel dump
+        machinery.
+
 2007-11-21  Eric Seidel  <eric@webkit.org>
 
         Speculative build fix for Tiger.
index 466cbb60c65da75485e9d4d65ba808d8b05d2d3e..e7339204f9b6f867476ff7d7a502ca1f0785de4c 100644 (file)
@@ -383,8 +383,8 @@ static void prepareConsistentTestingEnvironment()
 
 void dumpRenderTree(int argc, const char *argv[])
 {
-    prepareConsistentTestingEnvironment();
     initializeGlobalsFromCommandLineOptions(argc, argv);
+    prepareConsistentTestingEnvironment();
     addTestPluginsToPluginSearchPath(argv[0]);
     installSignalHandlers();