2009-01-15 Aaron Boodman <aa@chromium.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=15279
        Right clicking over text (or multiple spaces) auto selects the word
        (or multiple spaces) under it, which is not a desirable effect for some
        platforms.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::sendContextMenuEvent):
        Don't select words on right-click on Chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index b64e12658933fe878714e1829eeddefc237db240..d0a03cedb0ad85a999da7b7317d6a1daf14decba 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2009-01-15  Aaron Boodman  <aa@chromium.org>
+
+        Reviewed by Adam Roben.
+
+        https://bugs.webkit.org/show_bug.cgi?id=15279
+        Right clicking over text (or multiple spaces) auto selects the word
+        (or multiple spaces) under it, which is not a desirable effect for some
+        platforms.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::sendContextMenuEvent):
+        Don't select words on right-click on Chromium.
+
 2009-01-15  Darin Fisher  <darin@chromium.org>
 
         Reviewed by Eric Seidel.

diff --git a/WebCore/page/EventHandler.cpp b/WebCore/page/EventHandler.cpp
index f004baddbe621b973b99774d0fe4b4e1abfd7d05..d7cd3a177f7d0fdffb5a65517cab1672ab246243 100644 (file)
--- a/WebCore/page/EventHandler.cpp
+++ b/WebCore/page/EventHandler.cpp
@@ -1630,8 +1630,10 @@ bool EventHandler::sendContextMenuEvent(const PlatformMouseEvent& event)
     IntPoint viewportPos = v->windowToContents(event.pos());
     MouseEventWithHitTestResults mev = doc->prepareMouseEvent(HitTestRequest(false, true), viewportPos, event);
 
-    // Context menu events shouldn't select text in GTK+ applications.
-#if !PLATFORM(GTK)
+    // Context menu events shouldn't select text in GTK+ applications or in Chromium.
+    // FIXME: This should probably be configurable by embedders. Consider making it a WebPreferences setting.
+    // See: https://bugs.webkit.org/show_bug.cgi?id=15279
+#if !PLATFORM(GTK) && !PLATFORM(CHROMIUM)
     if (!m_frame->selection()->contains(viewportPos) && 
         // FIXME: In the editable case, word selection sometimes selects content that isn't underneath the mouse.
         // If the selection is non-editable, we do word selection to make it easier to use the contextual menu items