Reviewed by Darin.

        - fixed <rdar://problem/3886042> should save history file as binary XML so serialization,
        parsing, reading and writing is faster

        * History.subproj/WebHistory.m:
        (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]):
        convert dictionary to binary data before saving

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 44e60fb48a60ba8933cf3f044e12c1a7f4ca5a9c..5d956d9ab5fbd64d775544109892d5746f54e42a 100644 (file)
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,14 @@
+2004-11-18  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Darin.
+        
+        - fixed <rdar://problem/3886042> should save history file as binary XML so serialization, 
+        parsing, reading and writing is faster
+
+        * History.subproj/WebHistory.m:
+        (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]):
+        convert dictionary to binary data before saving
+
 2004-11-18  Chris Blumenberg  <cblu@apple.com>
 
         * WebView.subproj/WebHTMLRepresentation.m:

diff --git a/WebKit/History.subproj/WebHistory.m b/WebKit/History.subproj/WebHistory.m
index d311e4efe3c47ac3aa22e11100b4037d73710776..28566e5bcb38a95ca74500a7cf1a80ccc306af88 100644 (file)
--- a/WebKit/History.subproj/WebHistory.m
+++ b/WebKit/History.subproj/WebHistory.m
@@ -478,7 +478,8 @@ NSString *DatesArrayKey = @"WebHistoryDates";
         array, DatesArrayKey,
         [NSNumber numberWithInt:currentFileVersion], FileVersionKey,
         nil];
-    if (![dictionary writeToURL:URL atomically:YES]) {
+    NSData *data = [NSPropertyListSerialization dataFromPropertyList:dictionary format:NSPropertyListBinaryFormat_v1_0 errorDescription:nil];
+    if (![data writeToURL:URL atomically:YES]) {
         ERROR("attempt to save %@ to %@ failed", dictionary, URL);
         return NO;
     }