Web Inspector: Add explanation for Console object expansion behaviour
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jan 2013 12:36:03 +0000 (12:36 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jan 2013 12:36:03 +0000 (12:36 +0000)
https://bugs.webkit.org/show_bug.cgi?id=107793

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-01-25
Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArrayOrObject):
* inspector/front-end/inspector.css:
(.object-info-state-note):
(.object-info-state-note::before):
(.object-info-state-note:hover):
(.section.expanded .object-info-state-note):
(.section.expanded .properties, .event-bar.expanded .event-properties):
(.pane.expanded .properties, .event-bar .event-properties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/English.lproj/localizedStrings.js
Source/WebCore/inspector/front-end/ConsoleMessage.js
Source/WebCore/inspector/front-end/inspector.css

index 49c998720b981fda24ced9f1c5fd12e215b2ab71..63939d6217dc8a0a978d52406841362cdfc0a88e 100644 (file)
@@ -1,3 +1,21 @@
+2013-01-25  Sergey Ryazanov  <serya@chromium.org>
+
+        Web Inspector: Add explanation for Console object expansion behaviour
+        https://bugs.webkit.org/show_bug.cgi?id=107793
+
+        Reviewed by Pavel Feldman.
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/ConsoleMessage.js:
+        (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArrayOrObject):
+        * inspector/front-end/inspector.css:
+        (.object-info-state-note):
+        (.object-info-state-note::before):
+        (.object-info-state-note:hover):
+        (.section.expanded .object-info-state-note):
+        (.section.expanded .properties, .event-bar.expanded .event-properties):
+        (.pane.expanded .properties, .event-bar .event-properties):
+
 2013-01-25  Claudio Saavedra  <csaavedra@igalia.com>
 
         Missing files in GNUmakefile.list.am for Notifications support
index 2bbc422f653888a8c58ab1a26d3eae9c3d237259..6c6bcab0914074b7d928114ef1ba69abd86e99c1 100644 (file)
@@ -847,3 +847,4 @@ localizedStrings["Add file system"] = "Add file system";
 localizedStrings["File systems"] = "File systems";
 localizedStrings["Mappings"] = "Mappings";
 localizedStrings["Add"] = "Add";
+localizedStrings["Object state below is captured upon first expansion"] = "Object state below is captured upon first expansion";
index 001ea804411ce8f4f06382148a568ec7b2ddaec1..7c27ea7f50c0d2f988f162a0b33bf857a463fa63 100644 (file)
@@ -304,6 +304,9 @@ WebInspector.ConsoleMessageImpl.prototype = {
         var section = new WebInspector.ObjectPropertiesSection(obj, titleElement);
         section.enableContextMenu();
         elem.appendChild(section.element);
+
+        var note = section.titleElement.createChild("span", "object-info-state-note");
+        note.title = WebInspector.UIString("Object state below is captured upon first expansion");
     },
 
     /**
index 09f472efe65765d32387cb79c0c07f9421ea5393..457d2fac1efa44b1fc2ccac01bb22501ed9c308b 100644 (file)
@@ -1212,6 +1212,30 @@ ol.watch-expressions > li.hovered {
     font-style: italic;
 }
 
+.object-info-state-note {
+    display: none;
+    width: 12px;
+    height: 12px;
+    background-color: rgb(179, 203, 247);
+    color: white;
+    text-align: center;
+    border-radius: 5px;
+    line-height: 13px;
+    margin: 0 8px;
+}
+
+.object-info-state-note::before {
+    content: "i";
+}
+
+.object-info-state-note:hover {
+    background-color: rgb(52, 115, 231);
+}
+
+.section.expanded .object-info-state-note {
+    display: inline-block;
+}
+
 .error-message {
     color: red;
 }
@@ -1534,6 +1558,9 @@ iframe.panel.extension {
 
 .section.expanded .properties, .event-bar.expanded .event-properties {
     display: block;
+}
+
+.pane.expanded .properties, .event-bar .event-properties {
     padding-left: 16px;
 }