At Least Rougly Glanced At by Anders.
- fix change with totally breaks the layout tests.
Changed all the tests below to avoid dumping more than once -
since this now prints more than one separator, it totally throws
off the layout test driver so it needs to be avoided.
* layout-tests/dom/html/level2/html/HTMLFormElement10-expected.txt:
* layout-tests/dom/html/level2/html/HTMLFormElement10.html:
* layout-tests/dom/html/level2/html/HTMLFormElement10.js:
* layout-tests/fast/events/onunload-expected.txt:
* layout-tests/fast/events/onunload.html:
* layout-tests/fast/js/location-assign-expected.txt:
* layout-tests/fast/js/location-assign.html:
WebKitTools:
At Least Rougly Glanced At by Anders.
- fix change with totally breaks the layout tests.
* DumpRenderTree/DumpRenderTree.m:
(-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Make tests unready if you start another
load, to avoid dumping twice accidentally.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
<TITLE>FORM3</TITLE>
<script type='text/javascript' src='selfhtml.js'></script><script charset='UTF-8' type='text/javascript' src='HTMLFormElement10.js'></script><script type='text/javascript'>function loadComplete() { startTest(); }</script></HEAD>
<BODY onload="loadComplete()">
-<FORM ID="form1" ACTION="about:blank">
+<FORM ID="form1" ACTION="data:text/html,<script>if(window.layoutTestController){layoutTestController.notifyDone();}</script><span style='visibility: hidden'>">
<P>
<TEXTAREA NAME="text1" COLS="20" ROWS="7"></TEXTAREA>
<INPUT TYPE="submit" NAME="submit1" VALUE="Submit" />
nodeList = doc.getElementsByTagName("form");
assertSize("Asize",1,nodeList);
testNode = nodeList.item(0);
+
+ if (window.layoutTestController)
+ layoutTestController.waitUntilDone();
+
testNode.submit();
}
ALERT: unload
-layer at (0,0) size 800x600
- RenderCanvas at (0,0) size 800x600
-layer at (0,0) size 800x34
- RenderBlock {HTML} at (0,0) size 800x34
- RenderBody {BODY} at (8,8) size 784x18
- RenderText {TEXT} at (0,0) size 287x18
- text run at (0,0) width 287: "You should have seen an unload alert appear."
-layer at (0,0) size 800x600
- RenderCanvas at (0,0) size 800x600
-layer at (0,0) size 800x34
- RenderBlock {HTML} at (0,0) size 800x34
- RenderBody {BODY} at (8,8) size 784x18
- RenderText {TEXT} at (0,0) size 287x18
- text run at (0,0) width 287: "You should have seen an unload alert appear."
+You should have seen an unload alert appear.
<html>
<body onunload="unload()" onload="load()">
<script>
-if (window.layoutTestController)
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
layoutTestController.waitUntilDone();
+}
function load()
{
-layer at (0,0) size 800x600
- RenderCanvas at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderCanvas at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderText {TEXT} at (0,0) size 608x18
- text run at (0,0) width 608: "If this text is shown, that means that the document was successfully loaded using location.assign."
- RenderText {TEXT} at (0,0) size 0x0
+If this text is shown, that means that the document was successfully loaded using location.assign.
<html>
<script>
-if (window.layoutTestController)
+if (window.layoutTestController) {
layoutTestController.waitUntilDone();
+ layoutTestController.dumpAsText();
+}
function runTests() {
window.location.assign('resources/new-location.html');
}
</script>
<body onload="runTests();">
+FAIL
</body>
</html>
+2005-08-11 Maciej Stachowiak <mjs@apple.com>
+
+ At Least Rougly Glanced At by Anders.
+
+ - fix change with totally breaks the layout tests.
+
+ Changed all the tests below to avoid dumping more than once -
+ since this now prints more than one separator, it totally throws
+ off the layout test driver so it needs to be avoided.
+
+ * layout-tests/dom/html/level2/html/HTMLFormElement10-expected.txt:
+ * layout-tests/dom/html/level2/html/HTMLFormElement10.html:
+ * layout-tests/dom/html/level2/html/HTMLFormElement10.js:
+ * layout-tests/fast/events/onunload-expected.txt:
+ * layout-tests/fast/events/onunload.html:
+ * layout-tests/fast/js/location-assign-expected.txt:
+ * layout-tests/fast/js/location-assign.html:
+
2005-08-10 Geoffrey Garen <ggaren@apple.com>
-added layout test for fix to <rdar://problem/4151132> REGRESSION: Some applet
+2005-08-11 Maciej Stachowiak <mjs@apple.com>
+
+ At Least Rougly Glanced At by Anders.
+
+ - fix change with totally breaks the layout tests.
+
+ * DumpRenderTree/DumpRenderTree.m:
+ (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Make tests unready if you start another
+ load, to avoid dumping twice accidentally.
+
2005-08-10 Eric Seidel <eseidel@apple.com>
Fixed made by Mitz Pettel <opendarwin.org@mitzpettel.com>
}
}
+- (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)f
+{
+ if (frame == f)
+ readyToDump = NO;
+}
+
- (void)webView:(WebView *)sender didFailProvisionalLoadWithError:(NSError *)error forFrame:(WebFrame *)frame
{
[self webView:sender locationChangeDone:error forDataSource:[frame provisionalDataSource]];
git://git.webkit.org / WebKit-https.git / commitdiff