REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Feb 2013 13:37:27 +0000 (13:37 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Feb 2013 13:37:27 +0000 (13:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=110844

Patch by Sergio Villar Senin <svillar@igalia.com> on 2013-02-26
Reviewed by Alexey Proskuryakov.

Clean up cookies at the beginning and after finishing the test in
order not to break other tests behavior.

* http/tests/cookies/resources/set-cookie-on-redirect.php: clear cookie before returning.
* http/tests/cookies/set-cookie-on-redirect.html: clear all cookies before starting the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/cookies/resources/set-cookie-on-redirect.php
LayoutTests/http/tests/cookies/set-cookie-on-redirect.html

index a8b2a73..169c02c 100644 (file)
@@ -1,3 +1,16 @@
+2013-02-26  Sergio Villar Senin  <svillar@igalia.com>
+
+        REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests
+        https://bugs.webkit.org/show_bug.cgi?id=110844
+
+        Reviewed by Alexey Proskuryakov.
+
+        Clean up cookies at the beginning and after finishing the test in
+        order not to break other tests behavior.
+
+        * http/tests/cookies/resources/set-cookie-on-redirect.php: clear cookie before returning.
+        * http/tests/cookies/set-cookie-on-redirect.html: clear all cookies before starting the test.
+
 2013-02-26  Andrey Kosyakov  <caseq@chromium.org>
 
         Web Inspector: show deferred paints on Timeline
index 26d04e3..c8d30ce 100644 (file)
@@ -9,6 +9,9 @@ if ($_GET['step'] == 1) {
 } else if ($_GET['step'] == 3) {
   header("HTTP/1.0 200 OK");
   if (isset($_COOKIE['test_cookie'])) {
+    /* Clear cookie in order not to affect other tests. */
+    setcookie("test_cookie", "", time() - 1);
+
     echo "PASSED: Cookie successfully set\n";
   } else {
     echo "FAILED: Cookie not set\n";
index 3827d23..75df7bf 100644 (file)
@@ -1,11 +1,12 @@
 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
 <html>
-
+<script src="resources/cookies-test-pre.js"></script>
 <script>
 if (window.testRunner) {
     testRunner.dumpAsText();
     testRunner.waitUntilDone();
 }
+clearAllCookies();
 
 function doRedirect()
 {