Reviewed by Adam Roben.
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 24 Nov 2007 04:48:07 +0000 (04:48 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 24 Nov 2007 04:48:07 +0000 (04:48 +0000)
        Bug 16110: Clicking inside the resource headers in the network timeline collapses them
        http://bugs.webkit.org/show_bug.cgi?id=16110

        Toggle the resource headers only if the click happens on the
        resource row, not within the headers area.

        * WebCore.xcodeproj/project.pbxproj:
        * page/inspector/NetworkPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/page/inspector/NetworkPanel.js

index b9ac82f621912b64ffda45337be8bedd36129157..7ebf74af8d4235af5d14ecfdee1ee0224e5ed1d6 100644 (file)
@@ -1,3 +1,16 @@
+2007-11-23  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Bug 16110: Clicking inside the resource headers in the network timeline collapses them
+        http://bugs.webkit.org/show_bug.cgi?id=16110
+
+        Toggle the resource headers only if the click happens on the
+        resource row, not within the headers area.
+
+        * WebCore.xcodeproj/project.pbxproj:
+        * page/inspector/NetworkPanel.js:
+
 2007-11-23  Kevin Ollivier  <kevino@theolliviers.com>
 
         Win build fixes. CURL needs winsock, so don't disable it, and
index 6a6984301ff6d67aa886d38b046808c70a588c4c..21eaa41e91e23d3ea4fd463289c8feed4514f048 100644 (file)
@@ -114,13 +114,20 @@ WebInspector.NetworkPanel.prototype = {
 
     onClick: function(event)
     {
+        // If the click wasn't inside a network resource row, ignore it.
         var resourceElement = event.target.firstParentOrSelfWithClass("network-resource");
         if (!resourceElement)
             return;
 
+        // If the click was within the network info element, ignore it.
+        var networkInfo = event.target.firstParentOrSelfWithClass("network-info");
+        if (networkInfo)
+            return;
+
+        // If the click was within the tip balloon element, hide it.
         var balloon = event.target.firstParentOrSelfWithClass("tip-balloon");
         if (balloon) {
-            resourceElement.timelineEntry.toggleTipBalloon(event);
+            resourceElement.timelineEntry.showingTipBalloon = false;
             return;
         }