Move implementation of AuthenticationChallenge::setAuthenticationClient() to source...
authorddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 12 Jan 2014 20:06:18 +0000 (20:06 +0000)
committerddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 12 Jan 2014 20:06:18 +0000 (20:06 +0000)
<http://webkit.org/b/126848>

Reviewed by Simon Fraser.

* platform/network/cf/AuthenticationCF.cpp:
(WebCore::AuthenticationChallenge::setAuthenticationClient):
Move implementation to here...
* platform/network/cf/AuthenticationChallenge.h: ...from here.
Remove duplicate header definitions inside USE(CFNETWORK).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/network/cf/AuthenticationCF.cpp
Source/WebCore/platform/network/cf/AuthenticationChallenge.h

index 7ea1effb8a7c30ab3ce19ad7ce200354af3a8b81..a920a07ee03ac867b6585b730633dc94c694798f 100644 (file)
@@ -1,3 +1,16 @@
+2014-01-12  David Kilzer  <ddkilzer@apple.com>
+
+        Move implementation of AuthenticationChallenge::setAuthenticationClient() to source file for USE(CFNETWORK)
+        <http://webkit.org/b/126848>
+
+        Reviewed by Simon Fraser.
+
+        * platform/network/cf/AuthenticationCF.cpp:
+        (WebCore::AuthenticationChallenge::setAuthenticationClient):
+        Move implementation to here...
+        * platform/network/cf/AuthenticationChallenge.h: ...from here.
+        Remove duplicate header definitions inside USE(CFNETWORK).
+
 2014-01-12  Sam Weinig  <sam@webkit.org>
 
         Fix windows.
index 0300a40afb8048e3ba1706a016134ca54f8f6a76..89bc37fb21aa6029e921e84c18bdb2877d042fae 100644 (file)
@@ -68,6 +68,11 @@ AuthenticationChallenge::AuthenticationChallenge(CFURLAuthChallengeRef cfChallen
 {
 }
 
+void AuthenticationChallenge::setAuthenticationClient(AuthenticationClient* client)
+{
+    m_authenticationClient = client;
+}
+
 AuthenticationClient* AuthenticationChallenge::authenticationClient() const
 {
     return m_authenticationClient.get();
index 7209ac7599df196ded092499c21c76d12af9bf09..15f4ef3b8c5c74520a5d1d2e201ff682fbefd070 100644 (file)
@@ -53,19 +53,16 @@ public:
 #if USE(CFNETWORK)
     AuthenticationChallenge(CFURLAuthChallengeRef, AuthenticationClient*);
 
-    AuthenticationClient* authenticationClient() const;
-    void setAuthenticationClient(AuthenticationClient* client) { m_authenticationClient = client; }
-
     CFURLAuthChallengeRef cfURLAuthChallengeRef() const { return m_cfChallenge.get(); }
 #else
     AuthenticationChallenge(NSURLAuthenticationChallenge *);
 
     id sender() const { return m_sender.get(); }
     NSURLAuthenticationChallenge *nsURLAuthenticationChallenge() const { return m_nsChallenge.get(); }
+#endif
 
     void setAuthenticationClient(AuthenticationClient*); // Changes sender to one that invokes client methods.
     AuthenticationClient* authenticationClient() const;
-#endif
 
 private:
     friend class AuthenticationChallengeBase;