fixed by Darin, reviewed by me.

        <rdar://problem/3976314> REGRESSION (180-TOT): submitting password fields fail on Panther

        * kwq/KWQTextField.mm: (-[KWQTextFieldController string]): on panther, the secure text field's editor
        does not contain the real string, so now we just call stringValue on the field in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 7fe092f7d02fce7430b40e01fdf8521e6eda113f..840cabafd278def6ac64a7952e80f1af822f8a54 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,12 @@
+2005-01-27  Adele Amchan  <adele@apple.com>
+
+        fixed by Darin, reviewed by me.
+
+        <rdar://problem/3976314> REGRESSION (180-TOT): submitting password fields fail on Panther
+
+        * kwq/KWQTextField.mm: (-[KWQTextFieldController string]): on panther, the secure text field's editor 
+        does not contain the real string, so now we just call stringValue on the field in that case.
+
 2005-01-26  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Darin, Hyatt and Ken.

diff --git a/WebCore/kwq/KWQTextField.mm b/WebCore/kwq/KWQTextField.mm
index 7816db5de67a955d43826622bed166b54d833974..d2cc917e439c0074534a42566a6487924e807803 100644 (file)
--- a/WebCore/kwq/KWQTextField.mm
+++ b/WebCore/kwq/KWQTextField.mm
@@ -427,6 +427,15 @@
 
 - (NSString *)string
 {
+#if BUILDING_ON_PANTHER
+    // On Panther, the secure text field's editor does not contain the real
+    // string, so we must always call stringValue on the field. We'll live
+    // with the side effect of ending International inline input for these
+    // password fields on Panther only, since it's fixed in Tiger.
+    if ([field isKindOfClass:[NSSecureTextField class]]) {
+           return [field stringValue];
+    }
+#endif
     // Calling stringValue can have a side effect of ending International inline input.
     // So don't call it unless there's no editor.
     NSText *editor = [field _KWQ_currentEditor];