- http://bugzilla.opendarwin.org/show_bug.cgi?id=8991
REGRESSION: missing or broken CSS custom cursors are displayed as
a missing image icon
* page/FrameView.cpp:
(WebCore::selectCursor): Fallback to CURSOR_AUTO if the image is an error image.
* manual-tests/custom-cursors.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2006-05-20 Alexey Proskuryakov <ap@nypop.com>
+
+ Reviewed by Darin.
+
+ - http://bugzilla.opendarwin.org/show_bug.cgi?id=8991
+ REGRESSION: missing or broken CSS custom cursors are displayed as
+ a missing image icon
+
+ * page/FrameView.cpp:
+ (WebCore::selectCursor): Fallback to CURSOR_AUTO if the image is an error image.
+ * manual-tests/custom-cursors.html: Added.
+
2006-05-20 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed and landed by ap.
--- /dev/null
+<a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=8991">Bug 8991</a>: REGRESSION: missing or broken CSS custom cursors are displayed as a missing image icon.<p>
+Move the cursor over the blue box - it should not turn into a missing image icon, and should turn into an I-beam over text.
+
+<div style="width:100px;height:50px;background-color:lightblue; cursor:url(nonexistent.png), auto;"><span style="cursor:url(nonexistent.png), auto;">some text</span></div>
+<div style="width:100px;height:50px;background-color:lightblue; cursor:url(nonexistent.png);"></div>
RenderStyle* style = renderer ? renderer->style() : 0;
if (style && style->cursorImage() && !style->cursorImage()->image()->isNull())
- return style->cursorImage()->image();
+ if (!style->cursorImage()->isErrorImage())
+ return style->cursorImage()->image();
+ else
+ style = 0; // Fallback to CURSOR_AUTO
switch (style ? style->cursor() : CURSOR_AUTO) {
case CURSOR_AUTO: {