Reviewed by Vicki.

        - fixed <rdar://problem/4023360> REGRESSION (186-187): image file upload is broken at pep.apple.com

        * khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::appendFormData): Return true after
        setting up the form data for an uploaded file. The old code would fall through to the ISINDEX
        case and send double form data (the filename instead of the file contents the second time).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index fd7e494b4dd65d06dbb8e41d39d90962b61744b4..079cadab970f20b9e78cf771fe0daef63a9c58bd 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,13 @@
+2005-02-24  Darin Adler  <darin@apple.com>
+
+        Reviewed by Vicki.
+
+        - fixed <rdar://problem/4023360> REGRESSION (186-187): image file upload is broken at pep.apple.com
+
+        * khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::appendFormData): Return true after
+        setting up the form data for an uploaded file. The old code would fall through to the ISINDEX
+        case and send double form data (the filename instead of the file contents the second time).
+
 2005-02-24  David Harrison  <harrison@apple.com>
 
         Reviewed by Ken.

diff --git a/WebCore/khtml/html/html_formimpl.cpp b/WebCore/khtml/html/html_formimpl.cpp
index a02c95f5672fc3fc85c0192b0325620724b214b5..fc7f0564d217c682ee71ccbb844d5dcd4b0e90f0 100644 (file)
--- a/WebCore/khtml/html/html_formimpl.cpp
+++ b/WebCore/khtml/html/html_formimpl.cpp
@@ -1839,6 +1839,7 @@ bool HTMLInputElementImpl::appendFormData(FormDataList &encoding, bool multipart
 
 #if APPLE_CHANGES
             encoding.appendFile(name(), value());
+            return true;
 #else
             KURL fileurl("file:///");
             fileurl.setPath(value().string());