2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Remove unnecessary domain and success flags from the response messages.
        https://bugs.webkit.org/show_bug.cgi?id=55768

        We have domain property in the response messages but it is not used because we dispatch
        the responses on the callback associated with seq.

        If we have property 'errors' in the response then success eq false and true in the other case.

        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/report-protocol-errors-expected.txt:
2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Remove unnecessary domain and success flags from the response messages.
        https://bugs.webkit.org/show_bug.cgi?id=55768

        We have domain property in the response messages but it is not used because we dispatch
        the responses on the callback associated with seq.

        If we have property 'errors' in the response then success eq false and true in the other case.

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 99eea221fad44c307088e138c43ff877e34086b5..4f448b40a54425f641ee808371d5c1d48e30d709 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,18 @@
+2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: Remove unnecessary domain and success flags from the response messages.
+        https://bugs.webkit.org/show_bug.cgi?id=55768
+
+        We have domain property in the response messages but it is not used because we dispatch
+        the responses on the callback associated with seq.
+
+        If we have property 'errors' in the response then success eq false and true in the other case.
+
+        * inspector/protocol/runtime-agent-expected.txt:
+        * inspector/report-protocol-errors-expected.txt:
+
 2011-03-04  Csaba Osztrogonác  <ossy@webkit.org>
 
         Unreviewed.

diff --git a/LayoutTests/inspector/protocol/runtime-agent-expected.txt b/LayoutTests/inspector/protocol/runtime-agent-expected.txt
index b8b66ce8969dacda69af81d3f1f9e909114f94a7..3e546509f00bcbef8206222b1f992cd1f3b48fe1 100644 (file)
--- a/LayoutTests/inspector/protocol/runtime-agent-expected.txt
+++ b/LayoutTests/inspector/protocol/runtime-agent-expected.txt
@@ -18,8 +18,6 @@ request:
 response:
 {
     seq : <number>
-    domain : "Runtime"
-    success : true
     body : {
         result : {
             objectId : {
@@ -55,8 +53,6 @@ request:
 response:
 {
     seq : <number>
-    domain : "Runtime"
-    success : true
     body : {
         result : {
             objectId : null
@@ -89,8 +85,6 @@ request:
 response:
 {
     seq : <number>
-    domain : "Runtime"
-    success : true
     body : {
         result : true
     }
@@ -118,8 +112,6 @@ request:
 response:
 {
     seq : <number>
-    domain : "Runtime"
-    success : true
     body : {
         result : true
     }
@@ -147,8 +139,6 @@ request:
 response:
 {
     seq : <number>
-    domain : "Runtime"
-    success : true
     body : {
         result : {
             0 : {
@@ -206,8 +196,6 @@ request:
 response:
 {
     seq : <number>
-    domain : "Runtime"
-    success : true
 }
 
 -----------------------------------------------------------
@@ -227,8 +215,6 @@ request:
 response:
 {
     seq : <number>
-    domain : "Runtime"
-    success : true
 }
 
 ===========================================================

diff --git a/LayoutTests/inspector/report-protocol-errors-expected.txt b/LayoutTests/inspector/report-protocol-errors-expected.txt
index d96f06b00bb4888bbb12ba10eb7d532152ce811c..053d54f9b9822fd02fad53a1358a9904b53b6b50 100644 (file)
--- a/LayoutTests/inspector/report-protocol-errors-expected.txt
+++ b/LayoutTests/inspector/report-protocol-errors-expected.txt
@@ -2,66 +2,54 @@ Tests that InspectorBackendDispatcher is catching incorrect messages.
 
 {
     seq : 0
-    success : false
     errors : {
         0 : "Protocol Error: Invalid message format. Message should be in JSON format."
     }
 }
 {
     seq : 0
-    success : false
     errors : {
         0 : "Protocol Error: Invalid message format. 'command' property wasn't found."
     }
 }
 {
     seq : 0
-    success : false
     errors : {
         0 : "Protocol Error: Invalid message format. The type of 'command' property should be string."
     }
 }
 {
     seq : 0
-    success : false
     errors : {
         0 : "Protocol Error: Invalid message format. 'seq' property was not found in the request."
     }
 }
 {
     seq : 0
-    success : false
     errors : {
         0 : "Protocol Error: Invalid message format. The type of 'seq' property should be number."
     }
 }
 {
     seq : 1
-    success : false
     errors : {
         0 : "Protocol Error: Invalid command was received. 'test' wasn't found in domain DOM."
     }
 }
 {
     seq : 2
-    domain : "Network"
-    success : false
     errors : {
         0 : "Protocol Error: 'arguments' property with type 'object' was not found."
     }
 }
 {
     seq : 3
-    domain : "Network"
-    success : false
     errors : {
         0 : "Protocol Error: 'arguments' property with type 'object' was not found."
     }
 }
 {
     seq : 4
-    domain : "Network"
-    success : false
     errors : {
         0 : "Protocol Error: Argument 'frameId' with type 'Number' was not found."
         1 : "Protocol Error: Argument 'url' with type 'String' was not found."
@@ -70,8 +58,6 @@ Tests that InspectorBackendDispatcher is catching incorrect messages.
 }
 {
     seq : 5
-    domain : "Network"
-    success : false
     errors : {
         0 : "Protocol Error: Argument 'frameId' with type 'Number' was not found."
         1 : "Protocol Error: Argument 'url' with type 'String' was not found."

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index cf232acbcaaa4056bbb4ae5c9269774d330b0218..2ac4feb8485ab7ce1daca8bbc1d5d20ef3808472 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: Remove unnecessary domain and success flags from the response messages.
+        https://bugs.webkit.org/show_bug.cgi?id=55768
+
+        We have domain property in the response messages but it is not used because we dispatch
+        the responses on the callback associated with seq.
+
+        If we have property 'errors' in the response then success eq false and true in the other case.
+
+        * inspector/CodeGeneratorInspector.pm:
+
 2011-03-04  Christian Dywan  <christian@lanedo.com>
 
         Reviewed by Gustavo Noronha Silva.

diff --git a/Source/WebCore/inspector/CodeGeneratorInspector.pm b/Source/WebCore/inspector/CodeGeneratorInspector.pm
index 2a407b9b55c1f686b217a60ed45e639552e02eba..df873d9bece74ba5d3714fe2f0032700b0a4cbd9 100644 (file)
--- a/Source/WebCore/inspector/CodeGeneratorInspector.pm
+++ b/Source/WebCore/inspector/CodeGeneratorInspector.pm
@@ -513,8 +513,6 @@ sub generateBackendFunction
     push(@function, "    if ((callId || protocolErrors->length()) && m_inspectorAgent->hasFrontend()) {");
     push(@function, "        RefPtr<InspectorObject> responseMessage = InspectorObject::create();");
     push(@function, "        responseMessage->setNumber(\"seq\", callId);");
-    push(@function, "        responseMessage->setString(\"domain\", \"$domain\");");
-    push(@function, "        responseMessage->setBoolean(\"success\", !protocolErrors->length());");
     push(@function, "");
     push(@function, "        if (protocolErrors->length())");
     push(@function, "            responseMessage->setArray(\"errors\", protocolErrors);");
@@ -600,7 +598,6 @@ void ${backendClassName}::reportProtocolError(const long callId, const String& e
 {
     RefPtr<InspectorObject> message = InspectorObject::create();
     message->setNumber("seq", callId);
-    message->setBoolean("success", false);
     RefPtr<InspectorArray> errors = InspectorArray::create();
     errors->pushString(errorText);
     message->setArray("errors", errors);
@@ -848,7 +845,7 @@ InspectorBackendStub.prototype = {
                 arguments.push(messageObject.body[key]);
 
         if ("seq" in messageObject) { // just a response for some request
-            if (messageObject.success)
+            if (!messageObject.errors)
                 this._callbacks[messageObject.seq].apply(null, arguments);
             else
                 this.reportProtocolError(messageObject);