ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator
authoryouenn.fablet@crf.canon.fr <youenn.fablet@crf.canon.fr@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Mar 2015 11:36:14 +0000 (11:36 +0000)
committeryouenn.fablet@crf.canon.fr <youenn.fablet@crf.canon.fr@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Mar 2015 11:36:14 +0000 (11:36 +0000)
https://bugs.webkit.org/show_bug.cgi?id=142397

Reviewed by Benjamin Poulain.

No behavior change. Current tests cover the changes.

* bindings/js/ReadableStreamJSSource.cpp:
* bindings/js/ReadableStreamJSSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/js/ReadableStreamJSSource.cpp
Source/WebCore/bindings/js/ReadableStreamJSSource.h

index 4a006033c30bd3dc5323ec0bdcc186d9831e9cd6..275304a77a5a808106c86fa94558d7bae649014a 100644 (file)
@@ -1,3 +1,15 @@
+2015-03-09  Xabier Rodriguez Calvar <calvaris@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator
+        https://bugs.webkit.org/show_bug.cgi?id=142397
+
+        Reviewed by Benjamin Poulain.
+
+        No behavior change. Current tests cover the changes.
+
+        * bindings/js/ReadableStreamJSSource.cpp:
+        * bindings/js/ReadableStreamJSSource.h:
+
 2015-03-09  Xabier Rodriguez Calvar  <calvaris@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
 
         ReadableStream does not not need to pass itself as callback parameter
index b81aacd5008b574482d9ec163a7a370aed7cd7d7..3c33655152dbf22954fa497e41808e3fe3fe3500 100644 (file)
@@ -67,7 +67,6 @@ Ref<ReadableStreamJSSource> ReadableStreamJSSource::create(JSC::ExecState* exec)
 }
 
 ReadableStreamJSSource::ReadableStreamJSSource(JSC::ExecState* exec)
-    : m_error(exec->vm(), jsUndefined())
 {
     if (!exec->argumentCount())
         return;
index 4463461266a6def233855600c2f787a2830a2076..17e585d69567a7c7019526c8ae6456664d72df9b 100644 (file)
@@ -52,7 +52,7 @@ public:
     bool start() { return true; }
 
     // ReadableStreamSource API.
-    virtual bool isErrored() { return !m_error.get().isUndefined(); }
+    virtual bool isErrored() { return !!m_error; }
 
 private:
     void setInternalError(JSC::ExecState*, const String&);