Two action menu item titles are swapped
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Nov 2014 21:55:18 +0000 (21:55 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Nov 2014 21:55:18 +0000 (21:55 +0000)
https://bugs.webkit.org/show_bug.cgi?id=138667
<rdar://problem/18960409>

Reviewed by Beth Dakin.

* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _createActionMenuItemForTag:]):
Swap them back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/mac/WKActionMenuController.mm

index 68510d6f3d62f72a0990ea71fab12422a2ec7936..93e43477e7a741509306db25145d86c85f9cf9c2 100644 (file)
@@ -1,3 +1,15 @@
+2014-11-12  Tim Horton  <timothy_horton@apple.com>
+
+        Two action menu item titles are swapped
+        https://bugs.webkit.org/show_bug.cgi?id=138667
+        <rdar://problem/18960409>
+
+        Reviewed by Beth Dakin.
+
+        * UIProcess/mac/WKActionMenuController.mm:
+        (-[WKActionMenuController _createActionMenuItemForTag:]):
+        Swap them back.
+
 2014-11-12  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r175806.
index fa917b80bc9ea7b0210dbb57d8979b614a2b8663..c69edd6ef6025b6dbe4b3b84f5fbf95a7559d6af 100644 (file)
@@ -850,12 +850,12 @@ static NSString *pathToPhotoOnDisk(NSString *suggestedFilename)
 
     case kWKContextActionItemTagSaveVideoToDownloads:
         selector = @selector(_saveVideoToDownloads:);
-        title = WEB_UI_STRING_KEY("Share", "Share (video action menu item)", "video action menu item");
+        title = WEB_UI_STRING_KEY("Save to Downloads", "Save to Downloads (video action menu item)", "video action menu item");
         image = [NSImage imageNamed:@"NSActionMenuSaveToDownloads"];
         break;
 
     case kWKContextActionItemTagShareVideo:
-        title = WEB_UI_STRING_KEY("Save to Downloads", "Save to Downloads (video action menu item)", "video action menu item");
+        title = WEB_UI_STRING_KEY("Share", "Share (video action menu item)", "video action menu item");
         image = [NSImage imageNamed:@"NSActionMenuShare"];
         break;