2011-06-29 Leandro Pereira <leandro@profusion.mobi>

        Reviewed by Darin Adler.

        Add note about cases where enums are preferred over bools on function parameters.
        https://bugs.webkit.org/show_bug.cgi?id=63564

        This matches the outcome of this webkit-dev thread:
        https://lists.webkit.org/pipermail/webkit-dev/2010-December/015192.html

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/webkit.org/ChangeLog b/Websites/webkit.org/ChangeLog
index 73c8cfbf3bad51b6fe090efd4d1a53b6f853a99f..b837bb45b8eb89575211287c6949c242447b077f 100644 (file)
--- a/Websites/webkit.org/ChangeLog
+++ b/Websites/webkit.org/ChangeLog
@@ -1,3 +1,15 @@
+2011-06-29  Leandro Pereira  <leandro@profusion.mobi>
+
+        Reviewed by Darin Adler.
+
+        Add note about cases where enums are preferred over bools on function parameters.
+        https://bugs.webkit.org/show_bug.cgi?id=63564
+
+        This matches the outcome of this webkit-dev thread:
+        https://lists.webkit.org/pipermail/webkit-dev/2010-December/015192.html
+
+        * coding/coding-style.html:
+
 2011-05-31  Chris Evans  <cevans@chromium.org>
 
         Reviewed by Drew Yao.

diff --git a/Websites/webkit.org/coding/coding-style.html b/Websites/webkit.org/coding/coding-style.html
index 307cfddd4300a955608389da7c30a7c81e24e591..4197c7861d65d4adc45ff410a3486c2cb6e56d61 100644 (file)
--- a/Websites/webkit.org/coding/coding-style.html
+++ b/Websites/webkit.org/coding/coding-style.html
@@ -603,6 +603,24 @@ void doSomething(ScriptExecutionContext* context);
 </pre>
 </li>
 
+<li>Prefer enums to bools on function parameters if callers are likely to be
+passing constants, since named constants are easier to read at the call
+site.  An exception to this rule is a setter function, where the name of the
+function already makes clear what the boolean is.
+<h4 class="right">Right:</h4>
+<pre class="code">
+doSomething(something, AllowFooBar);
+paintTextWithShadows(context, ..., textStrokeWidth > 0, isHorizontal());
+setResizable(false);
+</pre>
+
+<h4 class="wrong">Wrong:</h4>
+<pre class="code">
+doSomething(something, false);
+setResizable(NotResizable);
+</pre>
+</li>
+
 <li>Objective-C method names should follow the Cocoa naming guidelines &mdash;
 they should read like a phrase and each piece of the selector should 
 start with a lowercase letter and use intercaps.</li>