- Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10580
Password: New secure text field allows non-Roman text entry
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::setSecureKeyboardEntry): Enable and disable Roman keyboards when switching in and out of this mode.
(WebCore::FrameMac::isSecureKeyboardEntry): Changed secureKeyboardEntry to isSecureKeyboardEntry.
* bridge/mac/FrameMac.h: ditto.
* page/Frame.cpp: (WebCore::Frame::setIsActive): ditto.
* page/Frame.h: (WebCore::Frame::isSecureKeyboardEntry): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2006-09-01 Adele Peterson <adele@apple.com>
+
+ Reviewed by John.
+
+ - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10580
+ Password: New secure text field allows non-Roman text entry
+
+ * bridge/mac/FrameMac.mm:
+ (WebCore::FrameMac::setSecureKeyboardEntry): Enable and disable Roman keyboards when switching in and out of this mode.
+ (WebCore::FrameMac::isSecureKeyboardEntry): Changed secureKeyboardEntry to isSecureKeyboardEntry.
+ * bridge/mac/FrameMac.h: ditto.
+ * page/Frame.cpp: (WebCore::Frame::setIsActive): ditto.
+ * page/Frame.h: (WebCore::Frame::isSecureKeyboardEntry): ditto.
+
2006-09-01 Adele Peterson <adele@apple.com>
Reviewed by John.
Password: Disable smartReplace for new password fields
* editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- Don't smart replace when the selection being replaces is in a password field.
+ Don't smart replace when the selection being replaced is in a password field.
2006-08-31 Sam Weinig <sam.weinig@gmail.com>
virtual bool inputManagerHasMarkedText() const;
virtual void setSecureKeyboardEntry(bool);
- virtual bool secureKeyboardEntry();
+ virtual bool isSecureKeyboardEntry();
KJS::Bindings::RootObject* executionContextForDOM();
KJS::Bindings::RootObject* bindingRootObject();
return false;
}
+const short enableRomanKeyboardsOnly = -23;
void FrameMac::setSecureKeyboardEntry(bool enable)
{
- if (enable)
+ if (enable) {
EnableSecureEventInput();
- else
+ KeyScript(enableRomanKeyboardsOnly);
+ } else {
DisableSecureEventInput();
+ KeyScript(smKeyEnableKybds);
+ }
}
-bool FrameMac::secureKeyboardEntry()
+bool FrameMac::isSecureKeyboardEntry()
{
return IsSecureEventInputEnabled();
}
}
// 5. Enable or disable secure keyboard entry
- if ((flag && !secureKeyboardEntry() && doc && doc->focusNode() && doc->focusNode()->hasTagName(inputTag) &&
+ if ((flag && !isSecureKeyboardEntry() && doc && doc->focusNode() && doc->focusNode()->hasTagName(inputTag) &&
static_cast<HTMLInputElement*>(doc->focusNode())->inputType() == HTMLInputElement::PASSWORD) ||
- (!flag && secureKeyboardEntry()))
+ (!flag && isSecureKeyboardEntry()))
setSecureKeyboardEntry(flag);
}
virtual bool inputManagerHasMarkedText() const { return false; }
virtual void setSecureKeyboardEntry(bool) {};
- virtual bool secureKeyboardEntry() { return false; }
+ virtual bool isSecureKeyboardEntry() { return false; }
bool isSelectionInPasswordField();