Reviewed by Ojan Vafai. Bugzilla JavaScript changes by Adam Barth.

        Bugzilla autocomplete should support frequent contributors who are not committers
        https://bugs.webkit.org/show_bug.cgi?id=59209

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/Scripts/webkitpy/common/config/committers.py b/Tools/Scripts/webkitpy/common/config/committers.py
index 9f48588619322ba1539548dc6c095631162b71aa..5178b6bd21dd3a5f997f8d332e3dd0b63dcda0de 100644 (file)
--- a/Tools/Scripts/webkitpy/common/config/committers.py
+++ b/Tools/Scripts/webkitpy/common/config/committers.py
@@ -1,3 +1,4 @@
+# Copyright (c) 2011, Apple Inc. All rights reserved.
 # Copyright (c) 2009, Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -29,6 +30,11 @@
 # WebKit's Python module for committer and reviewer validation
 
 
+class Contributor:
+
+    def __init__(self, name, email_or_emails, irc_nickname=None):
+        return
+
 class Committer:
 
     def __init__(self, name, email_or_emails, irc_nickname=None):
@@ -56,6 +62,17 @@ class Reviewer(Committer):
         self.can_review = True
 
 
+# This is a list of people who are neither committers nor reviewers, but get
+# frequently CC'ed by others on Bugzilla bugs, so their names should be
+# supported by autocomplete. No review needed to add to the list.
+
+
+contributors_who_are_not_committers = [
+    Contributor("Anne van Kesteren", "annevankesteren+webkit@gmail.com", "annevk"),
+    Contributor("Ian Hickson", "ian@hixie.ch", "hixie"),
+]
+
+
 # This is intended as a canonical, machine-readable list of all non-reviewer
 # committers for WebKit.  If your name is missing here and you are a committer,
 # please add it.  No review needed.  All reviewers are committers, so this list

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 45d8b55ffc4720aee11412fa3977340221c13d70..38dec04a698c3913eb23c0f39039396a9ccd40d6 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,12 @@
+2011-04-22  Alexey Proskuryakov  <ap@apple.com>
+
+        Code changes by Adam Barth. Reviewed by Ojan Vafai.
+
+        Bugzilla autocomplete should support frequent contributors who are not committers
+        https://bugs.webkit.org/show_bug.cgi?id=59209
+
+        * committers-autocomplete.js: Support Contributor role in committers.py.
+
 2011-04-19  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 
         Reviewed by Adam Roben.

diff --git a/Websites/bugs.webkit.org/committers-autocomplete.js b/Websites/bugs.webkit.org/committers-autocomplete.js
index 8d071aab666c2d57852b1f2a164f4bac79897013..28ebccb59cc99fa0bd7f9bc4ba2e2b6c26997b9d 100644 (file)
--- a/Websites/bugs.webkit.org/committers-autocomplete.js
+++ b/Websites/bugs.webkit.org/committers-autocomplete.js
@@ -127,6 +127,7 @@ WebKitCommitters = (function() {
         var records = text.split('\n');
         parseType('Committer', records, 'c');
         parseType('Reviewer', records, 'r');
+        parseType('Contributor', records);
     }
 
     function loadCommitters(callback) {
@@ -246,7 +247,8 @@ WebKitCommitters = (function() {
                 contact.emails[0] + '>' + contact.name + ' - ' + contact.emails[0]);
             if (contact.irc)
                 html.push(' (:' + contact.irc + ')');
-            html.push(' (' + contact.type + ')');
+            if (contact.type)
+                html.push(' (' + contact.type + ')');
             html.push('</div>');
         }
         getMenu().innerHTML = html.join('');