Fixed <rdar://problem/4026985> CrashTracer: ...14 crashes at com.apple.WebCore:...
authorrjw <rjw@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Feb 2005 23:10:43 +0000 (23:10 +0000)
committerrjw <rjw@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Feb 2005 23:10:43 +0000 (23:10 +0000)
Added more nil checking and ASSERTS.
Without a reproducible case this is hard to definitively resolve.

        Reviewed by John Sullivan.

        * kwq/KWQPageState.mm:
        (-[KWQPageState invalidate]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/kwq/KWQPageState.mm

index b15840e990d8a49e743ff6a04594ff2013956387..f5ed3a2f0efea968742b2ddd24148ee8e962506b 100644 (file)
@@ -1,3 +1,15 @@
+2005-02-28  Richard Williamson   <rjw@apple.com>
+
+       Fixed <rdar://problem/4026985> CrashTracer: ...14 crashes at com.apple.WebCore: -[KWQPageState invalidate] + 32
+
+       Added more nil checking and ASSERTS.
+       Without a reproducible case this is hard to definitively resolve.
+
+        Reviewed by John Sullivan.
+
+        * kwq/KWQPageState.mm:
+        (-[KWQPageState invalidate]):
+
 2005-02-28  Richard Williamson   <rjw@apple.com>
 
        Fixed <rdar://problem/4027702> 3.5% performance regression btwn Safari-188 and Safari-400
index ea7b72144205b267ce65e1609eb80ea43b1b0ba0..85827472b802138cdcdb27c7ec66db15977bed18 100644 (file)
@@ -106,11 +106,14 @@ using KJS::SavedBuiltins;
 {
     // Should only ever invalidate once.
     ASSERT(document);
+    ASSERT(document->view());
     ASSERT(!document->inPageCache());
 
-    document->view()->deref();
-    document->deref();
-
+    if (document && document->view()) {
+        document->view()->deref();
+        document->deref();
+    }
+    
     [self clear];
 }