2006-11-04 Mark Rowe <bdash@webkit.org>
authorbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 5 Nov 2006 01:02:03 +0000 (01:02 +0000)
committerbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 5 Nov 2006 01:02:03 +0000 (01:02 +0000)
        Reviewed by Darin.

        Fix use of uninitialized value in pattern match.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/Scripts/webkitdirs.pm

index a198d42df7f1fdef19cc3cfa73717d359b449d25..e0d98b5b5ed32e67db52f9b4e102bd529e8ca821 100644 (file)
@@ -1,3 +1,11 @@
+2006-11-04  Mark Rowe  <bdash@webkit.org>
+
+        Reviewed by Darin.
+
+        Fix use of uninitialized value in pattern match.
+
+        * Scripts/webkitdirs.pm:
+
 2006-11-04  Darin Adler  <darin@apple.com>
 
         Reviewed by Tim Hatcher.
index 355ae9b011c9c3f344c2e5cb303b20d130781773..b6e159a90a45da9b44a70f792c42c65ae5e9ecd2 100644 (file)
@@ -84,8 +84,10 @@ sub determineBaseProductDir
         open PRODUCT, "defaults read com.apple.Xcode PBXProductDirectory 2> /dev/null |" or die;
         $baseProductDir = <PRODUCT>;
         close PRODUCT;
-        chomp $baseProductDir if $baseProductDir;
-        undef $baseProductDir unless $baseProductDir =~ /^\//;
+        if ($baseProductDir) {
+            chomp $baseProductDir;
+            undef $baseProductDir unless $baseProductDir =~ /^\//;
+        }
     } else {
         $baseProductDir = $ENV{"WEBKITOUTPUTDIR"};
         if (isCygwin() && $baseProductDir) {