Reviewed by mjs.
authorggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 16 Nov 2005 01:45:19 +0000 (01:45 +0000)
committerggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 16 Nov 2005 01:45:19 +0000 (01:45 +0000)
        - Part of the fix for <rdar://problem/4342216> Installer crash in
          KJS::ValueImp::marked() when garbage collector runs inside call to
          ConstantValues::init()

        Added locking in JSRunCreate, since JSRun::JSRun constructs an object.

        * JavaScriptGlue.cpp:
        (JSRunCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptGlue/ChangeLog
JavaScriptGlue/JavaScriptGlue.cpp

index 01016e443163b1dd1a8c919743f8d5d7da66ec5a..36da2d850e79e7a912e3f3aed4ed336681bc6f67 100644 (file)
@@ -1,3 +1,16 @@
+2005-11-14  Geoffrey Garen  <ggaren@apple.com>
+
+        Reviewed by mjs.
+
+        - Part of the fix for <rdar://problem/4342216> Installer crash in 
+          KJS::ValueImp::marked() when garbage collector runs inside call to 
+          ConstantValues::init()
+          
+        Added locking in JSRunCreate, since JSRun::JSRun constructs an object.
+        
+        * JavaScriptGlue.cpp:
+        (JSRunCreate):
+
 2005-11-10  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Maciej.
index 2c92a61e67974c6360c982c98257768a4b6e1fee..dfe082db7d21b5a9d9e8e88c4c17502b395a4efb 100644 (file)
@@ -217,6 +217,7 @@ JSRunRef JSRunCreate(CFStringRef jsSource, JSFlags inFlags)
     JSRunRef result = 0;
     if (jsSource)
     {
+        InterpreterLock lock;
         result = (JSRunRef) new JSRun(jsSource, inFlags);
     }
     return result;