2011-02-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Fix coding style errors in tiled BS and ewk_window_feature.h
        https://bugs.webkit.org/show_bug.cgi?id=54842

        Fix style errors in ewk files.

        * ewk/ewk_tiled_backing_store.h:
        * ewk/ewk_tiled_matrix.h:
        * ewk/ewk_tiled_model.h:
        * ewk/ewk_window_features.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
index 7efa9a32fc0a2dac4e9bb4ad350482bbb0c5d335..464005a9e3b34e053b87f5588e4b8c334d53db37 100644 (file)
--- a/Source/WebKit/efl/ChangeLog
+++ b/Source/WebKit/efl/ChangeLog
@@ -1,3 +1,17 @@
+2011-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Reviewed by Kent Tamura.
+
+        [EFL] Fix coding style errors in tiled BS and ewk_window_feature.h
+        https://bugs.webkit.org/show_bug.cgi?id=54842
+
+        Fix style errors in ewk files.
+
+        * ewk/ewk_tiled_backing_store.h:
+        * ewk/ewk_tiled_matrix.h:
+        * ewk/ewk_tiled_model.h:
+        * ewk/ewk_window_features.h:
+
 2011-02-19  Lukasz Slachciak  <l.slachciak@samsung.com>
 
         Reviewed by Andreas Kling.

diff --git a/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h b/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h
index 4af58c836e174c781da539e1dc0f1d8ae5da17d3..6e39a792fccf82dae337e4a2bbda8698011d5746 100644 (file)
--- a/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h
+++ b/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h
@@ -93,38 +93,38 @@ struct _Ewk_Tile {
 #include "ewk_tiled_model.h"
 
 /* view */
-EAPI Evas_Object *ewk_tiled_backing_store_add(Evas *e);
-
-EAPI void ewk_tiled_backing_store_render_cb_set(Evas_Object *o, Eina_Bool (*cb)(void *data, Ewk_Tile *t, const Eina_Rectangle *area), const void *data);
-
-EAPI Eina_Bool    ewk_tiled_backing_store_scroll_full_offset_set(Evas_Object *o, Evas_Coord x, Evas_Coord y);
-EAPI Eina_Bool    ewk_tiled_backing_store_scroll_full_offset_add(Evas_Object *o, Evas_Coord dx, Evas_Coord dy);
-EAPI Eina_Bool    ewk_tiled_backing_store_scroll_inner_offset_add(Evas_Object *o, Evas_Coord dx, Evas_Coord dy, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h);
-
-EAPI Eina_Bool    ewk_tiled_backing_store_zoom_set(Evas_Object *o, float *zoom, Evas_Coord cx, Evas_Coord cy, Evas_Coord *offx, Evas_Coord *offy);
-EAPI Eina_Bool    ewk_tiled_backing_store_zoom_weak_set(Evas_Object *o, float zoom, Evas_Coord cx, Evas_Coord cy);
-EAPI void ewk_tiled_backing_store_fix_offsets(Evas_Object *o, Evas_Coord w, Evas_Coord h);
-EAPI void ewk_tiled_backing_store_zoom_weak_smooth_scale_set(Evas_Object *o, Eina_Bool smooth_scale);
-EAPI Eina_Bool    ewk_tiled_backing_store_update(Evas_Object *o, const Eina_Rectangle *update);
-EAPI void ewk_tiled_backing_store_updates_process_pre_set(Evas_Object *o, void *(*cb)(void *data, Evas_Object *o), const void *data);
-EAPI void ewk_tiled_backing_store_updates_process_post_set(Evas_Object *o, void *(*cb)(void *data, void *pre_data, Evas_Object *o), const void *data);
-EAPI void ewk_tiled_backing_store_process_entire_queue_set(Evas_Object *o, Eina_Bool value);
-EAPI void ewk_tiled_backing_store_updates_process(Evas_Object *o);
-EAPI void ewk_tiled_backing_store_updates_clear(Evas_Object *o);
-EAPI void ewk_tiled_backing_store_contents_resize(Evas_Object *o, Evas_Coord width, Evas_Coord height);
-EAPI void ewk_tiled_backing_store_disabled_update_set(Evas_Object *o, Eina_Bool value);
-EAPI void ewk_tiled_backing_store_flush(Evas_Object *o);
-EAPI void ewk_tiled_backing_store_enable_scale_set(Evas_Object *o, Eina_Bool value);
-
-EAPI Ewk_Tile_Unused_Cache *ewk_tiled_backing_store_tile_unused_cache_get(const Evas_Object *o);
-EAPI void                   ewk_tiled_backing_store_tile_unused_cache_set(Evas_Object *o, Ewk_Tile_Unused_Cache *tuc);
-
-EAPI Eina_Bool ewk_tiled_backing_store_pre_render_region(Evas_Object *o, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h, float zoom);
-EAPI Eina_Bool ewk_tiled_backing_store_pre_render_relative_radius(Evas_Object *o, unsigned int n, float zoom);
-EAPI void ewk_tiled_backing_store_pre_render_cancel(Evas_Object *o);
-
-EAPI Eina_Bool ewk_tiled_backing_store_disable_render(Evas_Object *o);
-EAPI Eina_Bool ewk_tiled_backing_store_enable_render(Evas_Object *o);
+EAPI Evas_Object *ewk_tiled_backing_store_add(Evas*);
+
+EAPI void ewk_tiled_backing_store_render_cb_set(Evas_Object*, Eina_Bool (*cb)(void *data, Ewk_Tile*, const Eina_Rectangle*), const void *data);
+
+EAPI Eina_Bool    ewk_tiled_backing_store_scroll_full_offset_set(Evas_Object*, Evas_Coord x, Evas_Coord y);
+EAPI Eina_Bool    ewk_tiled_backing_store_scroll_full_offset_add(Evas_Object*, Evas_Coord dx, Evas_Coord dy);
+EAPI Eina_Bool    ewk_tiled_backing_store_scroll_inner_offset_add(Evas_Object*, Evas_Coord dx, Evas_Coord dy, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h);
+
+EAPI Eina_Bool    ewk_tiled_backing_store_zoom_set(Evas_Object*, float *zoom, Evas_Coord cx, Evas_Coord cy, Evas_Coord *offx, Evas_Coord *offy);
+EAPI Eina_Bool    ewk_tiled_backing_store_zoom_weak_set(Evas_Object*, float zoom, Evas_Coord cx, Evas_Coord cy);
+EAPI void ewk_tiled_backing_store_fix_offsets(Evas_Object*, Evas_Coord w, Evas_Coord h);
+EAPI void ewk_tiled_backing_store_zoom_weak_smooth_scale_set(Evas_Object*, Eina_Bool smooth_scale);
+EAPI Eina_Bool    ewk_tiled_backing_store_update(Evas_Object*, const Eina_Rectangle*);
+EAPI void ewk_tiled_backing_store_updates_process_pre_set(Evas_Object*, void *(*cb)(void *data, Evas_Object*), const void *data);
+EAPI void ewk_tiled_backing_store_updates_process_post_set(Evas_Object*, void *(*cb)(void *data, void *pre_data, Evas_Object*), const void *data);
+EAPI void ewk_tiled_backing_store_process_entire_queue_set(Evas_Object*, Eina_Bool value);
+EAPI void ewk_tiled_backing_store_updates_process(Evas_Object*);
+EAPI void ewk_tiled_backing_store_updates_clear(Evas_Object*);
+EAPI void ewk_tiled_backing_store_contents_resize(Evas_Object*, Evas_Coord width, Evas_Coord height);
+EAPI void ewk_tiled_backing_store_disabled_update_set(Evas_Object*, Eina_Bool value);
+EAPI void ewk_tiled_backing_store_flush(Evas_Object*);
+EAPI void ewk_tiled_backing_store_enable_scale_set(Evas_Object*, Eina_Bool value);
+
+EAPI Ewk_Tile_Unused_Cache *ewk_tiled_backing_store_tile_unused_cache_get(const Evas_Object*);
+EAPI void                   ewk_tiled_backing_store_tile_unused_cache_set(Evas_Object*, Ewk_Tile_Unused_Cache*);
+
+EAPI Eina_Bool ewk_tiled_backing_store_pre_render_region(Evas_Object*, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h, float zoom);
+EAPI Eina_Bool ewk_tiled_backing_store_pre_render_relative_radius(Evas_Object*, unsigned int number, float zoom);
+EAPI void ewk_tiled_backing_store_pre_render_cancel(Evas_Object*);
+
+EAPI Eina_Bool ewk_tiled_backing_store_disable_render(Evas_Object*);
+EAPI Eina_Bool ewk_tiled_backing_store_enable_render(Evas_Object*);
 #ifdef __cplusplus
 }
 #endif

diff --git a/Source/WebKit/efl/ewk/ewk_tiled_matrix.h b/Source/WebKit/efl/ewk/ewk_tiled_matrix.h
index 07b8612a4931ceea30f09f992dbd2f4555a77deb..91f36a9be78723c916458f1b9bd6c3d14927bf35 100644 (file)
--- a/Source/WebKit/efl/ewk/ewk_tiled_matrix.h
+++ b/Source/WebKit/efl/ewk/ewk_tiled_matrix.h
@@ -27,32 +27,32 @@
 #include <Evas.h>
 
 /* matrix of tiles */
-EAPI Ewk_Tile_Matrix *ewk_tile_matrix_new(Ewk_Tile_Unused_Cache *tuc, unsigned long cols, unsigned long rows, Evas_Colorspace cspace, void (*render_cb)(void *data, Ewk_Tile *t, const Eina_Rectangle *update), const void *data);
-EAPI void         ewk_tile_matrix_free(Ewk_Tile_Matrix *tm);
+EAPI Ewk_Tile_Matrix *ewk_tile_matrix_new(Ewk_Tile_Unused_Cache*, unsigned long cols, unsigned long rows, Evas_Colorspace cspace, void (*render_cb)(void *data, Ewk_Tile*, const Eina_Rectangle*), const void *data);
+EAPI void         ewk_tile_matrix_free(Ewk_Tile_Matrix*);
 
-EAPI void         ewk_tile_matrix_resize(Ewk_Tile_Matrix *tm, unsigned long cols, unsigned long rows);
+EAPI void         ewk_tile_matrix_resize(Ewk_Tile_Matrix*, unsigned long cols, unsigned long rows);
 
-EAPI Ewk_Tile_Unused_Cache *ewk_tile_matrix_unused_cache_get(const Ewk_Tile_Matrix *tm);
+EAPI Ewk_Tile_Unused_Cache *ewk_tile_matrix_unused_cache_get(const Ewk_Tile_Matrix*);
 
-EAPI Ewk_Tile     *ewk_tile_matrix_tile_exact_get(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, float zoom);
-EAPI Eina_Bool     ewk_tile_matrix_tile_exact_exists(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, float zoom);
-EAPI Ewk_Tile     *ewk_tile_matrix_tile_nearest_get(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, float zoom);
-EAPI Ewk_Tile     *ewk_tile_matrix_tile_new(Ewk_Tile_Matrix *tm, Evas *evas, unsigned long col, unsigned int row, float zoom);
-EAPI Eina_Bool ewk_tile_matrix_tile_put(Ewk_Tile_Matrix *tm, Ewk_Tile *t, double last_used);
+EAPI Ewk_Tile     *ewk_tile_matrix_tile_exact_get(Ewk_Tile_Matrix*, unsigned long col, unsigned int row, float zoom);
+EAPI Eina_Bool     ewk_tile_matrix_tile_exact_exists(Ewk_Tile_Matrix*, unsigned long col, unsigned int row, float zoom);
+EAPI Ewk_Tile     *ewk_tile_matrix_tile_nearest_get(Ewk_Tile_Matrix*, unsigned long col, unsigned int row, float zoom);
+EAPI Ewk_Tile     *ewk_tile_matrix_tile_new(Ewk_Tile_Matrix*, Evas*, unsigned long col, unsigned int row, float zoom);
+EAPI Eina_Bool ewk_tile_matrix_tile_put(Ewk_Tile_Matrix*, Ewk_Tile*, double last_used);
 
-EAPI Eina_Bool ewk_tile_matrix_tile_update(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, const Eina_Rectangle *update);
-EAPI Eina_Bool ewk_tile_matrix_tile_update_full(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row);
-EAPI void ewk_tile_matrix_tile_updates_clear(Ewk_Tile_Matrix *tm, Ewk_Tile *t);
+EAPI Eina_Bool ewk_tile_matrix_tile_update(Ewk_Tile_Matrix*, unsigned long col, unsigned int row, const Eina_Rectangle*);
+EAPI Eina_Bool ewk_tile_matrix_tile_update_full(Ewk_Tile_Matrix*, unsigned long col, unsigned int row);
+EAPI void ewk_tile_matrix_tile_updates_clear(Ewk_Tile_Matrix*, Ewk_Tile*);
 
-EAPI Eina_Bool ewk_tile_matrix_update(Ewk_Tile_Matrix *tm, const Eina_Rectangle *update, float zoom);
-EAPI void      ewk_tile_matrix_updates_process(Ewk_Tile_Matrix *tm);
-EAPI void      ewk_tile_matrix_updates_clear(Ewk_Tile_Matrix *tm);
-EAPI void      ewk_tile_matrix_freeze(Ewk_Tile_Matrix *tm);
-EAPI void      ewk_tile_matrix_thaw(Ewk_Tile_Matrix *tm);
+EAPI Eina_Bool ewk_tile_matrix_update(Ewk_Tile_Matrix*, const Eina_Rectangle*, float zoom);
+EAPI void      ewk_tile_matrix_updates_process(Ewk_Tile_Matrix*);
+EAPI void      ewk_tile_matrix_updates_clear(Ewk_Tile_Matrix*);
+EAPI void      ewk_tile_matrix_freeze(Ewk_Tile_Matrix*);
+EAPI void      ewk_tile_matrix_thaw(Ewk_Tile_Matrix*);
 
 // remove me!
-    void ewk_tile_matrix_dbg(const Ewk_Tile_Matrix *tm);
-    void ewk_tile_unused_cache_dbg(const Ewk_Tile_Unused_Cache *tuc);
+    void ewk_tile_matrix_dbg(const Ewk_Tile_Matrix*);
+    void ewk_tile_unused_cache_dbg(const Ewk_Tile_Unused_Cache*);
     void ewk_tile_accounting_dbg(void);
 
 

diff --git a/Source/WebKit/efl/ewk/ewk_tiled_model.h b/Source/WebKit/efl/ewk/ewk_tiled_model.h
index a546cee2f490d866138d743d6e68061a91c070d8..cf1cf1565b5c724c5f0d120a68f6e32daf35f417 100644 (file)
--- a/Source/WebKit/efl/ewk/ewk_tiled_model.h
+++ b/Source/WebKit/efl/ewk/ewk_tiled_model.h
@@ -27,32 +27,32 @@
 #include <Evas.h>
 
 /* model */
-EAPI Ewk_Tile *ewk_tile_new(Evas *evas, Evas_Coord w, Evas_Coord h, float zoom, Evas_Colorspace cspace);
-EAPI void ewk_tile_free(Ewk_Tile *t);
-EAPI void ewk_tile_unused_cache_clear(Ewk_Tile_Unused_Cache *tuc);
-EAPI void ewk_tile_show(Ewk_Tile *t);
-EAPI void ewk_tile_hide(Ewk_Tile *t);
-Eina_Bool ewk_tile_visible_get(Ewk_Tile *t);
-EAPI void ewk_tile_update_full(Ewk_Tile *t);
-EAPI void ewk_tile_update_area(Ewk_Tile *t, const Eina_Rectangle *r);
-EAPI void ewk_tile_updates_process(Ewk_Tile *t, void (*cb)(void *data, Ewk_Tile *t, const Eina_Rectangle *update), const void *data);
-EAPI void ewk_tile_updates_clear(Ewk_Tile *t);
+EAPI Ewk_Tile *ewk_tile_new(Evas*, Evas_Coord w, Evas_Coord h, float zoom, Evas_Colorspace cspace);
+EAPI void ewk_tile_free(Ewk_Tile*);
+EAPI void ewk_tile_unused_cache_clear(Ewk_Tile_Unused_Cache*);
+EAPI void ewk_tile_show(Ewk_Tile*);
+EAPI void ewk_tile_hide(Ewk_Tile*);
+Eina_Bool ewk_tile_visible_get(Ewk_Tile*);
+EAPI void ewk_tile_update_full(Ewk_Tile*);
+EAPI void ewk_tile_update_area(Ewk_Tile*, const Eina_Rectangle*);
+EAPI void ewk_tile_updates_process(Ewk_Tile*, void (*cb)(void *data, Ewk_Tile*, const Eina_Rectangle*), const void *data);
+EAPI void ewk_tile_updates_clear(Ewk_Tile*);
 
 /* cache of unused tiles */
 EAPI Ewk_Tile_Unused_Cache *ewk_tile_unused_cache_new(size_t max);
-EAPI void ewk_tile_unused_cache_lock_area(Ewk_Tile_Unused_Cache *tuc, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h, float zoom);
-EAPI void ewk_tile_unused_cache_unlock_area(Ewk_Tile_Unused_Cache *tuc);
-EAPI void ewk_tile_unused_cache_free(Ewk_Tile_Unused_Cache *tuc);
-EAPI Ewk_Tile_Unused_Cache *ewk_tile_unused_cache_ref(Ewk_Tile_Unused_Cache *tuc);
-EAPI void ewk_tile_unused_cache_unref(Ewk_Tile_Unused_Cache *tuc);
+EAPI void ewk_tile_unused_cache_lock_area(Ewk_Tile_Unused_Cache*, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h, float zoom);
+EAPI void ewk_tile_unused_cache_unlock_area(Ewk_Tile_Unused_Cache*);
+EAPI void ewk_tile_unused_cache_free(Ewk_Tile_Unused_Cache*);
+EAPI Ewk_Tile_Unused_Cache *ewk_tile_unused_cache_ref(Ewk_Tile_Unused_Cache*);
+EAPI void ewk_tile_unused_cache_unref(Ewk_Tile_Unused_Cache*);
 
-EAPI void ewk_tile_unused_cache_dirty(Ewk_Tile_Unused_Cache *tuc);
+EAPI void ewk_tile_unused_cache_dirty(Ewk_Tile_Unused_Cache*);
 
-EAPI void ewk_tile_unused_cache_freeze(Ewk_Tile_Unused_Cache *tuc);
-EAPI void ewk_tile_unused_cache_thaw(Ewk_Tile_Unused_Cache *tuc);
+EAPI void ewk_tile_unused_cache_freeze(Ewk_Tile_Unused_Cache*);
+EAPI void ewk_tile_unused_cache_thaw(Ewk_Tile_Unused_Cache*);
 
-EAPI Eina_Bool ewk_tile_unused_cache_tile_get(Ewk_Tile_Unused_Cache *tuc, Ewk_Tile *t);
-EAPI Eina_Bool ewk_tile_unused_cache_tile_put(Ewk_Tile_Unused_Cache *tuc, Ewk_Tile *t, void (*tile_free_cb)(void *data, Ewk_Tile *t), const void *data);
+EAPI Eina_Bool ewk_tile_unused_cache_tile_get(Ewk_Tile_Unused_Cache*, Ewk_Tile*);
+EAPI Eina_Bool ewk_tile_unused_cache_tile_put(Ewk_Tile_Unused_Cache*, Ewk_Tile*, void (*tile_free_cb)(void *data, Ewk_Tile*), const void *data);
 
 #endif // ewk_tiled_model_h
 

diff --git a/Source/WebKit/efl/ewk/ewk_window_features.h b/Source/WebKit/efl/ewk/ewk_window_features.h
index b579dc41d305d1883b6c4c27b2d0a51a3a97b881..e996eb1c7ec4049363cbaf7c9b6a27e87136aa14 100644 (file)
--- a/Source/WebKit/efl/ewk/ewk_window_features.h
+++ b/Source/WebKit/efl/ewk/ewk_window_features.h
@@ -31,11 +31,11 @@ extern "C" {
 
 typedef struct _Ewk_Window_Features Ewk_Window_Features;
 
-EAPI void         ewk_window_features_unref(Ewk_Window_Features* window_features);
-EAPI void         ewk_window_features_ref(Ewk_Window_Features* window_features);
+EAPI void         ewk_window_features_unref(Ewk_Window_Features*);
+EAPI void         ewk_window_features_ref(Ewk_Window_Features*);
 
-EAPI void         ewk_window_features_bool_property_get(Ewk_Window_Features* window_features, Eina_Bool* toolbar_visible, Eina_Bool* statusbar_visible, Eina_Bool* scrollbars_visible, Eina_Bool* menubar_visible, Eina_Bool* locationbar_visible, Eina_Bool* fullscreen);
-EAPI void         ewk_window_features_int_property_get(Ewk_Window_Features* window_features, int* x, int* y, int* w, int* h);
+EAPI void         ewk_window_features_bool_property_get(Ewk_Window_Features*, Eina_Bool* toolbar_visible, Eina_Bool* statusbar_visible, Eina_Bool* scrollbars_visible, Eina_Bool* menubar_visible, Eina_Bool* locationbar_visible, Eina_Bool* fullscreen);
+EAPI void         ewk_window_features_int_property_get(Ewk_Window_Features*, int* x, int* y, int* w, int* h);
 
 #ifdef __cplusplus
 }