Perf-o-matic should show min/max/stdev on graphs

https://bugs.webkit.org/show_bug.cgi?id=77702

Reviewed by Andreas Kling.

Include min/max/stdev in test runs when available to be shown on the perf-o-matic.

Also merge a change to config.js and increment the version number by 1 (unreviewed).

* Websites/webkit-perf.appspot.com/app.yaml:
* Websites/webkit-perf.appspot.com/js/config.js:
* Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/ChangeLog b/ChangeLog
index 0053198af2910b072210350ca28d6e95ffa81fcc..4e5d1ca057e60bc71873cdf06e45d59a8372cd4c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,19 @@
+2012-02-06  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Perf-o-matic should show min/max/stdev on graphs
+        https://bugs.webkit.org/show_bug.cgi?id=77702
+
+        Reviewed by Andreas Kling.
+
+        Include min/max/stdev in test runs when available to be shown on the perf-o-matic.
+
+        Also merge a change to config.js and increment the version number by 1 (unreviewed).
+
+        * Websites/webkit-perf.appspot.com/app.yaml:
+        * Websites/webkit-perf.appspot.com/js/config.js:
+        * Websites/webkit-perf.appspot.com/runs_handler.py:
+        (RunsHandler.get):
+
 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK] Update NEWS and configure.ac for 1.7.5 release

diff --git a/Websites/webkit-perf.appspot.com/app.yaml b/Websites/webkit-perf.appspot.com/app.yaml
index ef129aea6458acd58333b500783c42fbbfd91546..6266524c515a240342209e2b4f676ccbb3ade542 100644 (file)
--- a/Websites/webkit-perf.appspot.com/app.yaml
+++ b/Websites/webkit-perf.appspot.com/app.yaml
@@ -1,5 +1,5 @@
 application: webkit-perf
-version: 10
+version: 11
 runtime: python27
 api_version: 1
 threadsafe: false

diff --git a/Websites/webkit-perf.appspot.com/js/config.js b/Websites/webkit-perf.appspot.com/js/config.js
index 97db81361265e1f4e2c132bacadd6cbf6522a369..c7a08e8d68387cf8f305218ae8b70c0dd9398261 100644 (file)
--- a/Websites/webkit-perf.appspot.com/js/config.js
+++ b/Websites/webkit-perf.appspot.com/js/config.js
@@ -15,9 +15,11 @@ var SERVER = location.protocol.indexOf('http') == 0 ? location.protocol + '//' +
 // server for static dashboard images
 var IMAGE_SERVER = SERVER;
 
-var LIGHT_COLORS = $.map(COLORS, function(color) {
-    return $.color.parse(color).add('a', -.5).toString();
-});
+if ($.color) {
+    var LIGHT_COLORS = $.map(COLORS, function(color) {
+        return $.color.parse(color).add('a', -.5).toString();
+    });
+}
 
 var PLOT_OPTIONS = {
     xaxis: { mode: 'time' },

diff --git a/Websites/webkit-perf.appspot.com/runs_handler.py b/Websites/webkit-perf.appspot.com/runs_handler.py
index c73ec42b35e6a4fa1ff556129c996128d71a65df..ca31093918d71f18081339f086b5831a920e21ed 100644 (file)
--- a/Websites/webkit-perf.appspot.com/runs_handler.py
+++ b/Websites/webkit-perf.appspot.com/runs_handler.py
@@ -85,9 +85,14 @@ class RunsHandler(webapp2.RequestHandler):
             for result in results:
                 builderId = build.builder.key().id()
                 posixTimestamp = mktime(build.timestamp.timetuple())
+                statistics = None
+                if result.valueStdev != None and result.valueMin != None and result.valueMax != None:
+                    statistics = {'stdev': result.valueStdev, 'min': result.valueMin, 'max': result.valueMax}
                 test_runs.append([result.key().id(),
                     [build.key().id(), build.buildNumber, build.revision],
-                    posixTimestamp, result.value, 0, [], builderId])
+                    posixTimestamp, result.value, 0,  # runNumber
+                    [],  # annotations
+                    builderId, statistics])
                 # FIXME: Calculate the average; in practice, we wouldn't have more than one value for a given revision
                 averages[build.revision] = result.value
                 values.append(result.value)