Returned Exception* values need to be initialized to nullptr when no exceptions are...
authormark.lam@apple.com <mark.lam@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 6 Jun 2015 07:55:21 +0000 (07:55 +0000)
committermark.lam@apple.com <mark.lam@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 6 Jun 2015 07:55:21 +0000 (07:55 +0000)
https://bugs.webkit.org/show_bug.cgi?id=145720

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):

Source/WebCore:

No new tests because this issue is already covered by the existing inspector-protocol tests.

* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):

LayoutTests:

* platform/win/TestExpectations:
- Undoing skipped tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@185286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/TestExpectations
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp
Source/WebCore/ChangeLog
Source/WebCore/bindings/js/WorkerScriptController.cpp

index cbed509..07d8c65 100644 (file)
@@ -1,3 +1,13 @@
+2015-06-06  Mark Lam  <mark.lam@apple.com>
+
+        Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.
+        https://bugs.webkit.org/show_bug.cgi?id=145720
+
+        Reviewed by Dan Bernstein.
+
+        * platform/win/TestExpectations:
+        - Undoing skipped tests.
+
 2015-06-05  Mark Lam  <mark.lam@apple.com>
 
         Gardening: skip some inspector-protocol tests while the issue is being investigated.
 2015-06-05  Mark Lam  <mark.lam@apple.com>
 
         Gardening: skip some inspector-protocol tests while the issue is being investigated.
index 55c0a3f..0cda4e3 100644 (file)
@@ -2369,14 +2369,6 @@ webkit.org/b/128979 [ Release ] inspector-protocol/dom/getAccessibilityPropertie
 inspector-protocol/debugger/removeBreakpoint.html [ Skip ] # Crashing
 inspector-protocol/debugger/searchInContent-linebreaks.html [ Pass Crash ] # Flaky
 
 inspector-protocol/debugger/removeBreakpoint.html [ Skip ] # Crashing
 inspector-protocol/debugger/searchInContent-linebreaks.html [ Pass Crash ] # Flaky
 
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/didSampleProbe-multiple-probes.html [ Skip ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/hit-breakpoint-from-console.html [ Skip ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/setBreakpoint-condition.html [ Skip ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html [ Failure ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/setBreakpoint-actions.html [ Failure ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/setBreakpoint-column.html [ Failure ]
-webkit.org/b/145720 [ Release ] inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html [ Failure ]
-
 webkit.org/b/143548 inspector/console/console-api.html [ Skip ] # Timeout
 ################################################################################
 #################        End Inspector Issues               ####################
 webkit.org/b/143548 inspector/console/console-api.html [ Skip ] # Timeout
 ################################################################################
 #################        End Inspector Issues               ####################
index 62671fe..60d5232 100644 (file)
@@ -1,3 +1,13 @@
+2015-06-06  Mark Lam  <mark.lam@apple.com>
+
+        Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.
+        https://bugs.webkit.org/show_bug.cgi?id=145720
+
+        Reviewed by Dan Bernstein.
+
+        * debugger/DebuggerCallFrame.cpp:
+        (JSC::DebuggerCallFrame::evaluate):
+
 2015-06-05  Mark Lam  <mark.lam@apple.com>
 
         Subclasses of JSNonFinalObject with gc'able children need to implement visitChildren().
 2015-06-05  Mark Lam  <mark.lam@apple.com>
 
         Subclasses of JSNonFinalObject with gc'able children need to implement visitChildren().
index f92f290..c6ac475 100644 (file)
@@ -180,6 +180,7 @@ JSValue DebuggerCallFrame::thisValue() const
 JSValue DebuggerCallFrame::evaluate(const String& script, Exception*& exception)
 {
     ASSERT(isValid());
 JSValue DebuggerCallFrame::evaluate(const String& script, Exception*& exception)
 {
     ASSERT(isValid());
+    exception = nullptr;
     CallFrame* callFrame = m_callFrame;
     if (!callFrame)
         return jsNull();
     CallFrame* callFrame = m_callFrame;
     if (!callFrame)
         return jsNull();
index 34eefcd..77ddc82 100644 (file)
@@ -1,3 +1,15 @@
+2015-06-06  Mark Lam  <mark.lam@apple.com>
+
+        Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.
+        https://bugs.webkit.org/show_bug.cgi?id=145720
+
+        Reviewed by Dan Bernstein.
+
+        No new tests because this issue is already covered by the existing inspector-protocol tests.
+
+        * bindings/js/WorkerScriptController.cpp:
+        (WebCore::WorkerScriptController::evaluate):
+
 2015-06-05  Andreas Kling  <akling@apple.com>
 
         [iOS] Don't force compositing layers for no-op 3D transforms on low-memory devices.
 2015-06-05  Andreas Kling  <akling@apple.com>
 
         [iOS] Don't force compositing layers for no-op 3D transforms on low-memory devices.
index f8a62d3..e58b132 100644 (file)
@@ -109,6 +109,7 @@ void WorkerScriptController::evaluate(const ScriptSourceCode& sourceCode)
 
 void WorkerScriptController::evaluate(const ScriptSourceCode& sourceCode, JSC::Exception*& returnedException)
 {
 
 void WorkerScriptController::evaluate(const ScriptSourceCode& sourceCode, JSC::Exception*& returnedException)
 {
+    returnedException = nullptr;
     if (isExecutionForbidden())
         return;
 
     if (isExecutionForbidden())
         return;