Reviewed by Adele.

        Move border-radius rule for <select>s into RenderThemeMac, as this is
        really a platform-specific look.

        * css/html4.css:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustMenuListButtonStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 15fbed6e50c1c119062c32df3aa839f34ac43c2c..8d86f8c23b02bca78060e11d5680b885122e992a 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,14 @@
+2006-10-23  Adam Roben  <aroben@apple.com>
+
+        Reviewed by Adele.
+
+        Move border-radius rule for <select>s into RenderThemeMac, as this is
+        really a platform-specific look.
+
+        * css/html4.css:
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
+
 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Brady.

diff --git a/WebCore/css/html4.css b/WebCore/css/html4.css
index 33fe2cd0309c363eaa65278a0446be19d3d113e1..0ea36e32ece66a6102b47787af2e117fd7884a6e 100644 (file)
--- a/WebCore/css/html4.css
+++ b/WebCore/css/html4.css
@@ -416,7 +416,6 @@ select {
     -webkit-rtl-ordering: logical;
     color: black;
     border: 1px solid;
-    -webkit-border-radius: 5px;
     background-color: white;
     white-space: pre;
 }

diff --git a/WebCore/rendering/RenderThemeMac.mm b/WebCore/rendering/RenderThemeMac.mm
index 7a9f56ea0c2f107e1a6c4e68d803e4350dcb4068..74f8ac8a23038db221adf6fb0c754e978462e344 100644 (file)
--- a/WebCore/rendering/RenderThemeMac.mm
+++ b/WebCore/rendering/RenderThemeMac.mm
@@ -874,8 +874,7 @@ void RenderThemeMac::adjustMenuListButtonStyle(CSSStyleSelector* selector, Rende
     style->setPaddingTop(Length(styledPopupPaddingTop, Fixed));
     style->setPaddingBottom(Length(styledPopupPaddingBottom, Fixed));
     
-    if (style->hasBorderRadius())
-        style->setBorderRadius(IntSize(int(baseBorderRadius + fontScale - 1), int(baseBorderRadius + fontScale - 1))); // FIXME: Round up?
+    style->setBorderRadius(IntSize(int(baseBorderRadius + fontScale - 1), int(baseBorderRadius + fontScale - 1))); // FIXME: Round up?
     
     const int minHeight = 15;
     style->setMinHeight(Length(minHeight, Fixed));