Web Inspector: detailed heap snapshot: Replace (Native objects) root element
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Jan 2012 14:08:49 +0000 (14:08 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Jan 2012 14:08:49 +0000 (14:08 +0000)
with '(Detached DOM trees)' and '(Document DOM trees)'
https://bugs.webkit.org/show_bug.cgi?id=77201

I think it'd be nice to replace one group containing all native objects with
separate groups for different types of native objects.

Reviewed by Yury Semikhatsky.

* bindings/v8/RetainedDOMInfo.cpp:
(WebCore::RetainedDOMInfo::GetGroupLabel):
(WebCore):
* bindings/v8/RetainedDOMInfo.h:
(RetainedDOMInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/v8/RetainedDOMInfo.cpp
Source/WebCore/bindings/v8/RetainedDOMInfo.h

index 115109fa2c6637c0eb677e861ff3ead89394f1ca..f93422866e167661615e579adf1362e2a22b619d 100644 (file)
@@ -1,3 +1,20 @@
+2012-01-27  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: detailed heap snapshot: Replace (Native objects) root element
+        with '(Detached DOM trees)' and '(Document DOM trees)'
+        https://bugs.webkit.org/show_bug.cgi?id=77201
+
+        I think it'd be nice to replace one group containing all native objects with
+        separate groups for different types of native objects.
+
+        Reviewed by Yury Semikhatsky.
+
+        * bindings/v8/RetainedDOMInfo.cpp:
+        (WebCore::RetainedDOMInfo::GetGroupLabel):
+        (WebCore):
+        * bindings/v8/RetainedDOMInfo.h:
+        (RetainedDOMInfo):
+
 2012-01-27  Nikolas Zimmermann  <nzimmermann@rim.com>
 
         <feImage> doesn't work with local references when using primitiveUnits="objectBoundingBox"
 2012-01-27  Nikolas Zimmermann  <nzimmermann@rim.com>
 
         <feImage> doesn't work with local references when using primitiveUnits="objectBoundingBox"
index ba642637a18cc409e23e96b3ab2538989253f049..9edda78f4e1d6b059bac61acc462afeb81eb7ea8 100644 (file)
@@ -61,6 +61,11 @@ intptr_t RetainedDOMInfo::GetHash()
     return reinterpret_cast<intptr_t>(m_root);
 }
     
     return reinterpret_cast<intptr_t>(m_root);
 }
     
+const char* RetainedDOMInfo::GetGroupLabel()
+{
+    return m_root->inDocument() ? "(Document DOM trees)" : "(Detached DOM trees)";
+}
+
 const char* RetainedDOMInfo::GetLabel()
 {
     return m_root->inDocument() ? "Document DOM tree" : "Detached DOM tree";
 const char* RetainedDOMInfo::GetLabel()
 {
     return m_root->inDocument() ? "Document DOM tree" : "Detached DOM tree";
index 6767f75b727838b486a23ed208f9dcbb101539f2..148bb2f5d437067adb19d0b874e37b918cbc0ef2 100644 (file)
@@ -45,6 +45,7 @@ public:
     virtual void Dispose();
     virtual bool IsEquivalent(v8::RetainedObjectInfo* other);
     virtual intptr_t GetHash();
     virtual void Dispose();
     virtual bool IsEquivalent(v8::RetainedObjectInfo* other);
     virtual intptr_t GetHash();
+    virtual const char* GetGroupLabel();
     virtual const char* GetLabel();
     virtual intptr_t GetElementCount();
     virtual intptr_t GetEquivalenceClass();
     virtual const char* GetLabel();
     virtual intptr_t GetElementCount();
     virtual intptr_t GetEquivalenceClass();