Unreviewed, partially revert r191952.
authorossy@webkit.org <ossy@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 Nov 2015 18:30:05 +0000 (18:30 +0000)
committerossy@webkit.org <ossy@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 Nov 2015 18:30:05 +0000 (18:30 +0000)
Removed GCC compiler workarounds (unreachable returns).

* b3/B3Type.h:
(JSC::B3::sizeofType):
* b3/air/AirArg.h:
(JSC::B3::Air::Arg::isUse):
(JSC::B3::Air::Arg::isDef):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::isType):
* b3/air/AirCode.h:
(JSC::B3::Air::Code::newTmp):
(JSC::B3::Air::Code::numTmps):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/b3/B3Type.h
Source/JavaScriptCore/b3/air/AirArg.h
Source/JavaScriptCore/b3/air/AirCode.h

index 916cb38630bac0a0427f89efebdabef32bdc81a0..4a80a2c89eb81d6e92bd20548d420f7eb164d9b8 100644 (file)
@@ -1,3 +1,21 @@
+2015-11-03  Csaba Osztrogon√°c  <ossy@webkit.org>
+
+        Unreviewed, partially revert r191952.
+
+        Removed GCC compiler workarounds (unreachable returns).
+
+        * b3/B3Type.h:
+        (JSC::B3::sizeofType):
+        * b3/air/AirArg.h:
+        (JSC::B3::Air::Arg::isUse):
+        (JSC::B3::Air::Arg::isDef):
+        (JSC::B3::Air::Arg::isGP):
+        (JSC::B3::Air::Arg::isFP):
+        (JSC::B3::Air::Arg::isType):
+        * b3/air/AirCode.h:
+        (JSC::B3::Air::Code::newTmp):
+        (JSC::B3::Air::Code::numTmps):
+
 2015-11-03  Csaba Osztrogon√°c  <ossy@webkit.org>
 
         Fix the ENABLE(B3_JIT) build on Linux
index a91460153c2f57b58e087a53dc5be2be70df1827..cf4a560557558bf757e4cc2cd6d5bf784c7a8163 100644 (file)
@@ -68,8 +68,6 @@ inline size_t sizeofType(Type type)
     case Double:
         return 8;
     }
-    RELEASE_ASSERT_NOT_REACHED();
-    return 0;
 }
 
 } } // namespace JSC::B3
index 99c473b64c4ad6ea3fa0ea4a8dce2452d706e341..6b9fca5109694eeb7f922483802a52c9634a1dab 100644 (file)
@@ -122,8 +122,6 @@ public:
         case UseAddr:
             return false;
         }
-        RELEASE_ASSERT_NOT_REACHED();
-        return false;
     }
 
     // Returns true if the Role implies that the Inst will Def the Arg.
@@ -137,8 +135,6 @@ public:
         case UseDef:
             return true;
         }
-        RELEASE_ASSERT_NOT_REACHED();
-        return false;
     }
 
     static Type typeForB3Type(B3::Type type)
@@ -472,8 +468,6 @@ public:
         case Invalid:
             return false;
         }
-        RELEASE_ASSERT_NOT_REACHED();
-        return false;
     }
 
     // Tells us if this Arg can be used in a position that requires a FP value.
@@ -496,8 +490,6 @@ public:
         case Tmp:
             return isFPTmp();
         }
-        RELEASE_ASSERT_NOT_REACHED();
-        return false;
     }
 
     bool hasType() const
@@ -526,8 +518,6 @@ public:
         case FP:
             return isFP();
         }
-        RELEASE_ASSERT_NOT_REACHED();
-        return false;
     }
 
     bool isGPR() const
index 96e286bec50cfe5123d005c37fb9d8ee320dc6e5..e7774eed38778180cd09a313b040416d0619faf1 100644 (file)
@@ -71,8 +71,6 @@ public:
         case Arg::FP:
             return Tmp::fpTmpForIndex(m_numFPTmps++);
         }
-        RELEASE_ASSERT_NOT_REACHED();
-        return { };
     }
 
     unsigned numTmps(Arg::Type type)
@@ -83,8 +81,6 @@ public:
         case Arg::FP:
             return m_numFPTmps;
         }
-        RELEASE_ASSERT_NOT_REACHED();
-        return 0;
     }
 
     unsigned callArgAreaSize() const { return m_callArgAreaSize; }