https://bugs.webkit.org/show_bug.cgi?id=141583
Reviewed by Darin Adler.
Support $builderName in the build URL template.
* public/js/helper-classes.js:
(TestBuild.buildUrl): Replaced $builderName with the builder name.
* public/v2/manifest.js:
(App.Metric.fullName): Fixed the typo. We need &ni, not &in.
(App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
+
+ Build URL on new perf dashboard doesn't resolve $builderName
+ https://bugs.webkit.org/show_bug.cgi?id=141583
+
+ Reviewed by Darin Adler.
+
+ Support $builderName in the build URL template.
+
+ * public/js/helper-classes.js:
+ (TestBuild.buildUrl): Replaced $builderName with the builder name.
+
+ * public/v2/manifest.js:
+ (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
+ (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
+
2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix after r179591.
this.builder = function () { return builders[rawRun.builder].name; }
this.buildNumber = function () { return rawRun.buildNumber; }
this.buildUrl = function () {
- var template = builders[rawRun.builder].buildUrl;
- return template ? template.replace(/\$buildNumber/g, this.buildNumber()) : null;
+ var builder = builders[rawRun.builder];
+ var template = builder.buildUrl;
+ if (!template)
+ return null;
+ return template.replace(/\$buildNumber/g, this.buildNumber()).replace(/\$builderName/g, builder.name);
}
this.platform = function () { return platform; }
this.revision = function(repositoryId) { return revisions[repositoryId][0]; }
}.property('name', 'test'),
fullName: function ()
{
- return this.get('path').join(' \u2208 ') /* ∈ */
+ return this.get('path').join(' \u220b ') /* ∋ */
+ ' : ' + this.get('label');
}.property('path', 'label'),
});
urlFromBuildNumber: function (buildNumber)
{
var template = this.get('buildUrl');
- return template ? template.replace(/\$buildNumber/g, buildNumber) : null;
+ return template ? template.replace(/\$builderName/g, this.get('name')).replace(/\$buildNumber/g, buildNumber) : null;
}
});