Build fix. Don't fall into an infinite loop when value (renamed from bytes) is zero.

* public/v2/manifest.js:
(App.Manifest.Ember.Controller.extend.):
(App.Manifest.Ember.Controller.extend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@184594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 14e90c011948bdb0fe28353f001e715b9576e90f..38c177824337f6d1d7a7750a6b9aac17bcbb9bc6 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,11 @@
+2015-05-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Build fix. Don't fall into an infinite loop when value (renamed from bytes) is zero.
+
+        * public/v2/manifest.js:
+        (App.Manifest.Ember.Controller.extend.):
+        (App.Manifest.Ember.Controller.extend):
+
 2015-05-19  Ryosuke Niwa  <rniwa@webkit.org>
 
         Don't show unit (bytes) separaetly from SI suffixes (K, M, etc...)

diff --git a/Websites/perf.webkit.org/public/v2/manifest.js b/Websites/perf.webkit.org/public/v2/manifest.js
index 35b4787499127a8b21d6ff4654121ad902d57a5a..ef68cae5cc4ba5d2541dd2d383dc889fe1ca9343 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/manifest.js
+++ b/Websites/perf.webkit.org/public/v2/manifest.js
@@ -326,15 +326,15 @@ App.Manifest = Ember.Controller.extend({
 
         var suffix = ['\u03BC', 'm', '', 'K', 'M', 'G', 'T', 'P', 'E'];
         var threshold = sigFig >= 3 ? divisor : (divisor / 10);
-        return function (bytes) {
+        return function (value) {
             var i;
-            var sign = bytes >= 0 ? (alwaysShowSign ? '+' : '') : '-';
-            bytes = Math.abs(bytes);
-            for (i = isMiliseconds ? 1 : 2; bytes < 1; i--)
-                bytes *= divisor;
-            for (; bytes >= threshold; i++)
-                bytes /= divisor;
-            return sign + bytes.toPrecision(Math.max(2, sigFig)) + ' ' + suffix[i] + (unit || '');
+            var sign = value >= 0 ? (alwaysShowSign ? '+' : '') : '-';
+            value = Math.abs(value);
+            for (i = isMiliseconds ? 1 : 2; value < 1 && i > 0; i--)
+                value *= divisor;
+            for (; value >= threshold; i++)
+                value /= divisor;
+            return sign + value.toPrecision(Math.max(2, sigFig)) + ' ' + suffix[i] + (unit || '');
         }
     },
     _formatFetchedData: function (metricName, configurations)