2010-12-15 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        size status bubble to it's contents on the code review page
        https://bugs.webkit.org/show_bug.cgi?id=51142

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index 778692b91abe7897b7b56bd364bf4a269667f033..75e4d4933fbd9dd6fa58349dafde41529e33d45e 100644 (file)
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -1,3 +1,13 @@
+2010-12-15  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        size status bubble to it's contents on the code review page
+        https://bugs.webkit.org/show_bug.cgi?id=51142
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2010-12-15  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/BugsSite/PrettyPatch/PrettyPatch.rb b/BugsSite/PrettyPatch/PrettyPatch.rb
index fbd4a6c51ca6c6c8e7cb39757100348a0cfcf393..1dd16811c67d344d894898095752c0a111087cd6 100644 (file)
--- a/BugsSite/PrettyPatch/PrettyPatch.rb
+++ b/BugsSite/PrettyPatch/PrettyPatch.rb
@@ -349,16 +349,13 @@ body {
 }
 
 .statusBubble {
-  margin-top: 2px;
-  /* FIXME: Size the statusBubble via postMessage so it sizes to it's content. */
-  width: 300px;
-  height: 20px;
+  margin: 2px 2px 0 0;
   border: none;
   vertical-align: middle;
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=15"></script> 
+<script src="code-review.js?version=16"></script>
 EOF
 
     def self.revisionOrDescription(string)

diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index 3d345bd3bdf959aed8bbce88b48070e1f9e48525..c8872208d7da116dd743bf6c7a113f4f0d64d8be 100644 (file)
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -251,6 +251,18 @@
     });
   }
 
+  window.addEventListener('message', function(e) {
+    if (e.origin != 'https://webkit-commit-queue.appspot.com')
+      return;
+
+    $('.statusBubble')[0].style.height = e.data.height;
+    $('.statusBubble')[0].style.width = e.data.width;
+  });
+
+  function handleStatusBubbleLoad(e) {
+    e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-commit-queue.appspot.com');
+  }
+
   function fetchHistory() {
     $.get('attachment.cgi?id=' + attachment_id + '&action=edit', function(data) {
       var bug_id = /Attachment \d+ Details for Bug (\d+)/.exec(data)[1];
@@ -268,7 +280,15 @@
 
       var details = $(data);
       addFlagsForAttachment(details);
-      $('#statusBubbleContainer').append($('<iframe style="margin-top:2px;" class="statusBubble" src="https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id + '" scrolling="no"></iframe>'));
+
+      var statusBubble = document.createElement('iframe');
+      statusBubble.className = 'statusBubble';
+      statusBubble.src  = 'https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id;
+      statusBubble.scrolling = 'no';
+      // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
+      statusBubble.onload = handleStatusBubbleLoad;
+      $('#statusBubbleContainer').append(statusBubble);
+
       $('#toolbar .bugLink').html('<a href="/show_bug.cgi?id=' + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');
     });
   }