Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Sep 2015 22:59:08 +0000 (22:59 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Sep 2015 22:59:08 +0000 (22:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=142929

Reviewed by Brent Fulgham.

Tools:

Silence the logging. We'll track fixing the root cause in Radar.

* Scripts/webkitpy/port/mac.py:
(MacPort.stderr_patterns_to_strip): Added a FIXME.

* Scripts/webkitpy/port/win.py:
(WinPort.logging_patterns_to_strip): Added.

LayoutTests:

* platform/win/TestExpectations: Unskip some newly added tests that are affected.
We still skip the whole media directory - updating the results and unskipping those
tests would be a separate project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/TestExpectations
Tools/ChangeLog
Tools/Scripts/webkitpy/port/mac.py
Tools/Scripts/webkitpy/port/win.py

index 9696fdbc0a95d760593a91b361d233375b4edca0..ea456682434a4d8878eb9787d012ea28263fb0a8 100644 (file)
@@ -1,3 +1,14 @@
+2015-09-10  Alexey Proskuryakov  <ap@apple.com>
+
+        Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
+        https://bugs.webkit.org/show_bug.cgi?id=142929
+
+        Reviewed by Brent Fulgham.
+
+        * platform/win/TestExpectations: Unskip some newly added tests that are affected.
+        We still skip the whole media directory - updating the results and unskipping those
+        tests would be a separate project.
+
 2015-09-10  David Hyatt  <hyatt@apple.com>
 
         [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
 2015-09-10  David Hyatt  <hyatt@apple.com>
 
         [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
index 00872877dfb4c89af8a15de6917301be238d8dc2..2a5168c9f05dad24a23ed2e9f4753654ae99ea57 100644 (file)
@@ -726,8 +726,6 @@ http/tests/misc/frame-default-enc-same-domain.html [ Skip ]
 
 # Sensitive to load timing or PHP behavior
 webkit.org/b/44873 http/tests/css/css-image-loading.html [ Skip ]
 
 # Sensitive to load timing or PHP behavior
 webkit.org/b/44873 http/tests/css/css-image-loading.html [ Skip ]
-webkit.org/b/149007 http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html [ Pass Failure ]
-http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html [ Pass Failure ] # Flaky
 
 # Assertion failure in replaySavedEvents http://webkit.org/b/21796
 webkit.org/b/21796 fast/events/dragging-mouse-moves.html [ Skip ]
 
 # Assertion failure in replaySavedEvents http://webkit.org/b/21796
 webkit.org/b/21796 fast/events/dragging-mouse-moves.html [ Skip ]
@@ -752,15 +750,13 @@ fast/workers/worker-document-leak.html [ Skip ] # Timeout
 ################################################################################
 # Deactivate all media tests on Apple Windows due to <rdar://problem/18681688> generating 
 # spam logging output that causes tests to fail. Will re-enable once this is fixed. 
 ################################################################################
 # Deactivate all media tests on Apple Windows due to <rdar://problem/18681688> generating 
 # spam logging output that causes tests to fail. Will re-enable once this is fixed. 
+# FIXME: We now filter out the logging, so many of the tests can likely be re-enabled.
 media [ Skip ] 
 fast/media [ Skip ] 
 http/tests/media [ Skip ] 
 
 fast/layers/video-layer.html [ Skip ] # Skip until video control changes are done.
 
 media [ Skip ] 
 fast/media [ Skip ] 
 http/tests/media [ Skip ] 
 
 fast/layers/video-layer.html [ Skip ] # Skip until video control changes are done.
 
-# "AQMEIOManager::FindIOUnit: error -1" errors in tests output.
-webkit.org/b/148903 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ [ Skip ]
-
 # Assertion failures
 webkit.org/b/48910 [ Debug ] http/tests/media/pdf-served-as-pdf.html [ Skip ]  # Crashing
 webkit.org/b/48910 http/tests/media/video-cancel-load.html [ Skip ]  # Crashing
 # Assertion failures
 webkit.org/b/48910 [ Debug ] http/tests/media/pdf-served-as-pdf.html [ Skip ]  # Crashing
 webkit.org/b/48910 http/tests/media/video-cancel-load.html [ Skip ]  # Crashing
index 836a59588e11f002f4597690ada23af7eaddbcd9..fc6e3576f3bc752bcdf82d43773d420230c226db 100644 (file)
@@ -1,3 +1,18 @@
+2015-09-10  Alexey Proskuryakov  <ap@apple.com>
+
+        Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
+        https://bugs.webkit.org/show_bug.cgi?id=142929
+
+        Reviewed by Brent Fulgham.
+
+        Silence the logging. We'll track fixing the root cause in Radar.
+
+        * Scripts/webkitpy/port/mac.py:
+        (MacPort.stderr_patterns_to_strip): Added a FIXME.
+
+        * Scripts/webkitpy/port/win.py:
+        (WinPort.logging_patterns_to_strip): Added.
+
 2015-09-09  Andy Estes  <aestes@apple.com>
 
         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
 2015-09-09  Andy Estes  <aestes@apple.com>
 
         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
index 0c5bfe99cfe353272bec8b121ed418dfbc7909ae..c379790c574c45958ef3a871ca77a299f6fe789e 100644 (file)
@@ -312,6 +312,7 @@ class MacPort(ApplePort):
 
     def stderr_patterns_to_strip(self):
         worthless_patterns = []
 
     def stderr_patterns_to_strip(self):
         worthless_patterns = []
+        # FIXME: We still get CoreMedia stderr logging that doesn't match the below lines. 'defaults write com.apple.coremedia fig_notes 0' may work better for silencing them all, however running tests shouldn't change user's defaults.
         worthless_patterns.append((re.compile('.*(Fig|fig|itemasync|vt|mv_|PullParamSetSPS|ccrp_|client).* signalled err=.*\n'), ''))
         worthless_patterns.append((re.compile('.*<<<< FigFilePlayer >>>>.*\n'), ''))
         worthless_patterns.append((re.compile('.*<<<< FigFile >>>>.*\n'), ''))
         worthless_patterns.append((re.compile('.*(Fig|fig|itemasync|vt|mv_|PullParamSetSPS|ccrp_|client).* signalled err=.*\n'), ''))
         worthless_patterns.append((re.compile('.*<<<< FigFilePlayer >>>>.*\n'), ''))
         worthless_patterns.append((re.compile('.*<<<< FigFile >>>>.*\n'), ''))
index ab69969729ae70cfd9f8365f874f0c4a5a949430..c9174c41a4ca7d8e6303df6d8daa370a91182678 100644 (file)
@@ -328,3 +328,7 @@ class WinPort(ApplePort):
                 pass
 
         return system_pid
                 pass
 
         return system_pid
+
+    def logging_patterns_to_strip(self):
+        # rdar://problem/18681688
+        return [(re.compile('AQMEIOManager::FindIOUnit: error \-1\n'), '')]