Reviewed by Kevin.

        - fixed <rdar://problem/4011210> REGRESSION (180-181): Maxlength property for INPUT object not working

        * kwq/KWQTextField.mm:
        (-[KWQTextField textView:shouldChangeTextInRange:replacementString:]): If controller returns
        YES, go on to call super, since super does the text formatter handling, which we need.
        (-[KWQSecureTextField textView:shouldChangeTextInRange:replacementString:]): Ditto.
        (-[KWQSearchField textView:shouldChangeTextInRange:replacementString:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index c8b6c4a7aed43df75c359740975498b33c8b70b6..fefa70784f46df4b81d236f68cd887b4bfa685c1 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,15 @@
+2005-02-17  Darin Adler  <darin@apple.com>
+
+        Reviewed by Kevin.
+
+        - fixed <rdar://problem/4011210> REGRESSION (180-181): Maxlength property for INPUT object not working
+
+        * kwq/KWQTextField.mm:
+        (-[KWQTextField textView:shouldChangeTextInRange:replacementString:]): If controller returns
+        YES, go on to call super, since super does the text formatter handling, which we need.
+        (-[KWQSecureTextField textView:shouldChangeTextInRange:replacementString:]): Ditto.
+        (-[KWQSearchField textView:shouldChangeTextInRange:replacementString:]): Ditto.
+
 === Safari-187 ===
 
 2005-02-17  Ken Kocienda  <kocienda@apple.com>

diff --git a/WebCore/kwq/KWQTextField.mm b/WebCore/kwq/KWQTextField.mm
index 5ec98e20b0f79389290d2770f62304fed8f16d02..2fb76802c22b25f7b348b873341ce83d811e15ac 100644 (file)
--- a/WebCore/kwq/KWQTextField.mm
+++ b/WebCore/kwq/KWQTextField.mm
@@ -587,7 +587,8 @@
 
 - (BOOL)textView:(NSTextView *)view shouldChangeTextInRange:(NSRange)range replacementString:(NSString *)string
 {
-    return [controller textView:view shouldChangeTextInRange:range replacementString:string];
+    return [controller textView:view shouldChangeTextInRange:range replacementString:string]
+        && [super textView:view shouldChangeTextInRange:range replacementString:string];
 }
 
 @end
@@ -738,7 +739,8 @@
 
 - (BOOL)textView:(NSTextView *)view shouldChangeTextInRange:(NSRange)range replacementString:(NSString *)string
 {
-    return [controller textView:view shouldChangeTextInRange:range replacementString:string];
+    return [controller textView:view shouldChangeTextInRange:range replacementString:string]
+        && [super textView:view shouldChangeTextInRange:range replacementString:string];
 }
 
 // These next two methods are the workaround for bug 3024443.
@@ -956,7 +958,8 @@
 
 - (BOOL)textView:(NSTextView *)view shouldChangeTextInRange:(NSRange)range replacementString:(NSString *)string
 {
-    return [controller textView:view shouldChangeTextInRange:range replacementString:string];
+    return [controller textView:view shouldChangeTextInRange:range replacementString:string]
+        && [super textView:view shouldChangeTextInRange:range replacementString:string];
 }
 
 @end