Reviewed by Adam Roben.
authorap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Jan 2008 20:13:07 +0000 (20:13 +0000)
committerap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Jan 2008 20:13:07 +0000 (20:13 +0000)
        <rdar://problem/5673716> fast/loader/opaque-base-url.html is failing
        <rdar://problem/5670275> fast/loader/onunload-form-submit-crash.html is failing
        <rdar://problem/5667277> fast/loader/onunload-form-submit-crash-2.html is failing

        * fast/loader/meta-refresh-vs-open.html: Changed to be more DRT-friendly.
        * platform/win/Skipped: Removed tests that were victims of the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/loader/meta-refresh-vs-open.html
LayoutTests/platform/win/Skipped

index 17e4f0292d6ed41b932d152b5d40e97127d97641..e410c3d0214634a713f87c6c901a5c7f5de09930 100644 (file)
@@ -1,3 +1,14 @@
+2008-01-09  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        <rdar://problem/5673716> fast/loader/opaque-base-url.html is failing
+        <rdar://problem/5670275> fast/loader/onunload-form-submit-crash.html is failing
+        <rdar://problem/5667277> fast/loader/onunload-form-submit-crash-2.html is failing
+
+        * fast/loader/meta-refresh-vs-open.html: Changed to be more DRT-friendly.
+        * platform/win/Skipped: Removed tests that were victims of the above.
+
 2008-01-09  Alexey Proskuryakov  <ap@webkit.org>
 
         Reviewed by Adam Roben.
index 52a58441c924cde95eba9d265bf7f385bbf35e67..2c16cc21b75f2ce2d24e11aae7ff9adbbe22ada0 100644 (file)
@@ -8,12 +8,28 @@ if (window.layoutTestController) {
 </script>
 <meta http-equiv="refresh" content="0;url=data:text/plain,You should not have been redirected here.">
 </head>
-<body onload="if (window.layoutTestController) document.write('<p>FAIL: onload</p>'); else alert('FAIL: onload');">
+<body>
 <iframe id="ifrm" src="about:blank"></iframe>
 <script>
+    document.body.onload = function() {
+        if (window.layoutTestController)
+            document.write('<p>FAIL: onload</p>');
+        else
+            alert('FAIL: onload');
+    }
+
+    // Having a subframe open should prevent refresh.
     document.getElementById("ifrm").contentDocument.open();
-    if (window.layoutTestController)
-        setTimeout("layoutTestController.notifyDone()", 500);
+
+    setTimeout(function () {
+        // Test succeeded, now remove traps and return to a state that won't confuse our test runner.
+        document.body.onload = function() {};
+        if (window.stop)
+            stop();
+        document.getElementById("ifrm").contentDocument.close();
+        if (window.layoutTestController)
+            layoutTestController.notifyDone();
+      }, 500);
 </script>
 <p>SUCCESS - shouldn't refresh or invoke onload.</p>
 </body>
index 8a483ca8c306647acb68cfe19446f29c463f4c62..ac7ea30b47dd8ad8266095d044d32a201c4112b6 100644 (file)
@@ -389,9 +389,6 @@ editing/selection/fake-drag.html
 # <rdar://5667275>
 fast/dynamic/layer-hit-test-crash.html
 
-# <rdar://5667277>
-fast/loader/onunload-form-submit-crash-2.html
-
 # <rdar://5667279> Undefined value exception
 http/tests/xmlhttprequest/XMLHttpRequestException.html
 
@@ -405,18 +402,12 @@ http/tests/security/cross-frame-access-put.html
 # <rdar://5670257> This test makes editing/selection/5131716-{2,3,4}.html fail
 editing/selection/4895428-3.html
 
-# <rdar://5670275>
-fast/loader/onunload-form-submit-crash.html
-
 # <rdar://5673685>
 fast/forms/input-readonly-autoscroll.html
 
 # <rdar://5673709>
 fast/xsl/sort-unicode.xml
 
-# <rdar://5673716>
-fast/loader/opaque-base-url.html
-
 ################################################################################
 ####################### No bugs filed about the below yet#######################
 ################################################################################