Reviewed by Eric.

        Bug 9628: [Drosera] Split Views acting oddly
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9628

        Only update the last X or Y coordinate if the new
        size was not constrained. Also adds the resize cursor to
        the body during the drag incase there is a constrained
        over drag off of the resizer element.

        * Drosera/debugger.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 239f69b879ae2009ac732caaab6b07f2fb5cc9de..529dd16b0e1ff402dde24fe05a39cba8eb740ba9 100644 (file)
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,17 @@
+2006-07-02  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Eric.
+
+        Bug 9628: [Drosera] Split Views acting oddly
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=9628
+        
+        Only update the last X or Y coordinate if the new
+        size was not constrained. Also adds the resize cursor to
+        the body during the drag incase there is a constrained 
+        over drag off of the resizer element.
+
+        * Drosera/debugger.js:
+
 2006-07-02  Mark Rowe  <opendarwin.org@bdash.net.nz>
 
         Reviewed by Alexy Proskuryakov.

diff --git a/WebKitTools/Drosera/debugger.js b/WebKitTools/Drosera/debugger.js
index 01aa097e2299f9a696f12a360ba1d0f35a6290c5..8093d3029ee3865ca752660227fd638c09b354fe 100644 (file)
--- a/WebKitTools/Drosera/debugger.js
+++ b/WebKitTools/Drosera/debugger.js
@@ -47,15 +47,6 @@ function sleep(numberMillis) {
     }
 }
 
-function columnResizerMouseOver(element) {
-    element.style.cursor = "move";
-}
-
-function columnResizerMouseOut(element) {
-
-    element.style.cursor = "arrow";
-}
-
 function headerMouseDown(element) {
     if (!isResizingColumn) 
         element.style.background = "url(glossyHeaderPressed.png) repeat-x";
@@ -69,26 +60,27 @@ function headerMouseOut(element) {
     element.style.background = "url(glossyHeader.png) repeat-x";
 }
 
-function dividerDragStart(element, dividerDrag, dividerDragEnd, event) {
+function dividerDragStart(element, dividerDrag, dividerDragEnd, event, cursor) {
     element.dragging = true;
     element.dragLastY = event.clientY + window.scrollY;
     element.dragLastX = event.clientX + window.scrollX;
     document.addEventListener("mousemove", dividerDrag, true);
     document.addEventListener("mouseup", dividerDragEnd, true);
+    document.body.style.cursor = cursor;
     event.preventDefault();
 }
 
 function sourceDividerDragStart(event) {
-    dividerDragStart(document.getElementById("divider"), dividerDrag, sourceDividerDragEnd, event);
+    dividerDragStart(document.getElementById("divider"), dividerDrag, sourceDividerDragEnd, event, "row-resize");
 }
 
 function infoDividerDragStart(event) {
-    dividerDragStart(document.getElementById("infoDivider"), infoDividerDrag, infoDividerDragEnd, event);
+    dividerDragStart(document.getElementById("infoDivider"), infoDividerDrag, infoDividerDragEnd, event, "col-resize");
 }
 
 function columnResizerDragStart(event) {
     isResizingColumn = true;
-    dividerDragStart(document.getElementById("variableColumnResizer"), columnResizerDrag, columnResizerDragEnd, event);
+    dividerDragStart(document.getElementById("variableColumnResizer"), columnResizerDrag, columnResizerDragEnd, event, "col-resize");
 }
 
 function columnResizerDragEnd(event) {
@@ -97,17 +89,18 @@ function columnResizerDragEnd(event) {
 }
 
 function infoDividerDragEnd(event) {
-    dividerDragEnd(document.getElementById("infoDivider"), infoDividerDrag, infoDividerDragEnd);
+    dividerDragEnd(document.getElementById("infoDivider"), infoDividerDrag, infoDividerDragEnd, event);
 }
 
 function sourceDividerDragEnd(event) {
-    dividerDragEnd(document.getElementById("divider"), dividerDrag, sourceDividerDragEnd);
+    dividerDragEnd(document.getElementById("divider"), dividerDrag, sourceDividerDragEnd, event);
 }
 
 function dividerDragEnd(element, dividerDrag, dividerDragEnd, event) {
     element.dragging = false;
     document.removeEventListener("mousemove", dividerDrag, true);
     document.removeEventListener("mouseup", dividerDragEnd, true);
+    document.body.style.cursor = null;
 }
 
 function columnResizerDrag(event) {
@@ -118,9 +111,10 @@ function columnResizerDrag(event) {
         var x = event.clientX + window.scrollX;
         var delta = element.dragLastX - x;
         var newWidth = constrainedWidthFromElement(variableColumn.clientWidth - delta, main);
+        if ((variableColumn.clientWidth - delta) == newWidth) // the width wasn't constrained
+            element.dragLastX = x;
         variableColumn.style.width = newWidth + "px";
         element.style.left = newWidth + "px";
-        element.dragLastX = x;
         event.preventDefault();
     }
 }
@@ -130,7 +124,6 @@ function constrainedWidthFromElement(width, element) {
         width = element.clientWidth * 0.25;
     else if (width > element.clientWidth * 0.75)
         width = element.clientWidth * 0.75;
-
     return width;
 }
 
@@ -139,7 +132,6 @@ function constrainedHeightFromElement(height, element) {
         height = element.clientHeight * 0.25;
     else if (height > element.clientHeight * 0.75)
         height = element.clientHeight * 0.75;
-
     return height;
 }
 
@@ -152,9 +144,10 @@ function infoDividerDrag(event) {
         var x = event.clientX + window.scrollX;
         var delta = element.dragLastX - x;
         var newWidth = constrainedWidthFromElement(leftPane.clientWidth - delta, main);
+        if ((leftPane.clientWidth - delta) == newWidth) // the width wasn't constrained
+            element.dragLastX = x;
         leftPane.style.width = newWidth + "px";
         rightPane.style.left = newWidth + "px";
-        element.dragLastX = x;
         event.preventDefault();
     }
 }
@@ -168,9 +161,10 @@ function dividerDrag(event) {
         var y = event.clientY + window.scrollY;
         var delta = element.dragLastY - y;
         var newHeight = constrainedHeightFromElement(top.clientHeight - delta, main);
+        if ((top.clientHeight - delta) == newHeight) // the height wasn't constrained
+            element.dragLastY = y;
         top.style.height = newHeight + "px";
         bottom.style.top = newHeight + "px";
-        element.dragLastY = y;
         event.preventDefault();
     }
 }