Reviewed by john
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
+ <http://bugs.webkit.org/show_bug.cgi?id=7165>
TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
The top level WebHTMLView is responsible for performing dragging operations, but
Reviewed by Tim O.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10661
+ http://bugs.webkit.org/show_bug.cgi?id=10661
REGRESSION: CFM plug-ins (Shockwave, SVG) are not loaded
* Plugins/WebBasePluginPackage.m:
Reviewed by Tim H.
- Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
+ Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch
* MigrateHeaders.make:
Reviewed by Anders.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
+ http://bugs.webkit.org/show_bug.cgi?id=10887
Fix build error
* MigrateHeaders.make: Remove reference to DOMEventPrivate.h.
Reviewed by Tim H.
- Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
+ Patch for http://bugs.webkit.org/show_bug.cgi?id=10870
Auto-generate DOMNode for the Objective-C bindings
* MigrateHeaders.make:
Reviewed by eseidel.
- Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10876
+ Fixes http://bugs.webkit.org/show_bug.cgi?id=10876
containsItemForURLUnicode uses matchLetter instead of
matchUnicodeLetter
Reviewed/landed by aroben.
- Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10765
+ Fixes http://bugs.webkit.org/show_bug.cgi?id=10765
Windows build busted due to std::copy usage in Vector.h
* WebKit.vcproj/WebKit.vcproj: Define _SCL_SECURE_NO_DEPRECATE to get
Reviewed by Brady.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10547
+ - fix http://bugs.webkit.org/show_bug.cgi?id=10547
REGRESSION: Links that should open in a new window open in the same window,
while opening another blank window
Reviewed by Eric.
- Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
+ Patch for http://bugs.webkit.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings
* MigrateHeaders.make:
Reviewed by Eric.
- Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
+ Patch for http://bugs.webkit.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup
* MigrateHeaders.make:
Reviewed by Darin and Tim H.
- Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
+ Patch for http://bugs.webkit.org/show_bug.cgi?id=10774
Auto-generate the Objective-C DOM Traversal bindings
* MigrateHeaders.make:
Reviewed by Darin.
- Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
+ Patch for http://bugs.webkit.org/show_bug.cgi?id=10766
Auto-generate the Objective-C DOM Events bindings
* MigrateHeaders.make:
Reviewed by Darin.
Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10714
+ http://bugs.webkit.org/show_bug.cgi?id=10714
- Added the new private DOM headers.
- Factored out the common commands into variables.
Reviewed by Darin and Tim H.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10711
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10711
Auto-generate the Objective-C DOM Stylesheet bindings
* MigrateHeaders.make:
Reviewed by Tim H.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10684
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10684
Auto-generate the Objective-C DOM CSS bindings
* MigrateHeaders.make:
Reviewed by Darin. Updated/landed by Adam.
- Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10553
+ Fixes http://bugs.webkit.org/show_bug.cgi?id=10553
Windows build fixes
* COM/WebFrame.cpp:
Reviewed by Adele.
Bug 10677: Omit "-webkit-text-security: none;" from the computed style list
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10677
+ http://bugs.webkit.org/show_bug.cgi?id=10677
* WebInspector/webInspector/inspector.js:
Reviewed by Tim H.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10669
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10669
Auto-generate the remaining Objective-C HTML DOM bindings
* MigrateHeaders.make:
Reviewed by Darin.
- WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
+ WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10666
Password: Disallow Spelling, Font, Speech, and Writing Direction context menu
* DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
Reviewed by Tim H.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10653
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10653
Auto-generate another 20 Objective-C DOM HTML bindings
* MigrateHeaders.make:
Reviewed by Hyatt.
- WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
+ WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields
* WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
Reviewed by Tim H.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10640
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10640
Auto-generate 10 more Objective-C DOM HTML bindings
* WebKit.xcodeproj/project.pbxproj:
Reviewed by Darin.
WebKit part of fix for:
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
+ http://bugs.webkit.org/show_bug.cgi?id=10576
Disallow copy from new password fields
* WebView/WebHTMLView.m:
Reviewed by Eric and Tim H.
Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10634
+ http://bugs.webkit.org/show_bug.cgi?id=10634
Remove the check for canShowFile: from _web_bestURL: since
it shouldn't be concerned with whether or not the view
Reviewed by Tim H.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10628
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10628
Auto-generate the remaining Objective-C DOM bindings
Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
Reviewed by John Sullivan.
Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
+ <http://bugs.webkit.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox
* Plugins/WebBaseNetscapePluginView.h:
Reviewed by Tim H.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=4624
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=4624
WebCore needs autogenerated Obj-C DOM bindings
First round of auto-generated Objective C DOM bindings, starting
Reviewed by Adele.
- fix assertion which I accidentally changed to one that sometimes fails
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10531
+ http://bugs.webkit.org/show_bug.cgi?id=10531
* Loader/WebDocumentLoadState.m:
(-[WebDocumentLoadState dealloc]):
Reviewed by Darin Adler.
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=8980>
+ <http://bugs.webkit.org/show_bug.cgi?id=8980>
ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])
<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)
Reviewed by Tim H.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
+ http://bugs.webkit.org/show_bug.cgi?id=10394
Bug 10394: WebKit Release and Production configurations should enable dead code stripping
* WebKit.xcodeproj/project.pbxproj:
Reviewed by Tim H.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
+ http://bugs.webkit.org/show_bug.cgi?id=10384
Bug 10384: Switch to DWARF for Release configuration
* WebKit.xcodeproj/project.pbxproj:
Reviewed by Darin.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10314
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10314
WebUnarchivingState archivedResourceForURL: doesn't work
* WebView/WebUnarchivingState.m:
Reviewed by Tim Omernick.
- fixed REGRESSION: crash when leaving youtube page while movie is still loading
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10398
+ http://bugs.webkit.org/show_bug.cgi?id=10398
* Loader/WebNetscapePlugInStreamLoader.m:
(-[WebNetscapePlugInStreamLoader initWithStream:view:]): Set the frame loader for this stream.
Reviewed by Darin.
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
+ <http://bugs.webkit.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)
* Plugins/WebBaseNetscapePluginView.m:
Reviewed by Darin.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10192
Make WebCore (and friends) compile with -Wshorten-64-to-32
* Adds 'f' to float literals where expecting a float.
Reviewed by Darin.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10176
Make WebCore compile with -Wundef
* Adds -Wundef flag to Xcode project
Reviewed by Darin.
Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10200
+ http://bugs.webkit.org/show_bug.cgi?id=10200
Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
suspendProcessIfPaused was being called during a DO call into Safari.
Reviewed by Darin.
- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=10159>
+ Fixes <http://bugs.webkit.org/show_bug.cgi?id=10159>
"REGRESSION: delegate returning no menu elements crashes webkit"
No automated test, because there's no way to programmatically open a context menu,
Reviewed by Tim Hatcher.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=10168
+ - http://bugs.webkit.org/show_bug.cgi?id=10168
add a first cut at a Metrics pane to the inspector
* WebInspector/webInspector/inspector.css: Add styles for the new metrics pane.
Reviewed by Tim Hatcher.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=10163
+ - http://bugs.webkit.org/show_bug.cgi?id=10163
some improvements for the inspector
* WebInspector/WebInspector.m:
Reviewed by Darin.
- - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080
+ - patch for http://bugs.webkit.org/show_bug.cgi?id=10080
Adopt pedantic changes from the Unity project to improve
cross-compiler compatibility
Reviewed by John Sullivan.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9984
+ - fix http://bugs.webkit.org/show_bug.cgi?id=9984
ASSERTION FAILURE: _private->mouseDownEvent != nil
(WebKit/WebView/WebHTMLView.m:4863 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask])
Reviewed by Geoff.
- fix <rdar://problem/4609195> Help Viewer loads empty window (not getting didFailLoadingWithError: callback)
- (without re-introducing http://bugzilla.opendarwin.org/show_bug.cgi?id=10062 )
+ (without re-introducing http://bugs.webkit.org/show_bug.cgi?id=10062 )
* WebView/WebLoader.h:
* WebView/WebMainResourceLoader.m:
Reviewed by Darin.
- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10009
+ Fix http://bugs.webkit.org/show_bug.cgi?id=10009
REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)
* WebView/WebView.m:
Reviewed by Maciej.
Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9686
+ http://bugs.webkit.org/show_bug.cgi?id=9686
WebKit portion of the fix.
Rolling out r15572.
Bug 10062: REGRESSION: dom/xhtml/level2/html/HTMLIFrameElement11.xhtml asserts/crashes
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10062
+ http://bugs.webkit.org/show_bug.cgi?id=10062
2006-07-21 Timothy Hatcher <timothy@apple.com>
Reviewed by levi
Rolled the first fix for:
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
+ <http://bugs.webkit.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
back in and removed the call to _clearSelectionInOtherFrames from
-[WebHTMLView becomeFirstResponder] to fix the bug.
Reviewed by John Sullivan.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9928
+ - fix http://bugs.webkit.org/show_bug.cgi?id=9928
REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix)
* WebView/WebHTMLView.m:
Reviewed by levi & thatcher
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
+ <http://bugs.webkit.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
* WebView/WebHTMLView.m:
Reviewed by Adele.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9625
+ - fix http://bugs.webkit.org/show_bug.cgi?id=9625
<rdar://problem/4604703>
REGRESSION: Focus not removed from password field after ctrl-click in text field
Reviewed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9795
+ - fix http://bugs.webkit.org/show_bug.cgi?id=9795
REGRESSION: Crash in [WebHTMLView(WebPrivate)
_updateMouseoverWithEvent:]
- and http://bugzilla.opendarwin.org/show_bug.cgi?id=9850
+ and http://bugs.webkit.org/show_bug.cgi?id=9850
REGRESSION: Assertion failure (SHOULD NEVER BE REACHED) in -
[WebHTMLView(WebPrivate) removeTrackingRect:]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9624
+ http://bugs.webkit.org/show_bug.cgi?id=9624
REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
Reviewed by Timothy.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9868
+ http://bugs.webkit.org/show_bug.cgi?id=9868
Applications shown in Drosera's "Attach" window remain after exit
* DefaultDelegates/WebScriptDebugServer.m:
Reviewed by Geoff.
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
+ <http://bugs.webkit.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element
* Plugins/WebBaseNetscapePluginView.h:
Reviewed by levi & thatcher
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
+ <http://bugs.webkit.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
* WebView/WebHTMLView.m:
Reviewed by Tim O.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=7808
+ - http://bugs.webkit.org/show_bug.cgi?id=7808
Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL
* Plugins/WebNetscapePluginStream.m:
Reviewed by John Sullivan.
- - fix <rdar://problem/4621541>, aka <http://bugzilla.opendarwin.org/show_bug.cgi?id=9838>
+ - fix <rdar://problem/4621541>, aka <http://bugs.webkit.org/show_bug.cgi?id=9838>
REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache
* WebView/WebDataSource.m:
Reviewed by Darin.
Bug 9820: Move new DOM API that has been through API review to public headers
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9820
+ http://bugs.webkit.org/show_bug.cgi?id=9820
* Misc/WebElementDictionary.m: include DOMExtensions.h
* Misc/WebNSViewExtras.m: include DOMExtensions.h
Reviewed by Kevin.
Bug 9818: move new UIDelegate API that has been through API review to public headers
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9818
+ http://bugs.webkit.org/show_bug.cgi?id=9818
<rdar://problem/4387541> API: Remove webView:setContentRect: & webViewContentRect: delegate methods?
The fix for 4310363 removed the only use of webViewContentRect: in our code. webView:setContentRect:
Reviewed by Darin.
Bug 9814: Move new WebView API that has been through API review to public headers
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9814
+ http://bugs.webkit.org/show_bug.cgi?id=9814
* WebView/WebView.h:
* WebView/WebView.m:
Reviewed by Maciej.
Bug 9487: The XPath section should be removed and/or moved.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9487
+ http://bugs.webkit.org/show_bug.cgi?id=9487
* WebInspector/webInspector/inspector.css:
* WebInspector/webInspector/inspector.html:
Reviewed by Maciej.
Bug 5312: comments aren't available via DOM
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
+ http://bugs.webkit.org/show_bug.cgi?id=5312
Makes the Web Inspector show comment node contents.
Reviewed by Darin.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=9572
+ - http://bugs.webkit.org/show_bug.cgi?id=9572
Add application/xhtml+xml to the Accept header
* WebView/WebFrame.m:
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
+ http://bugs.webkit.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array
* WebCoreSupport/WebFrameBridge.m:
Reviewed by Maciej.
Bug 9731: [Drosera] crash when trying to access the scope chain
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9731
+ http://bugs.webkit.org/show_bug.cgi?id=9731
Because of <rdar://problem/4608404> the WebScriptObject, _globalObj, that
WebCoreScriptDebugger holds is unprotected each time the page changes.
Bug 9732: [Drosera] calling removeListener to many times will cause
WebKit's listener count to underflow/wraparound
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9732
+ http://bugs.webkit.org/show_bug.cgi?id=9732
Adds a check to make sure the listener was in our listeners set before
decrementing the global listener count. Also checks for nil in addListner
Reviewed by Maciej.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=8210
+ - http://bugs.webkit.org/show_bug.cgi?id=8210
Conditional XMLHttpRequest gets should pass 304 responses unchanged
Test: http/tests/xmlhttprequest/cache-override.html
Reviewed by justin
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
+ http://bugs.webkit.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent
Added undo action strings and enum values
Reviewed by Darin.
Bug 9574: Drosera should show inline scripts within the original HTML
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9574
+ http://bugs.webkit.org/show_bug.cgi?id=9574
* Adds a new version of the didParseSource delegate callback with base line number.
* Adds a new delegate callback for when a script fails to parse.
Reviewed by Darin.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=9418
+ - http://bugs.webkit.org/show_bug.cgi?id=9418
WebKit will not build when Space exists in path
* WebKit.xcodeproj/project.pbxproj: Enclose search paths in quotes.
Reviewed by Geoff.
script debugger should only attach to JavaScriptCore when there are listeners
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9552
+ http://bugs.webkit.org/show_bug.cgi?id=9552
Attaches the debugger to all WebFrames when the first listener
is added. Detaches when the last listener is removed.
Reviewed by Darin.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=5499
+ - http://bugs.webkit.org/show_bug.cgi?id=5499
Page reload does not send any cache control headers
* WebView/WebFrame.m:
Reviewed by Maciej.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9452
+ - fix http://bugs.webkit.org/show_bug.cgi?id=9452
Assertion failure in -[WebFramePrivate setProvisionalDataSource:]
* WebView/WebFrame.m:
Reviewed by xenon.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=9479
+ - http://bugs.webkit.org/show_bug.cgi?id=9479
Disassociate the inspector from the frame when it detaches from its parent
* WebInspector/WebInspector.m:
Reviewed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9466
+ - fix http://bugs.webkit.org/show_bug.cgi?id=9466
Assertion failure when dragging an image from the document into Safari's address bar
* WebView/WebFrameView.m:
Reviewed by justin
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
+ <http://bugs.webkit.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)
* English.lproj/Localizable.strings:
Reviewed by Geoff.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
+ http://bugs.webkit.org/show_bug.cgi?id=9406
REGRESSION: fix for bug 9390 broke two layout tests
* Plugins/WebPluginDatabase.h:
Reviewed by Tim H.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8672
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8672
Red outline from web inspector reappears after inspector is closed
* WebInspector/WebInspector.m:
Reviewed by Tim.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
+ http://bugs.webkit.org/show_bug.cgi?id=9390
Move full-frame plugins to WebCore
* Plugins/WebBaseNetscapePluginStream.h:
2006-06-10 Graham Dennis <Graham.Dennis@gmail.com>
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=9384>
+ <http://bugs.webkit.org/show_bug.cgi?id=9384>
WebView's initWithCoder: method does not set useBackForwardList
correctly
Reviewed by levi
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
+ <http://bugs.webkit.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)
* WebView/WebFrame.m:
Reviewed by Justin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8616
REGRESSION: TinyMCE: Crash on Undo
* WebView/WebHTMLView.m:
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
+ http://bugs.webkit.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
* Misc/WebNSURLExtras.m:
Reviewed by Anders.
- fixed "REGRESSION: Can't order from Pizza Hut (ToT, 05/24/06)"
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9103
+ http://bugs.webkit.org/show_bug.cgi?id=9103
* WebView/WebDataSource.m:
(-[WebDataSource _willSendRequest:forResource:redirectResponse:]): Set up the
Reviewed by Anders.
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=8347>
+ <http://bugs.webkit.org/show_bug.cgi?id=8347>
REGRESSION: Flash movie audible but not visible until window is resized
* Plugins/WebNetscapePluginDocumentView.m:
Reviewed by Anders.
Bug 9018: REGRESSION: resizing the top area of the inspector does not grow as expected
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9018
+ http://bugs.webkit.org/show_bug.cgi?id=9018
Use clientHeight now that offsetHeight includes the border and padding.
clientHeight should have been used initially.
Reviewed by Eric.
- remove loading-related code from WebView
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8981
+ http://bugs.webkit.org/show_bug.cgi?id=8981
* Plugins/WebNetscapePluginStream.m:
(-[WebNetscapePlugInStreamLoader didFinishLoading]):
Reviewed by Hyatt.
- WebKit part of initial checkin to prepare for http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
+ WebKit part of initial checkin to prepare for http://bugs.webkit.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>
* WebView/WebHTMLView.m:
Reviewed by Tim Hatcher.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8945 (REGRESSION: Scrolling is very slow when dragging
+ http://bugs.webkit.org/show_bug.cgi?id=8945 (REGRESSION: Scrolling is very slow when dragging
the thumb)
Rolled out one of my tweaks to the window display throttle hack (remember the last flush time instead
Reviewed by Anders.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=8940
+ - http://bugs.webkit.org/show_bug.cgi?id=8940
remove extra copy of image code
* English.lproj/StringsNotToBeLocalized.txt: Updated for many recent changes.
Reviewed by Hyatt.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8898
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8898
REGRESSION: Attempting to right-click image in own tab on website causes crash
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8919
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8919
REGRESSION: image could not be dragged, subsequent click-drag activity caused crash
These fixes may become obsolete when Anders lands his standalone image viewer
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8921
+ http://bugs.webkit.org/show_bug.cgi?id=8921
Use WebCore to render full-frame images
* WebCoreSupport/WebFrameBridge.m:
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8913
+ http://bugs.webkit.org/show_bug.cgi?id=8913
REGRESSION: Can view source for text files
* WebView/WebDocumentPrivate.h:
Reviewed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8739
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8739
Crash in RenderTableSection::paint due to manipulating DOM on resize
Manual test: manual-tests/dom-manipulation-on-resize.html
Reviewed by Brady.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8876
+ http://bugs.webkit.org/show_bug.cgi?id=8876
- move most private WebDataSource methods to uninstalled header
I put the declarations for the ones only used in WebKit in WebDataSourceInternal.h
Reviewed by John Sullivan.
<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>
+ <http://bugs.webkit.org/show_bug.cgi?id=8740>
Improvement to my NSWindow display throttle hack. Remember the last flush time instead of the last display time.
Our goal is to never draw less than 1/60th of a second after the window is flushed in order to avoid blocking on
Reviewed by Darin.
Bug 8856: Web Inspector should show the Xpath for the selected node
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8856
+ http://bugs.webkit.org/show_bug.cgi?id=8856
Adds an Xpath area to the Node panel.
Fixes <rdar://problem/4411845> lots of SPOD trying to scroll through
Markup & Content inspecting body at apple.com (6614)
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6614
+ http://bugs.webkit.org/show_bug.cgi?id=6614
Removed the Markup & Content pane when viewing a element.
This pane was not that useful and made the inspector really slow
Reviewed by Timothy.
- Patch for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8810>
+ Patch for <http://bugs.webkit.org/show_bug.cgi?id=8810>
Bug 8810: Scrollbars in WebInspector rendered incorrectly
* WebInspector/webInspector/inspector.css:
Reviewed by Darin.
<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>
+ <http://bugs.webkit.org/show_bug.cgi?id=8740>
* Misc/WebNSWindowExtras.h:
* Misc/WebNSWindowExtras.m:
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8808
+ http://bugs.webkit.org/show_bug.cgi?id=8808
WebCore should handle text files
* WebKit.exp:
Reviewed by Anders.
Bug 8804: Inspector should support searching by Xpath query
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8804
+ http://bugs.webkit.org/show_bug.cgi?id=8804
* WebInspector/WebInspector.m:
(-[WebInspector _refreshSearch]):
- refactor things so that WebKit doesn't save a WebResource for every loaded URL,
but rather retrieves the data from the WebCore cache as needed.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8802
+ http://bugs.webkit.org/show_bug.cgi?id=8802
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
Reviewed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8594
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8594
REGRESSION: Exception on closing a page containing (just) an mp3
Test: plugins/pluginDocumentView-deallocated-dataSource.html
Reviewed by Eric.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=8677
+ - http://bugs.webkit.org/show_bug.cgi?id=8677
REGRESSION: wkSetUpFontCache() may be called before the SPIs are connected.
I don't know how reproduce this without one of Rosyna's hacks installed, so I
Reviewed by Tim O.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6988
+ - fix http://bugs.webkit.org/show_bug.cgi?id=6988
REGRESSION: Display correct context menus for new text fields
* WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]):
Reviewed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8658
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8658
Assertion failure in -[WebPluginContainerCheck _isForbiddenFileLoad]
(bridge is null) when clicking QuickTime object with href
Reviewed by Maciej.
Bug 8577: [TabBarView _web_superviewOfClass:stoppingAtClass:]
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8577
+ http://bugs.webkit.org/show_bug.cgi?id=8577
Added back _web_superviewOfClass:stoppingAtClass:.
This method was removed in r14032 (bug 8562), but Safari 2.0 still uses it.
Reviewed by darin.
Misc. style cleanup.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8643
+ http://bugs.webkit.org/show_bug.cgi?id=8643
* Misc/WebIconDatabase.m:
(-[NSMutableDictionary iconForURL:withSize:cache:]):
Reviewed by Geoff.
<rdar://problem/4525105> Repro TOT crash in [WebBaseNetscapePluginView dealloc] at coachella.com
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=8564> crashed when closing a tab
+ <http://bugs.webkit.org/show_bug.cgi?id=8564> crashed when closing a tab
* WebView/WebFrame.m:
(-[WebFramePrivate dealloc]):
Reviewed by Anders.
- Remove use of _webSuperviewOfClass: and related
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8562
+ http://bugs.webkit.org/show_bug.cgi?id=8562
I removed all use of these, now objects get at each other via
actual pointers, not using the view hierarchy. However, I left two
Reviewed by Darin.
- push WebFileButton and WebStringTruncator code down to WebCore
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8552
+ http://bugs.webkit.org/show_bug.cgi?id=8552
* Misc/WebStringTruncator.m:
(+[WebStringTruncator centerTruncateString:toWidth:]):
Reviewed by Eric.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8514
+ http://bugs.webkit.org/show_bug.cgi?id=8514
Bug 8514: Web Inspector hides when the app is in the background
Makes the inspector not hide in the background. Since the inspector is a floating panel
Reviewed by Darin.
- - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8181
+ - Fix for http://bugs.webkit.org/show_bug.cgi?id=8181
REGRESSION: After tabbing in page's field, attempting to tab from Google toolbar search to page fails on first try
Test: manual-tests/tabbing-input-google.html
Reviewed by Darin.
WebKit part of:
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8276
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8276
REGRESSION (NativeTextField): Pasting a Finder item into a text field results in
a file: URL being pasted instead of just the file name
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8283
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8283
REGRESSION: File's path doesn't appear after dragging file into input field
* WebView/WebHTMLView.m:
Reviewed by Adele.
- - WebKit part of http://bugzilla.opendarwin.org/show_bug.cgi?id=8505
+ - WebKit part of http://bugs.webkit.org/show_bug.cgi?id=8505
eliminate WebCoreGraphics bridge, demonstrate new SystemInterface technique
* WebCoreSupport/WebGraphicsBridge.h: Removed.
Reviewed by Timothy.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8442
+ http://bugs.webkit.org/show_bug.cgi?id=8442
Bug 8442: improvements to Cocoa bindings support in WebView - code simplification
Removes the WebController class added earlier; changes NSTreeController and
Reviewed by Timothy.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6635
+ http://bugs.webkit.org/show_bug.cgi?id=6635
Bug 6635: Crash selecting inspector nodes for tabs that aren't foremost
Stop observing window will close notifications before we tell the highlight window to close,
Reviewed by Timothy.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6637
+ http://bugs.webkit.org/show_bug.cgi?id=6637
Bug 6637: selecting node in Inspector after closing window crashes Safari
When the window the Web Inspector was inspecting is closed, the inspector goes into its
Reviewed by Darin.
- - WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8324
+ - WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=8324
REGRESSION: textarea :focus not applied immediately
* WebCoreSupport/WebFrameBridge.m:
Reviewed by Timothy.
Bug 8389: support for Cocoa bindings - binding an NSTreeController to the WebView's DOM
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8389
+ http://bugs.webkit.org/show_bug.cgi?id=8389
Added a controller class, WebController, that is a subclass of
NSTreeController that has a new outlet/binding for the WebView.
Reviewed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8100
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8100
REGRESSION (NativeTextField): Right-aligned and RTL text jitters in new text fields
* WebCoreSupport/WebTextRenderer.m:
Reviewed by Adele Peterson.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=8260
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=8260
REGRESSION: Assertion failure: ![_private->iconsToSaveWithURLs containsObject:iconURLString]
in WebIconDatabase.m:695-[WebIconDatabase(WebInternal) _retainIconForIconURLString:]
Reviewed by Eric.
- start on factoring WebArchive unpacking more into a separate class.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8208
+ http://bugs.webkit.org/show_bug.cgi?id=8208
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDataSource.m:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
+ fix http://bugs.webkit.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed
* WebView/WebMainResourceLoader.m:
- fixed <rdar://problem/4198619> REGRESSION: tabbing through links fails after hitting text field w/ sys's "tab to all controls" off
- fixed <rdar://problem/4463760> REGRESSION: Can't tab from old text field (like password fields) to new text field (6811)
- (http://bugzilla.opendarwin.org/show_bug.cgi?id=6811)
+ (http://bugs.webkit.org/show_bug.cgi?id=6811)
- fixed tab and shift tab don't select the right things
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5685
+ http://bugs.webkit.org/show_bug.cgi?id=5685
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge willMakeFirstResponderForNodeFocus]): New method
Reviewed by Maciej.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8105
+ - fix http://bugs.webkit.org/show_bug.cgi?id=8105
REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word
Test: fast/forms/input-text-option-delete.html
Reviewed by Maciej, landed by ap.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
+ http://bugs.webkit.org/show_bug.cgi?id=7739
REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]
Tests: http/tests/misc/acid2.html, http/tests/misc/acid2-pixel.html
Reviewed by darin
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
+ http://bugs.webkit.org/show_bug.cgi?id=6989
REGRESSION: Plain-text mode needed for contenteditable area used in new text field
* WebView/WebHTMLView.m:
Reviewed by darin
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
+ <http://bugs.webkit.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink
* English.lproj/Localizable.strings:
2006-03-21 Darin Adler <darin@apple.com>
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3784
+ - fix http://bugs.webkit.org/show_bug.cgi?id=3784
<rdar://problem/4483827> JavaScript save dialog disappears right away (sheet triggers blur event) (3784)
* WebView/WebHTMLView.m:
Reviewed by Darin.
- - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6813
+ - Fix for http://bugs.webkit.org/show_bug.cgi?id=6813
elementAtPoint needs to return input element when clicking on new text field
* WebView/WebDocumentInternal.h: Added elementAtPoint:allowShadowContent:
Reviewed by Darin, landed by Beth.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7693
+ - fix http://bugs.webkit.org/show_bug.cgi?id=7693
WebKit relies on unpredictable timing for onload events
* WebView/WebDataSource.m:
Reviewed by Hyatt.
WebKit part of fix for:
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
+ http://bugs.webkit.org/show_bug.cgi?id=7797
Can't set background color on new text fields
Added function to draw bezeled text field without drawing background.
Reviewed by Darin.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=7656
+ - http://bugs.webkit.org/show_bug.cgi?id=7656
Query string always appended to Flash URLs, instead of being replaced.
* Misc/WebNSURLExtras.h: Added _webkit_URLByRemovingResourceSpecifier.
Reviewed by Anders.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7655
+ - fix http://bugs.webkit.org/show_bug.cgi?id=7655
unwanted output while running layout tests
* WebView/WebDataSourcePrivate.h:
<rdar://problem/4411822> wrong element shown in Inspector inspecting main image at apple.com
<rdar://problem/4411908> in the Web Inspector, state of disclosure triangles should be preserved after search
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
+ http://bugs.webkit.org/show_bug.cgi?id=6616
Bug 6616: Double-clicking on a search result seems broken
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
+ http://bugs.webkit.org/show_bug.cgi?id=6709
Bug 6709: TypeError: Value undefined (result of expression treeScrollbar.refresh) is not object.
Code clean up and move more code into JavaScript.
Reviewed by Darin.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=7540
+ - http://bugs.webkit.org/show_bug.cgi?id=7540
REGRESSION: frequent cache-related crashes
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=7393
+ - http://bugs.webkit.org/show_bug.cgi?id=7393
A stale comment about XMLHttpRequest responses being never cached
* WebCoreSupport/WebFrameBridge.m: Don't call setHTTPHeader if the method is GET.
Reviewed by Darin.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=3812
+ - http://bugs.webkit.org/show_bug.cgi?id=3812
XMLHttpRequest: PUT, DELETE, HEAD and all other methods but POST actually do a GET.
All WebKit changes are to use the method parameter passed from WebCore.
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
+ http://bugs.webkit.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary
<rdar://problem/2952761> moving the mouse around eats more CPU than I would expect (7450)
Reviewed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7293
+ - fix http://bugs.webkit.org/show_bug.cgi?id=7293
REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit
The crash happened because an empty frame did not have a document.
Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this.
- - WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6831
+ - WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=6831
contentEditable outline darkens as caret moves
* WebCoreSupport/WebGraphicsBridge.m:
Reviewed by darin
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
+ <http://bugs.webkit.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree
Added a UI delegate method so that DumpRenderTree can perform dragging on its own.
Reviewed by Hyatt.
- factor WebArchive creation code out of other classes into new WebArchiver
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7208
+ http://bugs.webkit.org/show_bug.cgi?id=7208
* DOM/WebDOMOperations.m:
(-[DOMNode webArchive]):
Reviewed by John Sullivan.
- - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7171
+ - Fix http://bugs.webkit.org/show_bug.cgi?id=7171
No description in WebKitErrors.m for WebKitErrorPlugInWillHandleLoad
* English.lproj/Localizable.strings: Added new UI_STRING().
Original patch by Graham Dennis, reviewed by me:
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
+ <http://bugs.webkit.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate
Changes made by me, reviewed by thatcher:
Reviewed by Darin.
- - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3527
+ - Fix http://bugs.webkit.org/show_bug.cgi?id=3527
Allow Safari to open postscript files in browser windows as well
* WebView/WebPDFRepresentation.m:
Reviewed by Timothy.
Convert JavaScript objects to appropriate AppleScript types, instead of only strings
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7012
+ http://bugs.webkit.org/show_bug.cgi?id=7012
Tests: fast/AppleScript/*
Reviewed by Eric.
- fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these"
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7125
+ http://bugs.webkit.org/show_bug.cgi?id=7125
- fixed "onload event never called for iframe element with emtpy or about:blank src"
- http://bugzilla.opendarwin.org/show_bug.cgi?id=3609
+ http://bugs.webkit.org/show_bug.cgi?id=3609
* WebCoreSupport/WebFrameBridge.h:
* WebCoreSupport/WebFrameBridge.m:
- shuffle things around so that WebFrame no longer has a WebView backpointer, the backpointer is
at the bridge level.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7093
+ http://bugs.webkit.org/show_bug.cgi?id=7093
* WebCoreSupport.subproj/WebFrameBridge.h:
* WebCoreSupport.subproj/WebFrameBridge.m:
- change JavaScript collector statistics calls to use HashCountedSet instead
of CFSet; other misc cleanup
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7072
+ http://bugs.webkit.org/show_bug.cgi?id=7072
* Misc.subproj/WebCoreStatistics.h:
* Misc.subproj/WebCoreStatistics.m:
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6631
+ http://bugs.webkit.org/show_bug.cgi?id=6631
Inspector window has inappropriate maximum height
* WebInspector.subproj/WebInspector.m:
Reviewed by Timothy Hatcher.
- - http://bugzilla.opendarwin.org/show_bug.cgi?id=6594
+ - http://bugs.webkit.org/show_bug.cgi?id=6594
Web Inspector: finish node attributes
* WebInspector.subproj/webInspector/inspector.css:
To always enable enter the following in the Terminal (change the bundle id to affect other WebKit apps):
defaults write com.apple.Safari WebKitEnableInspectElementContextMenuItem -bool true
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6571
+ http://bugs.webkit.org/show_bug.cgi?id=6571
* English.lproj/Localizable.strings:
* English.lproj/StringsNotToBeLocalized.txt: reorder of the entries
Reviewed by Darin.
- - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6531
+ - Fix http://bugs.webkit.org/show_bug.cgi?id=6531
document.cookie="killmenothing" doesn't set the cookie
* WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
in onUnload event handler causes crash in
-[WebDataSource(WebPrivate) _commitIfReady:].)
- - Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=6331
+ - Fixes http://bugs.webkit.org/show_bug.cgi?id=6331
REGRESSION: form events don't fire after back/forward navigation,
due to inconsistent load state
Affects many layout tests (when running with primary Russian language).
- - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4759
+ - Fix http://bugs.webkit.org/show_bug.cgi?id=4759
'ex' length unit calculation (Some layout tests fail if the system primary language is Russian)
* WebCoreSupport.subproj/WebTextRenderer.m:
Test: fast/text/atsui-small-caps-punctuation-size.html
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6397
+ - fix http://bugs.webkit.org/show_bug.cgi?id=6397
ATSUI small caps use small punctuation
* WebCoreSupport.subproj/WebTextRenderer.m:
Reviewed by Darin.
- - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6361
+ - Fixed http://bugs.webkit.org/show_bug.cgi?id=6361
Add plugin support to DumpRenderTree
* WebKit.exp: export WebPluginDatabase class, which DumpRenderTree
Reviewed by Darin.
- move frame management and finding code from WebKit to WebCore
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6368
+ http://bugs.webkit.org/show_bug.cgi?id=6368
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView loadPluginRequest:]): Set frame name straight on the bridge,
Reviewed by Darin.
- - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6357
+ - Fix http://bugs.webkit.org/show_bug.cgi?id=6357
REGRESSION: iframe and target is broken
* WebView.subproj/WebFrame.m:
Reviewed by Eric.
- moved frame traversal logic from WebFrame to WebBridge
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6341
+ http://bugs.webkit.org/show_bug.cgi?id=6341
To do this, I had to invert the ownership so that WebBridge now
owns WebFrame instead of vice versa. As a result, WebView now owns
Test: fast/text/justified-text-rect.html
- WebKit part of fix for
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5461
+ http://bugs.webkit.org/show_bug.cgi?id=5461
Text width measured incorrectly when text-align: justify
* WebCoreSupport.subproj/WebTextRenderer.m:
Reviewed by Eric, committed by Maciej.
- - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6288
+ - fix for http://bugs.webkit.org/show_bug.cgi?id=6288
HEAD build broken 12/29/2005
* WebCoreSupport.subproj/WebTextRenderer.m:
Reviewed by Eric.
- finished frame traversal cleanup
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
+ http://bugs.webkit.org/show_bug.cgi?id=6293
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge childFrames]): Removed (this was unused)
Reviewed by Darin.
- abstract frame traversal in WebFrame more
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6283
+ http://bugs.webkit.org/show_bug.cgi?id=6283
Rewrote most of the frame traversal code in WebFrame to use DOM-style
first/last/next/previous methods, to abstract access better in preparation
Test: fast/text/atsui-spacing-features.html
- WebKit part of fix for
- http://bugzilla.opendarwin.org/show_bug.cgi?id=3922
+ http://bugs.webkit.org/show_bug.cgi?id=3922
Variable word/letter spacing and full justification not supported for
ATSUI-rendered text
Reviewed by Maciej, landed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4844
+ - fix http://bugs.webkit.org/show_bug.cgi?id=4844
Render "simple" Hebrew using the CG codepath
* WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Exclude Hebrew letters and maqaf.
Reviewed by Geoff
- Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6241
+ http://bugs.webkit.org/show_bug.cgi?id=6241
* WebCoreSupport.subproj/WebBridge.h:
* WebCoreSupport.subproj/WebBridge.m:
Reviewed by Hyatt.
- fixed REGRESSION: world leak of WebDataSource
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6242
+ http://bugs.webkit.org/show_bug.cgi?id=6242
* WebView.subproj/WebDataSource.m:
(-[WebDataSource _stopLoading]): don't retain self until after
- rearrange some code in WebDataSource so that more of the frame traversal logic
is in WebFrame, in preparation for moving it down to WebBridge.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6239
+ http://bugs.webkit.org/show_bug.cgi?id=6239
* WebView.subproj/WebDataSource.m:
(-[WebDataSource _archiveWithMarkupString:nodes:]): Assert that the
Reviewed by justin
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
+ <http://bugs.webkit.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text
* WebView.subproj/WebHTMLView.m:
Reviewed by Darin Adler.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6146
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=6146
(REGRESSION: Bold font used for Google search result pages is too thick)
This is a problem with a particular font that was installed by Microsoft Office X. Though the
- push more of frame lookup and management from WebView to
WebFrame, this is in preparation for shifting this to WebCore
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6163
+ http://bugs.webkit.org/show_bug.cgi?id=6163
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge closeWindowSoon]): Adjust for change to WebFrameNamespaces
Reviewed by Darin, committed by Adele.
- fix deployment builds broken by the ATSUI multiple renderers patch
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6153
+ http://bugs.webkit.org/show_bug.cgi?id=6153
* WebCoreSupport.subproj/WebTextRenderer.m:
(createATSULayoutParameters): Assign initial values, which will never be used,
Test: fast/text/atsui-multiple-renderers.html
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6139
+ - fix http://bugs.webkit.org/show_bug.cgi?id=6139
ATSUI code path should implement small caps, synthetic bold and oblique and correct metrics for fallback fonts
* WebCoreSupport.subproj/WebTextRenderer.m:
Test: fast/text/atsui-kerning-and-ligatures.html
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6137
+ - fix http://bugs.webkit.org/show_bug.cgi?id=6137
Disable kerning and some ligatures in the ATSUI code path
* WebCoreSupport.subproj/WebTextRenderer.m:
Test: fast/text/should-use-atsui.html
- - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6132
+ - fix for http://bugs.webkit.org/show_bug.cgi?id=6132
Incorrect selection highlighting for ATSUI text when selected range is "CG-safe"
* WebCoreSupport.subproj/WebTextRenderer.m:
Reviewed and landed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5479
+ - fix http://bugs.webkit.org/show_bug.cgi?id=5479
Can't select text with RTL override rendered by ATSUI
* WebCoreSupport.subproj/WebTextRenderer.m:
Reviewed and landed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4680
+ - fix http://bugs.webkit.org/show_bug.cgi?id=4680
WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange "not yet implemented"
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]):
Reviewed and landed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6090
+ - fix http://bugs.webkit.org/show_bug.cgi?id=6090
REGRESSION: Assertion failure when choosing Copy from a WebImageView's contextual menu
* WebView.subproj/WebImageView.m:
Reviewed by Darin.
- remove the dead _frameForDataSource: method (WebDataSource now knows its WebFrame)
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6072
+ http://bugs.webkit.org/show_bug.cgi?id=6072
* WebView.subproj/WebView.m:
* WebView.subproj/WebViewPrivate.h:
Reviewed and checked in by John Sullivan.
- Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6053
+ Fix for: http://bugs.webkit.org/show_bug.cgi?id=6053
WebIconDatabase returns the Accessibility Verifier app icon instead of
a generic document icon
Reviewed by John Sullivan.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6032
+ - fix http://bugs.webkit.org/show_bug.cgi?id=6032
REGRESSION: Uncaught exception when image is dragged out of webpage
* WebView.subproj/WebHTMLView.m:
Reviewed by Eric.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5689
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=5689
add support for CSS "custom cursors" (cursor images)
* WebCoreSupport.subproj/WebImageRenderer.h: Remove declaration of TIFFRepresentation and
Reviewed by Maciej, landed by Darin.
- - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5878
+ - fix http://bugs.webkit.org/show_bug.cgi?id=5878
REGRESSION (WebTextRenderer.m r1.201): pointToOffset always takes the CG code path
* WebCoreSupport.subproj/WebTextRenderer.m:
Reviewed by darin. Committed by eseidel.
- Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=4726
+ Fix for: http://bugs.webkit.org/show_bug.cgi?id=4726
Drop of multiple non-image file URLs only yields one item
* WebView.subproj/WebHTMLView.m:
Reviewed by Darin. Committed by Maciej.
- fixed "Word completion doesn't work at end of word (unless last word)"
- (http://bugzilla.opendarwin.org/show_bug.cgi?id=4062)
+ (http://bugs.webkit.org/show_bug.cgi?id=4062)
* WebView.subproj/WebHTMLView.m:
(-[WebTextCompleteController doCompletion]):
Reviewed by mjs. Committed by eseidel.
- Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5230
+ Fix for http://bugs.webkit.org/show_bug.cgi?id=5230
"characterIndexForPoint: not yet implemented"
* WebView.subproj/WebHTMLView.m:
Reviewed by Darin. Committed by David Harrison.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5415
+ http://bugs.webkit.org/show_bug.cgi?id=5415
"Left border of selection highlight leaves behind a trail"
* manual-tests/drag_select_highlighting.html: Added.
Reviewed by Dave Hyatt.
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=5365>
+ <http://bugs.webkit.org/show_bug.cgi?id=5365>
Send -webPlugInStop (or -pluginStop) and -webPluginDestroy (or -pluginDestroy)
to complying plugins right when they're removed from the WebHTMLView, and also
Reviewed and landed by Darin.
- fixed a couple regressions caused by my last check-in
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5437
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5443
+ http://bugs.webkit.org/show_bug.cgi?id=5437
+ http://bugs.webkit.org/show_bug.cgi?id=5443
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer CG_drawHighlightForRun:style:geometry:]): Compute background width
Changes by Mitz Pettel, reviewed by Maciej.
- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5029 (Assertion failure in -[NSPasteboard(WebExtras)
+ Fix http://bugs.webkit.org/show_bug.cgi?id=5029 (Assertion failure in -[NSPasteboard(WebExtras)
_web_writeImage:URL:title:archive:types:] when trying to drag an image from a site with no favicon)
* Misc.subproj/WebNSPasteboardExtras.m:
2005-10-11 Adele Peterson <adele@apple.com>
- Rolling out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5195
+ Rolling out fix for http://bugs.webkit.org/show_bug.cgi?id=5195
since it caused:
REGRESSION text areas draw focus ring around each glyph, no caret in text fields
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5335
+ http://bugs.webkit.org/show_bug.cgi?id=5335
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
Reviewed by Maciej.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5195
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=5195
Would like API to flush rendering of pending DOM changes
This was actually a Tiger regression. When AppKit added a new code path for rendering
Reviewed by Maciej.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5187
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=5187
UTF-8 in long text files breaks at some point
* WebView.subproj/WebTextRepresentation.m:
- fixed <rdar://problem/3217793> Monaco bold comes out as Helvetica bold, very bad if you choose Monaco as your fixed-width font
- fixed <rdar://problem/3256269> CSS1: bold/italic font styles not programmatically created if font doesn't include them (3231)
- also <http://bugzilla.opendarwin.org/show_bug.cgi?id=3231>
+ also <http://bugs.webkit.org/show_bug.cgi?id=3231>
* WebCoreSupport.subproj/WebTextRenderer.h: Removed public declarations of private structures that are not
used in the header. Removed the separate 16-bit character map; the difference in code size is only a few
Reviewed and landed by Darin.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5100
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=5100
-[WebTextRenderer _ATSU_drawRun:...] does not check view flippedness
* WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawRun:style:geometry:]):
Reviewed, tweaked a tiny bit, and landed by Darin.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4940
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4940
CG and ATSUI give different width to the same text
* WebCoreSupport.subproj/WebTextRenderer.m:
Reviewed by Dave.
Landed by Darin.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4862
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4862
Incorrect layout of bidi overrides
* WebCoreSupport.subproj/WebTextRenderer.m:
Tweaked, reviewed, and landed by Darin.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4394
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4394
Mouse clicks ignored in inline input areas
* WebView.subproj/WebHTMLView.m:
(in two places) to single lists in the corresponding
*Representation classes. Also moved the list of types
supported by WebCore (WebHTMLRepresentation) into WebCore.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5037
+ http://bugs.webkit.org/show_bug.cgi?id=5037
* WebView.subproj/WebDataSource.m:
(addTypesFromClass): new inline function
2005-09-16 Adele Peterson <adele@apple.com>
- Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
+ Rolling out the fix for http://bugs.webkit.org/show_bug.cgi?id=4924
QPainter should use CGContext as much as possible rather than NSGraphicsContext
since it caused a performance regression.
Change by Darin, reviewed by me and Maciej.
- Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
+ Fixes http://bugs.webkit.org/show_bug.cgi?id=4547
use int instead of long for 32-bit (to prepare for LP64 compiling)
* Plugins.subproj/npapi.m: changed types to match those defined in npapi.h
Reviewed by Maciej.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4924
QPainter should use CGContext as much as possible rather than NSGraphicsContext
* WebCoreSupport.subproj/WebImageRendererFactory.m: Remove setCGCompositeOperationFromString
Reviewed, tweaked, and landed by Darin.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4286
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4286
.Mac prefpane crashes when Safari using CVS WebKit is running
* WebView.subproj/WebView.m: (-[WebView initWithFrame:frameName:groupName:]):
Reviewed by Tim Omernick.
- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4070:
+ fixed http://bugs.webkit.org/show_bug.cgi?id=4070:
Find in plain text won't find only occurrence if it overlaps selection
* Misc.subproj/WebSearchableTextView.m:
Reviewed by John Sullivan.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4846
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4846
REGRESSION: Carbon WebKit applications don't work at all
* Carbon.subproj/HIWebView.m: Remove lots of unneeded declarations of private stuff.
Reviewed by John Sullivan.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4357
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4357
crash related to animated GIFs, reproducible in non-Safari WebKit application
* WebCoreSupport.subproj/WebImageData.m:
Reviewed and landed by Darin.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4604
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4604
LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout
<rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604)
Reviewed by Darin.
- 1% speedup on HTML load speed iBench by avoiding icon database thrash
- http://bugzilla.opendarwin.org/show_bug.cgi?id=4423
+ http://bugs.webkit.org/show_bug.cgi?id=4423
* Misc.subproj/WebIconDatabase.m:
(-[WebIconDatabase _setIconURL:forURL:]): Be more aggressive about returning early, because
Reviewed and landed by Darin.
- WebKit part of fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=4011>:
+ WebKit part of fix for <http://bugs.webkit.org/show_bug.cgi?id=4011>:
"Editing delegate selection methods not called when using mouse"
Clicking on editable content would move the cursor or alter the selection without
Reviewed by John Sullivan.
- fixed <rdar://problem/3996324> REGRESSION (1.2-2.0): scroll bars sometimes not updated properly (with >40 duplicate reports!)
- also http://bugzilla.opendarwin.org/show_bug.cgi?id=3416
+ also http://bugs.webkit.org/show_bug.cgi?id=3416
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
Fix for:
<rdar://problem/3167884> Shockwave: 3D sprites rendered in OpenGL draw over the browser (3447)
- also as <http://bugzilla.opendarwin.org/show_bug.cgi?id=3447>
+ also as <http://bugs.webkit.org/show_bug.cgi?id=3447>
The WindowRef created by -[NSWindow windowRef] has a QuickDraw GrafPort that covers
the entire window frame (or structure region in Carbon parlance) rather then just the window content.
Patch by Trey Matteson <trey@usa.net>
Reviewed by me.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4255
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=4255
underlines still print too thick
The real problem here is that we have code that scales a 0 width line to always
* WebCoreSupport.subproj/WebGraphicsBridge.m:
removed create*ColorSpace methods, now using CG API directly.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=4211
+ http://bugs.webkit.org/show_bug.cgi?id=4211
2005-07-31 John Sullivan <sullivan@apple.com>
Patch by Trey Matteson <trey@usa.net>
Reviewed by me.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4014
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=4014
PDF files by default load with a poor choice of sizing
For now the various PDF viewing settings are sticky, stored in 2 new defaults. Since
Reviewed by Maciej.
- Fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4226>
+ Fixed <http://bugs.webkit.org/show_bug.cgi?id=4226>
link underlines print too thickly
Reinstate the fix made by sullivan on 1/11/05. There was a merge
Reviewed by Dave Hyatt.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4153
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=4153
* WebView.subproj/WebFrame.m:
(-[WebFrame _purgePageCache]): Find the oldest candidate for
Patch by Trey Matteson <trey@usa.net>
Reviewed by me.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4169
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=4169
scaling PDF view up leaves later HTML view scaled too
An additional step of separating scaling of HTML and PDF. If we do a zoom and there
Patch by Trey Matteson <trey@usa.net>
Reviewed by me.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4015
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=4015
PDF views should remember viewing mode, scroll position across back/forward
Note this doesn't work within frames because of a PDFKit bug - see 4164
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4091
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=4091
PDF views should keep a separate scaling factor from shared text scaling factor
Basic idea #1 is that we now have a general mechanism for a WebDocView to save/restore some UI
Reviewed by John Sullivan.
- Fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4072>
+ Fixed <http://bugs.webkit.org/show_bug.cgi?id=4072>
Pressing back in browser misses out a page
* WebView.subproj/WebFrame.m:
Reviewed by john
- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3953> back-forward items have wrong titles after sub-frame navigations
+ Fixes <http://bugs.webkit.org/show_bug.cgi?id=3953> back-forward items have wrong titles after sub-frame navigations
This was caused by a mistaken data structure, where WebDataSource tried to keep a list of
b/f items it was responsible for. The problem arose in the case of frames, where a subframe
Reviewed by darin and hyatt
- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>
- The fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=3545> enclosed each run of visually ordered
+ Fixes <http://bugs.webkit.org/show_bug.cgi?id=3862>
+ The fix for <http://bugs.webkit.org/show_bug.cgi?id=3545> enclosed each run of visually ordered
hebrew with LRO and PDF control characters, but adjusted the run's to and from to include those characters,
so that they would be rendered if the font includes a glyph for bidi control characters.
Written by Trey Matteson <trey@usa.net>
Reviewed by John Sullivan.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4049
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=4049
scroll position not restored when going back/forward at ebay
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4061
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=4061
When going back/forward to some pages, they redraw at top before restoring scroll position
The short story is that attempting to restore the scroll position
Written by Trey Matteson <trey@usa.net>
Reviewed by John Sullivan.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3910 - REGRESSION: Replying "Cancel" to the form repost nag leaves wrong b/f cursor
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=3910 - REGRESSION: Replying "Cancel" to the form repost nag leaves wrong b/f cursor
* WebView.subproj/WebFrame.m:
(-[WebFrame _resetBackForwardList]): new helper method
Written by Trey Matteson
Reviewed by me.
- Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4013
+ Fix for http://bugs.webkit.org/show_bug.cgi?id=4013
text find doesn't wrap in PDF files
This just works once WebPDFView implements the WebDocumentText protocol, which is
2005-07-12 Geoffrey Garen <ggaren@apple.com>
-rolled in patch by opendarwin.org@mitzpettel.com
- for http://bugzilla.opendarwin.org/show_bug.cgi?id=3435
+ for http://bugs.webkit.org/show_bug.cgi?id=3435
Parentheses are backwards in Hebrew text (no bidi mirroring?)
Reviewed by mjs.
Rolled in patch by opendarwin.org@mitzpettel.com
- -fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3818
+ -fixes http://bugs.webkit.org/show_bug.cgi?id=3818
Fallback font doesn't have requested weight in ATSUI-rendered text
(See WebCore Changelog for layout test)
Reviewed by Darin Adler.
- - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3711: Displayed PDF have limited options in contextual menu
+ - fixed http://bugs.webkit.org/show_bug.cgi?id=3711: Displayed PDF have limited options in contextual menu
This was a problem with using Tiger's version of Safari with tip of tree WebKit.
Reviewed by John Sullivan.
- - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3774>
+ - fixed <http://bugs.webkit.org/show_bug.cgi?id=3774>
do renaming so that loaders are called "loader", not "client" or "delegate"
* Misc.subproj/WebIconLoader.h:
Reviewed by Darin.
- - Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3489>
+ - Fixes <http://bugs.webkit.org/show_bug.cgi?id=3489>
WebView's setSelectedDOMRange doesn't not implement clearing the selection as described in the WebView documentation:
<http://developer.apple.com/documentation/Cocoa/Reference/WebKit/ObjC_classic/Classes/WebView.html>
Reviewed by Darin
- - Fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3535>
+ - Fixed <http://bugs.webkit.org/show_bug.cgi?id=3535>
Spelling suggestions in the context menu don't call the should* delegate methods
* WebView.subproj/WebHTMLView.m:
Change by Mitz Pettel.
Reviewed by me.
- - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3618>
+ - fixed <http://bugs.webkit.org/show_bug.cgi?id=3618>
RTL runs drawn by CG not reversed properly
* WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:geometry:]):
Change by Michael Gaiman.
Reviewed by me.
- - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3436>
+ - fixed <http://bugs.webkit.org/show_bug.cgi?id=3436>
Missing implementation of -[NSData(WebNSDateExtras) _webkit_parseRFC822HeaderFields]
* Misc.subproj/WebNSDataExtras.h: Fixed name of category say NSData, not NSDate.
Changes by Mitz Pettel
Reviewed by me.
- - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3466>
+ - fixed <http://bugs.webkit.org/show_bug.cgi?id=3466>
ATSUI text doesn't render at coordinates greater than 32K
* WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawRun:style:geometry:]):
Changes by Mitz Pettel
Reviewed by Richard Williamson.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3545
+ Fixed http://bugs.webkit.org/show_bug.cgi?id=3545
* WebCoreSupport.subproj/WebTextRenderer.m:
(reverseCharactersInRun):
Reviewed by Chris Blumenberg and Adele.
- better fix for <rdar://problem/4142247> REGRESSION: List to browse widgets at Apple website failed. Closing tab afterwards caused Safari crash
- http://bugzilla.opendarwin.org/show_bug.cgi?id=3445
+ http://bugs.webkit.org/show_bug.cgi?id=3445
With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.
Reviewed by Maciej.
- fixed <rdar://problem/4141569> REGRESSION (412+): printing fails on any page with images, and for standalone images
- also <http://bugzilla.opendarwin.org/show_bug.cgi?id=3318>
+ also <http://bugs.webkit.org/show_bug.cgi?id=3318>
* WebCoreSupport.subproj/WebImageData.m: Got rid of use of tabs instead of spaces throughout the file.
(-[WebImageData _checkSolidColor:]): Wrap use of NSGraphicsContext with an autorelease pool.
Reviewed by Chris Blumenberg.
- fixed <rdar://problem/4142247> REGRESSION: List to browse widgets at Apple website failed. Closing tab afterwards caused Safari crash
- http://bugzilla.opendarwin.org/show_bug.cgi?id=3445
+ http://bugs.webkit.org/show_bug.cgi?id=3445
* WebView.subproj/WebFrame.m:
(-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data
Reviewed by me.
- fixed the WebKit half of build failure with spaces in the path
- http://bugzilla.opendarwin.org/show_bug.cgi?id=3291
+ http://bugs.webkit.org/show_bug.cgi?id=3291
* WebKit.pbproj/project.pbxproj: Quote DERIVED_FILE_DIR when it is substituted
into FRAMEWORK_SEARCH_PATHS, and SYMROOT when into HEADER_SEARCH_PATHS.
git://git.webkit.org / WebKit-https.git / commitdiff