Rubberstamped by Anders and Maciej aand Geoff (oh my!)

        Since CFTypeRef is really void*, a RetainPtr couldn't be used.
        RefType was "void", which doesn't actually exist as a type.
        Since RefType only existed for operator*(), and since that operator
        doesn't make any sense for RetainPtr, I removed them!

        * kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the
          compiler with dependencies
        * wtf/RetainPtr.h: Nuke RefType and operator*()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index f8f4f6b9bedc3f139e67fd0e7fbbfd39c5f097fb..e6cf6d6229786ab4bca9dc87ed2708849b997b25 100644 (file)
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,16 @@
+2007-03-26  Brady Eidson  <beidson@apple.com>
+
+        Rubberstamped by Anders and Maciej aand Geoff (oh my!)
+        
+        Since CFTypeRef is really void*, a RetainPtr couldn't be used. 
+        RefType was "void", which doesn't actually exist as a type.
+        Since RefType only existed for operator*(), and since that operator
+        doesn't make any sense for RetainPtr, I removed them!
+
+        * kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the
+          compiler with dependencies
+        * wtf/RetainPtr.h: Nuke RefType and operator*()
+
 2007-03-26  Geoffrey Garen  <ggaren@apple.com>
 
         Touched a file to (hopefully) help the compiler with RetainPtr dependencies.

diff --git a/JavaScriptCore/kjs/nodes.cpp b/JavaScriptCore/kjs/nodes.cpp
index fd66d29065b7e9f63d9f04b15856b48e8b34abdc..4746f4eec8f92154d7c00dde21a20b07107b9c2b 100644 (file)
--- a/JavaScriptCore/kjs/nodes.cpp
+++ b/JavaScriptCore/kjs/nodes.cpp
@@ -144,7 +144,7 @@ void Node::ref()
 void Node::deref()
 {
     ASSERT(!newNodes || !newNodes->contains(this));
-
+    
     if (!nodeExtraRefCounts) {
         delete this;
         return;

diff --git a/JavaScriptCore/wtf/RetainPtr.h b/JavaScriptCore/wtf/RetainPtr.h
index 1527b4292458c9c04f80dfe356756794f6a17194..4cd15e25033f7691a73c53b5fa5cab8b966efa2d 100644 (file)
--- a/JavaScriptCore/wtf/RetainPtr.h
+++ b/JavaScriptCore/wtf/RetainPtr.h
@@ -57,7 +57,6 @@ namespace WTF {
     public:
         typedef typename RemovePointer<T>::type ValueType;
         typedef ValueType* PtrType;
-        typedef ValueType& RefType;
 
         RetainPtr() : m_ptr(0) {}
         RetainPtr(PtrType ptr) : m_ptr(ptr) { if (ptr) CFRetain(ptr); }
@@ -75,7 +74,6 @@ namespace WTF {
         
         PtrType releaseRef() { PtrType tmp = m_ptr; m_ptr = 0; return tmp; }
         
-        RefType operator*() const { return *m_ptr; }
         PtrType operator->() const { return m_ptr; }
         
         bool operator!() const { return !m_ptr; }