<rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn...

https://bugs.webkit.org/show_bug.cgi?id=69727

Reviewed by Anders Carlsson.

* platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
obey its flippedness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 720be64f448b71ae2b3406a7d44ac424d1bb6c43..0b250c8a2c67a86e1e7f7fb1c2cb01436bc9c412 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,14 @@
+2011-10-09  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
+        https://bugs.webkit.org/show_bug.cgi?id=69727
+
+        Reviewed by Anders Carlsson.
+
+        * platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
+        used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
+        obey its flippedness.
+
 2011-10-09  Benjamin Poulain  <benjamin@webkit.org>
 
         Do not compare the first glyph to itself in Font::drawGlyphBuffer()

diff --git a/Source/WebCore/platform/mac/ThemeMac.mm b/Source/WebCore/platform/mac/ThemeMac.mm
index 9cd42ecab909868104d6d423ee3ab8ac30816e6a..480354df91a85e6211222788569904f2e07d48f0 100644 (file)
--- a/Source/WebCore/platform/mac/ThemeMac.mm
+++ b/Source/WebCore/platform/mac/ThemeMac.mm
@@ -37,7 +37,7 @@
 using namespace std;
 
 // This is a view whose sole purpose is to tell AppKit that it's flipped.
-@interface WebCoreFlippedView : NSView
+@interface WebCoreFlippedView : NSControl
 @end
 
 @implementation WebCoreFlippedView