Reviewed by Kevin.

        - fixed <rdar://problem/3969884> REGRESSION (179-180): Typing password not echoed as "bullets" at paypal.com when field is first focused

        * kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]):
        Sizing up the form editor, which fixes things for normal fields and search fields,
        screws things up for password fields. Eventually, I'll need to figure out why this is
        and file a bug so that the AppKit team fixes it. In the mean time, just check for the
        case of the secure text field, and don't size up in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 92d437aa9ddcdbb7991e52243a3852767ba9128b..bd1e55b9c3d30e9df40581d89cca3415bd9705d5 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,15 @@
+2005-01-24  Darin Adler  <darin@apple.com>
+
+        Reviewed by Kevin.
+
+        - fixed <rdar://problem/3969884> REGRESSION (179-180): Typing password not echoed as "bullets" at paypal.com when field is first focused
+
+        * kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]):
+        Sizing up the form editor, which fixes things for normal fields and search fields,
+        screws things up for password fields. Eventually, I'll need to figure out why this is
+        and file a bug so that the AppKit team fixes it. In the mean time, just check for the
+        case of the secure text field, and don't size up in that case.
+
 2005-01-24  Ken Kocienda  <kocienda@apple.com>
 
         Reviewed by Hyatt

diff --git a/WebCore/kwq/KWQTextField.mm b/WebCore/kwq/KWQTextField.mm
index 81f9d6efcc238ec9b3297019970dccb576b27a62..7816db5de67a955d43826622bed166b54d833974 100644 (file)
--- a/WebCore/kwq/KWQTextField.mm
+++ b/WebCore/kwq/KWQTextField.mm
@@ -99,7 +99,11 @@
     // Set a non-empty size in case the field is made first responder before it
     // is positioned and sized by KHTML code. This dodges bad behavior in AppKit
     // if you try to create an editor for a 0-sized text field.
-    [field setFrameSize:NSMakeSize(100, 100)];
+    // For a secure text field, this is both unnecessary and harmful, so leave
+    // it out; worth figuring out why at some point.
+    if (![field isKindOfClass:[NSSecureTextField class]]) {
+        [field setFrameSize:NSMakeSize(100, 100)];
+    }
 
     return self;
 }