2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Dec 2009 12:56:49 +0000 (12:56 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Dec 2009 12:56:49 +0000 (12:56 +0000)
        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Prevent the inspector from closing its wrapping widget.
        This is not necessary anymore since we now hide the embedded
        close button.
        https://bugs.webkit.org/show_bug.cgi?id=32149

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::showWindow):
        (WebCore::InspectorClientQt::closeWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/qt/ChangeLog
WebKit/qt/WebCoreSupport/InspectorClientQt.cpp

index cc1dc4b8607ce3344803c0c81f841695a1db9e97..9d472124dcc713fcfb17ace6d5dc8b04390aef6b 100644 (file)
@@ -1,3 +1,16 @@
+2009-12-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Prevent the inspector from closing its wrapping widget.
+        This is not necessary anymore since we now hide the embedded
+        close button.
+        https://bugs.webkit.org/show_bug.cgi?id=32149
+
+        * WebCoreSupport/InspectorClientQt.cpp:
+        (WebCore::InspectorClientQt::showWindow):
+        (WebCore::InspectorClientQt::closeWindow):
+
 2009-12-03  İsmail Dönmez  <ismail@namtrac.org>
 
         Reviewed by Eric Seidel.
index bafdb8415ce73bfd4a2fe5eb10af046a3ef56ee2..d5683c4afc81922288fd6d1df4d453b120f96275 100644 (file)
@@ -113,16 +113,11 @@ void InspectorClientQt::showWindow()
     updateWindowTitle();
 
     m_inspectedWebPage->d->inspectorController()->setWindowVisible(true, true);
-    // We don't allow the inspector to ask for widget visibility itself because showWindow is
-    // not always called when we want.
-    // Inspecting an element or calling QWebInspector::show() should already have made the
-    // widget visible.
 }
 
 void InspectorClientQt::closeWindow()
 {
-    if (m_inspectedWebPage->d->inspector)
-        m_inspectedWebPage->d->inspector->close();
+    m_inspectedWebPage->d->inspectorController()->setWindowVisible(false);
 }
 
 void InspectorClientQt::attachWindow()