2011-01-03 Mihai Parparita <mihaip@chromium.org>

        Unreviewed.

        NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
        https://bugs.webkit.org/show_bug.cgi?id=51151

        Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
        so that it can match Safari's (and thus use the same baselines).

        No new tests, should be covered by layout tests (which will need
        expectation changes)

        * platform/chromium/ScrollbarThemeChromiumMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 7ad58c1e26f2bb5ba5f6b3cc841b85841e883298..9c0a9d3d080b7298e5a2c4f4573451ca2cb5af35 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2011-01-03  Mihai Parparita  <mihaip@chromium.org>
+
+        Unreviewed.
+
+        NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
+        https://bugs.webkit.org/show_bug.cgi?id=51151
+
+        Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
+        so that it can match Safari's (and thus use the same baselines).
+
+        No new tests, should be covered by layout tests (which will need
+        expectation changes)
+
+        * platform/chromium/ScrollbarThemeChromiumMac.mm:
+
 2011-01-03  Antonio Gomes  <agomes@rim.com>
 
         Unreviewed build fix for WebKit/Gtk+.

diff --git a/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm b/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
index fad692838d5ef31fc77362d456bd0b0b4a0f4d68..221577532dd7453217a96020efbe8a0a6c6a89f1 100644 (file)
--- a/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
+++ b/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
@@ -27,9 +27,8 @@
 #include "config.h"
 #include "ScrollbarThemeChromiumMac.h"
 
-// FIXME: Remove this (always use WebThemeEngine) once the implementation has
-// landed downstream in Chromium.
-#define USE_WEB_THEME_ENGINE_TO_PAINT_THUMB 0
+// FIXME: Remove this (always use WebThemeEngine) once we rebaseline tests
+#define USE_WEB_THEME_ENGINE_TO_PAINT_THUMB 1
 
 #if USE_WEB_THEME_ENGINE_TO_PAINT_THUMB
 #include "ChromiumBridge.h"