Coordinated Graphics: remove redundant update of non compositing layer.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Feb 2013 07:47:35 +0000 (07:47 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Feb 2013 07:47:35 +0000 (07:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=110444

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-25
Reviewed by Noam Rosenthal.

Currently, we update non compositing layer when the page scrolled. However, it
is not needed, because TiledBackingStore can scroll without tile update.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h

index 4a6cadd..caa9272 100644 (file)
@@ -1,3 +1,18 @@
+2013-02-25  Huang Dongsung  <luxtella@company100.net>
+
+        Coordinated Graphics: remove redundant update of non compositing layer.
+        https://bugs.webkit.org/show_bug.cgi?id=110444
+
+        Reviewed by Noam Rosenthal.
+
+        Currently, we update non compositing layer when the page scrolled. However, it
+        is not needed, because TiledBackingStore can scroll without tile update.
+
+        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+        (WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
+        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
+        (CoordinatedLayerTreeHost):
+
 2013-02-25  Jer Noble  <jer.noble@apple.com>
 
         REGRESSION(r143981): Crash in WebFrameLoaderClient::dispatchDidStartProvisionalLoad()
index 0dd2817..644e378 100644 (file)
@@ -195,9 +195,9 @@ void CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplayInRect(const W
     scheduleLayerFlush();
 }
 
-void CoordinatedLayerTreeHost::scrollNonCompositedContents(const WebCore::IntRect& scrollRect)
+void CoordinatedLayerTreeHost::scrollNonCompositedContents(const WebCore::IntRect&)
 {
-    setNonCompositedContentsNeedDisplayInRect(scrollRect);
+    // Do nothing because we scroll using TiledBackingStore.
 }
 
 void CoordinatedLayerTreeHost::forceRepaint()
index 8446f6f..b605289 100644 (file)
@@ -66,7 +66,7 @@ public:
 
     virtual void setNonCompositedContentsNeedDisplay() OVERRIDE;
     virtual void setNonCompositedContentsNeedDisplayInRect(const WebCore::IntRect&) OVERRIDE;
-    virtual void scrollNonCompositedContents(const WebCore::IntRect& scrollRect);
+    virtual void scrollNonCompositedContents(const WebCore::IntRect&) OVERRIDE;
     virtual void forceRepaint();
     virtual bool forceRepaintAsync(uint64_t callbackID);
     virtual void sizeDidChange(const WebCore::IntSize& newSize);