git://git.webkit.org / WebKit-https.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0a3b409)
[ATK] Incorrect type for holding float value
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Sep 2013 14:46:13 +0000 (14:46 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Sep 2013 14:46:13 +0000 (14:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=121091

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-10
Reviewed by Mario Sanchez Prada.

Tools:

Variable is not set properly, because of it's type.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::alterCurrentValue):

LayoutTests:

Sharing specific mac tests with efl and gtk.

* accessibility/aria-slider-value-change-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-slider-value-change-expected.txt.
* accessibility/aria-slider-value-change.html: Renamed from LayoutTests/platform/mac/accessibility/aria-slider-value-change.html.
* accessibility/range-alter-by-step-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/range-alter-by-step-expected.txt.
* accessibility/range-alter-by-step.html: Renamed from LayoutTests/platform/mac/accessibility/range-alter-by-step.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog patch | blob | history
LayoutTests/accessibility/aria-slider-value-change-expected.txt [moved from LayoutTests/platform/mac/accessibility/aria-slider-value-change-expected.txt with 100% similarity] patch | blob | history
LayoutTests/accessibility/aria-slider-value-change.html [moved from LayoutTests/platform/mac/accessibility/aria-slider-value-change.html with 89% similarity] patch | blob | history
LayoutTests/accessibility/range-alter-by-step-expected.txt [moved from LayoutTests/platform/mac/accessibility/range-alter-by-step-expected.txt with 100% similarity] patch | blob | history
LayoutTests/accessibility/range-alter-by-step.html [moved from LayoutTests/platform/mac/accessibility/range-alter-by-step.html with 91% similarity] patch | blob | history
Tools/ChangeLog patch | blob | history
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp patch | blob | history

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 8b64481067be28e1deef01267c35fede0f59a307..15e8f390e0814796a97c7e7c517caa713abdd5ce 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,17 @@
+2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
+
+        [ATK] Incorrect type for holding float value
+        https://bugs.webkit.org/show_bug.cgi?id=121091
+
+        Reviewed by Mario Sanchez Prada.
+
+        Sharing specific mac tests with efl and gtk.
+
+        * accessibility/aria-slider-value-change-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-slider-value-change-expected.txt.
+        * accessibility/aria-slider-value-change.html: Renamed from LayoutTests/platform/mac/accessibility/aria-slider-value-change.html.
+        * accessibility/range-alter-by-step-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/range-alter-by-step-expected.txt.
+        * accessibility/range-alter-by-step.html: Renamed from LayoutTests/platform/mac/accessibility/range-alter-by-step.html.
+
 2013-09-10  Krzysztof Wolanski  <k.wolanski@samsung.com>
 
         [EFL] Changed expected results after r154702
diff --git a/LayoutTests/platform/mac/accessibility/aria-slider-value-change.html b/LayoutTests/accessibility/aria-slider-value-change.html
similarity index 89%
rename from LayoutTests/platform/mac/accessibility/aria-slider-value-change.html
rename to LayoutTests/accessibility/aria-slider-value-change.html
index 453205a372c6349666f492f957194466fccca2af..4ee292c279f3b902e75706badef7d36f64eb4179 100644 (file)
--- a/LayoutTests/platform/mac/accessibility/aria-slider-value-change.html
+++ b/LayoutTests/accessibility/aria-slider-value-change.html
@@ -1,7 +1,7 @@
 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
 <html>
 <head>
-<script src="../../../resources/js-test-pre.js"></script>
+<script src="../resources/js-test-pre.js"></script>
 </head>
 <body id="body">
 
@@ -35,6 +35,6 @@
 
 </script>
 
-<script src="../../../resources/js-test-post.js"></script>
+<script src="../resources/js-test-post.js"></script>
 </body>
 </html>
diff --git a/LayoutTests/platform/mac/accessibility/range-alter-by-step.html b/LayoutTests/accessibility/range-alter-by-step.html
similarity index 91%
rename from LayoutTests/platform/mac/accessibility/range-alter-by-step.html
rename to LayoutTests/accessibility/range-alter-by-step.html
index 4bc7b35c919fe5e90e1c2eeaf60cec25e50b2905..9056e2d012ebcd6bbeda5daffe13f308a45dd21b 100644 (file)
--- a/LayoutTests/platform/mac/accessibility/range-alter-by-step.html
+++ b/LayoutTests/accessibility/range-alter-by-step.html
@@ -1,7 +1,7 @@
 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
 <html>
 <head>
-<script src="../../../resources/js-test-pre.js"></script>
+<script src="../resources/js-test-pre.js"></script>
 </head>
 <body id="body">
 
@@ -52,6 +52,6 @@
 
 </script>
 
-<script src="../../../resources/js-test-post.js"></script>
+<script src="../resources/js-test-post.js"></script>
 </body>
 </html>
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index c4742e563d7bcd46813560067b1664577aa4e54e..b05d4d76f8efb16b7d4cebcf400ef901a86ae2e1 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,15 @@
+2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
+
+        [ATK] Incorrect type for holding float value
+        https://bugs.webkit.org/show_bug.cgi?id=121091
+
+        Reviewed by Mario Sanchez Prada.
+
+        Variable is not set properly, because of it's type.
+
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        (WTR::alterCurrentValue):
+
 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 
         [Qt] make use of qtHaveModule() 
diff --git a/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp b/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
index ddab8f4e77c0809a1fbf20f9925f5747b218d3a9..a005f15f8c8d1da1788064448cd2b8c0791cd8e5 100644 (file)
--- a/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
+++ b/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
@@ -158,7 +158,7 @@ static void alterCurrentValue(PlatformUIElement element, int factor)
     atk_value_get_minimum_increment(ATK_VALUE(element.get()), &increment);
 
     GValue newValue = G_VALUE_INIT;
-    g_value_init(&newValue, G_TYPE_DOUBLE);
+    g_value_init(&newValue, G_TYPE_FLOAT);
 
     g_value_set_float(&newValue, g_value_get_float(&currentValue) + factor * g_value_get_float(&increment));
     atk_value_set_current_value(ATK_VALUE(element.get()), &newValue);
Mirror of the WebKit open source project from svn.webkit.org.