Reviewed by Anders.
- Test for http://bugs.webkit.org/show_bug.cgi?id=11172
REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
* fast/forms/listbox-width-change-expected.txt: Added.
* fast/forms/listbox-width-change-expected.png: Added.
* fast/forms/listbox-width-change-expected.checksum: Added.
* fast/forms/listbox-width-change.html: Added.
WebCore:
Reviewed by Anders.
- Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
Test: fast/forms/listbox-width-change.html
* rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
When the options change, call setNeedsLayoutAndMinMaxRecalc.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2006-10-12 Adele Peterson <adele@apple.com>
+
+ Reviewed by Anders.
+
+ - Test for http://bugs.webkit.org/show_bug.cgi?id=11172
+ REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
+
+ * fast/forms/listbox-width-change-expected.txt: Added.
+ * fast/forms/listbox-width-change-expected.png: Added.
+ * fast/forms/listbox-width-change-expected.checksum: Added.
+ * fast/forms/listbox-width-change.html: Added.
+
2006-10-11 Kevin McCullough <KMcCullough@apple.com>
Reviewed by Darin.
--- /dev/null
+aa56fa2fd143bd536e2616a4c5fee276
\ No newline at end of file
--- /dev/null
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderText {#text} at (0,0) size 650x18
+ text run at (0,0) width 650: "This tests that when a list box's options get updated, the list box will recalculate its width, and relayout. "
+ RenderBR {BR} at (0,0) size 0x0
+ RenderListBox {SELECT} at (2,20) size 197x58 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
--- /dev/null
+<html>
+ <head>
+ <script>
+ function test() {
+ if (window.layoutTestController)
+ layoutTestController.waitUntilDone();
+ setTimeout("test2()", 100);
+ }
+ function test2() {
+ document.getElementById('sl').options[0] = new Option ( "This text should fit in the list box", "1" );
+ if (window.layoutTestController)
+ layoutTestController.notifyDone();
+ }
+ </script>
+ </head>
+ <body onload="test()">
+ This tests that when a list box's options get updated, the list box will recalculate its width, and relayout.
+ <br>
+ <select id="sl" multiple></select>
+ </body>
+</html>
+2006-10-12 Adele Peterson <adele@apple.com>
+
+ Reviewed by Anders.
+
+ - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
+ REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
+
+ Test: fast/forms/listbox-width-change.html
+
+ * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
+ When the options change, call setNeedsLayoutAndMinMaxRecalc.
+
2006-10-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
}
m_optionsWidth = static_cast<int>(ceilf(width));
m_optionsChanged = false;
+ setNeedsLayoutAndMinMaxRecalc();
}
}