Reviewed by Adam

        - fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled
          or saved for .Mac homepage login

        * page/mac/FrameMac.mm:
        (WebCore::Frame::searchForLabelsBeforeElement):
        don't count empty strings as valid results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 5f9a2e451feb0037eced3b4205303e81591225fd..b1ebe31d381922728fb07aa1e39185c7c27f228e 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,14 @@
+2007-03-21  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Adam
+        
+        - fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled 
+          or saved for .Mac homepage login
+
+        * page/mac/FrameMac.mm:
+        (WebCore::Frame::searchForLabelsBeforeElement):
+        don't count empty strings as valid results
+
 2007-03-21  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by darin

diff --git a/WebCore/page/mac/FrameMac.mm b/WebCore/page/mac/FrameMac.mm
index 8d0e1d4d8f1abff8ff52c0f75c64a1a193183d5b..ffa60b61f0fb02069b9a781d6f5683256c4c8b8d 100644 (file)
--- a/WebCore/page/mac/FrameMac.mm
+++ b/WebCore/page/mac/FrameMac.mm
@@ -265,7 +265,7 @@ NSString* Frame::searchForLabelsBeforeElement(NSArray* labels, Element* element)
             startingTableCell = static_cast<HTMLTableCellElement*>(n);
         } else if (n->hasTagName(trTag) && startingTableCell) {
             NSString* result = searchForLabelsAboveCell(regExp, startingTableCell);
-            if (result) {
+            if (result && [result length] > 0) {
                 return result;
             }
             searchedCellAbove = true;