2008-01-12 Alp Toker <alp@atoker.com>
authoralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 13 Jan 2008 07:33:53 +0000 (07:33 +0000)
committeralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 13 Jan 2008 07:33:53 +0000 (07:33 +0000)
        Reviewed by Mark Rowe.

        Hide non-public symbols in GTK+/autotools release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
GNUmakefile.am
JavaScriptCore/ChangeLog
JavaScriptCore/GNUmakefile.am
WebKitTools/ChangeLog
WebKitTools/GNUmakefile.am

index ab7ba0f..4c4ed82 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-01-12  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Mark Rowe.
+
+        Hide non-public symbols in GTK+/autotools release builds.
+
+        * GNUmakefile.am:
+
 2008-01-11  Alp Toker  <alp@atoker.com>
 
         Reviewed by Oliver Hunt.
index 95eb1fb..7df3d57 100644 (file)
@@ -34,8 +34,6 @@ GENSOURCES := $(top_builddir)/DerivedSources
 CREATE_HASH_TABLE = $(srcdir)/JavaScriptCore/kjs/create_hash_table
 
 # Libraries and support components
-noinst_LTLIBRARIES :=
-
 noinst_HEADERS :=
 
 noinst_PROGRAMS :=
@@ -63,10 +61,21 @@ global_cflags := \
        -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type \
        -Wformat -Wformat-security -Wno-format-y2k -Wundef \
        -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings \
-       -Wno-unused-parameter -fno-exceptions -fno-strict-aliasing
+       -Wno-unused-parameter
+
+if !ENABLE_DEBUG
+global_cflags += \
+       -fno-rtti -fno-exceptions \
+       -fvisibility=hidden -fvisibility-inlines-hidden
+endif
+
+# Shared libraries
+lib_LTLIBRARIES = \
+       libWebKitGtk.la
 
-# Libraries
-lib_LTLIBRARIES = libJavaScriptCore.la libWebKitGtk.la
+# Convenience libraries
+noinst_LTLIBRARIES = \
+       libJavaScriptCore.la
 
 #
 # JavaScriptCore
@@ -79,19 +88,19 @@ javascriptcore_built_nosources :=
 # The variables above are already included below so no need to touch
 # these variables unless you really have to
 libJavaScriptCore_ladir = $(prefix)/include/WebKit/JavaScriptCore
-libJavaScriptCore_la_HEADERS := $(javascriptcore_h_api)
+libJavaScriptCore_la_HEADERS = $(javascriptcore_h_api)
 
-libJavaScriptCore_la_SOURCES := \
+libJavaScriptCore_la_SOURCES = \
        $(javascriptcore_built_sources) \
        $(javascriptcore_sources)
 
-libJavaScriptCore_la_LDFLAGS := -lpthread
+libJavaScriptCore_la_LDFLAGS = -lpthread
 
-libJavaScriptCore_la_CXXFLAGS := $(global_cflags)
+libJavaScriptCore_la_CXXFLAGS = $(global_cflags) -fstrict-aliasing
 
-libJavaScriptCore_la_CFLAGS := $(global_cflags)
+libJavaScriptCore_la_CFLAGS = $(global_cflags) -fstrict-aliasing
 
-libJavaScriptCore_la_CPPFLAGS := $(global_cppflags) $(javascriptcore_cppflags)
+libJavaScriptCore_la_CPPFLAGS = $(global_cppflags) $(javascriptcore_cppflags)
 
 #
 # WebCore
@@ -115,9 +124,9 @@ webkitgtk_cleanfiles :=
 # for the following variables, use the "webkitgtk_" variables above
 libWebKitGtk_ladir := $(prefix)/include/WebKit
 
-libWebKitGtk_la_HEADERS := $(webkitgtk_h_api)
+libWebKitGtk_la_HEADERS = $(webkitgtk_h_api)
 
-libWebKitGtk_la_SOURCES := \
+libWebKitGtk_la_SOURCES = \
        $(webcore_built_sources) \
        $(webcore_headers) \
        $(webcore_sources) \
@@ -125,8 +134,8 @@ libWebKitGtk_la_SOURCES := \
        $(webkitgtk_headers) \
        $(webkitgtk_sources)
 
-libWebKitGtk_la_CXXFLAGS := \
-       -fno-rtti \
+libWebKitGtk_la_CXXFLAGS = \
+       -fno-strict-aliasing \
        $(global_cflags) \
        $(DEPENDENCIES_CFLAGS) \
        $(SQLITE3_CFLAGS) \
@@ -134,7 +143,8 @@ libWebKitGtk_la_CXXFLAGS := \
        $(LIBXSLT_CFLAGS) \
        $(COVERAGE_CFLAGS)
 
-libWebKitGtk_la_CFLAGS := \
+libWebKitGtk_la_CFLAGS = \
+       -fno-strict-aliasing \
        $(global_cflags) \
        $(DEPENDENCIES_CFLAGS) \
        $(SQLITE3_CFLAGS) \
@@ -142,14 +152,14 @@ libWebKitGtk_la_CFLAGS := \
        $(LIBXSLT_CFLAGS) \
        $(COVERAGE_CFLAGS)
 
-libWebKitGtk_la_CPPFLAGS := \
+libWebKitGtk_la_CPPFLAGS = \
        $(global_cppflags) \
        $(webcore_cppflags) \
        $(webkitgtk_cppflags)
 
-libWebKitGtk_la_LIBADD := @LTLIBOBJS@ libJavaScriptCore.la
+libWebKitGtk_la_LIBADD = libJavaScriptCore.la
 
-libWebKitGtk_la_LDFLAGS := \
+libWebKitGtk_la_LDFLAGS = \
        $(webkitgtk_ldflags) \
        $(DEPENDENCIES_LIBS) \
        $(ICU_LIBS) \
@@ -295,7 +305,7 @@ include WebKitTools/GNUmakefile.am
 
 
 # Autogenerated sources
-BUILT_SOURCES := \
+BUILT_SOURCES = \
        $(javascriptcore_built_sources) \
        $(javascriptcore_built_nosources) \
        $(webcore_built_sources) \
@@ -308,7 +318,6 @@ CLEANFILES += \
        $(webkitgtk_cleanfiles) \
        $(top_builddir)/Programs/DumpRenderTree \
        $(top_builddir)/Programs/testkjs \
-       $(top_builddir)/Programs/dftables \
        $(GENSOURCES)
 
 MAINTAINERCLEANFILES += \
index 3a1c079..d18d4d4 100644 (file)
@@ -1,3 +1,11 @@
+2008-01-12  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Mark Rowe.
+
+        Hide non-public symbols in GTK+/autotools release builds.
+
+        * GNUmakefile.am:
+
 2008-01-12  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
 
         Reviewed by Mark Rowe.
index 7dd767b..52f7d0d 100644 (file)
@@ -149,14 +149,14 @@ Programs_minidom_SOURCES = \
        JavaScriptCore/API/NodeList.c \
        JavaScriptCore/API/minidom.c
 Programs_minidom_CPPFLAGS = $(global_cppflags)
-Programs_minidom_CXXFLAGS = $(ICU_CFLAGS)
+Programs_minidom_CXXFLAGS = $(global_cflags) $(ICU_CFLAGS)
 Programs_minidom_LDADD = $(ICU_LIBS) libJavaScriptCore.la
 Programs_minidom_LDFLAGS = -rpath $(CURDIR)/.libs
 
 # testkjs
 Programs_testkjs_SOURCES = JavaScriptCore/kjs/testkjs.cpp
 Programs_testkjs_CPPFLAGS = $(global_cppflags)
-Programs_testkjs_CXXFLAGS = $(ICU_CFLAGS)
+Programs_testkjs_CXXFLAGS = $(global_cflags) $(ICU_CFLAGS)
 Programs_testkjs_LDADD = $(ICU_LIBS) libJavaScriptCore.la
 Programs_testkjs_LDFLAGS = -rpath $(CURDIR)/.libs
 
index e0987a9..0ab6e9c 100644 (file)
@@ -1,3 +1,11 @@
+2008-01-12  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Mark Rowe.
+
+        Hide non-public symbols in GTK+/autotools release builds.
+
+        * GNUmakefile.am:
+
 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 
         Reviewed by Ap.
index d6be712..e070587 100644 (file)
@@ -1,20 +1,23 @@
-noinst_PROGRAMS += Programs/GtkLauncher Programs/DumpRenderTree
+noinst_PROGRAMS += \
+       Programs/GtkLauncher \
+       Programs/DumpRenderTree
 
 # GtkLauncher
-Programs_GtkLauncher_CPPFLAGS := \
+Programs_GtkLauncher_CPPFLAGS = \
        -I $(srcdir)/WebKit/gtk/WebView \
        $(global_cppflags)
 
-Programs_GtkLauncher_SOURCES := WebKitTools/GtkLauncher/main.c
+Programs_GtkLauncher_SOURCES = \
+       WebKitTools/GtkLauncher/main.c
 
-Programs_GtkLauncher_CFLAGS := \
+Programs_GtkLauncher_CFLAGS = \
        $(DEPENDENCIES_CFLAGS) \
        $(ICU_CFLAGS) \
        $(SQLITE3_CFLAGS) \
        $(GSTREAMER_CFLAGS) \
        $(LIBXSLT_CFLAGS)
 
-Programs_GtkLauncher_LDADD := \
+Programs_GtkLauncher_LDADD = \
        $(DEPENDENCIES_LIBS) \
        $(ICU_LIBS) \
        $(SQLITE3_LIBS) \
@@ -23,16 +26,16 @@ Programs_GtkLauncher_LDADD := \
        libJavaScriptCore.la \
        libWebKitGtk.la
 
-Programs_GtkLauncher_LDFLAGS := -ljpeg -rpath $(CURDIR)/.libs
+Programs_GtkLauncher_LDFLAGS = -ljpeg -rpath $(CURDIR)/.libs
 
 # DumpRenderTree
-Programs_DumpRenderTree_CPPFLAGS := \
+Programs_DumpRenderTree_CPPFLAGS = \
        -I $(srcdir)/WebKitTools/DumpRenderTree \
        -I $(srcdir)/WebKitTools/DumpRenderTree/gtk \
        -I $(srcdir)/WebKit/gtk/WebView \
        $(global_cppflags)
 
-Programs_DumpRenderTree_SOURCES := \
+Programs_DumpRenderTree_SOURCES = \
        WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp \
        WebKitTools/DumpRenderTree/LayoutTestController.cpp \
        WebKitTools/DumpRenderTree/GCController.cpp \
@@ -41,6 +44,6 @@ Programs_DumpRenderTree_SOURCES := \
        WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp \
        WebKitTools/DumpRenderTree/gtk/WorkQueueItemGtk.cpp
 
-Programs_DumpRenderTree_CXXFLAGS := $(DEPENDENCIES_CFLAGS) $(AM_CXXFLAGS)
-Programs_DumpRenderTree_LDADD := $(DEPENDENCIES_LIBS) libJavaScriptCore.la libWebKitGtk.la
-Programs_DumpRenderTree_LDFLAGS := -rpath $(CURDIR)/.libs 
+Programs_DumpRenderTree_CXXFLAGS = $(DEPENDENCIES_CFLAGS) $(AM_CXXFLAGS)
+Programs_DumpRenderTree_LDADD = $(DEPENDENCIES_LIBS) libJavaScriptCore.la libWebKitGtk.la
+Programs_DumpRenderTree_LDFLAGS = -rpath $(CURDIR)/.libs